You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2023/07/10 14:04:05 UTC

[GitHub] [skywalking] mrproliu opened a new pull request, #11070: Add description and document link into the UI menu query protocol

mrproliu opened a new pull request, #11070:
URL: https://github.com/apache/skywalking/pull/11070

   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] wu-sheng merged pull request #11070: Add description and document link into the UI menu query protocol

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #11070:
URL: https://github.com/apache/skywalking/pull/11070


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] wu-sheng commented on pull request #11070: Add description and document link into the UI menu query protocol

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11070:
URL: https://github.com/apache/skywalking/pull/11070#issuecomment-1629197572

   @mrproliu e2e fail, please recheck.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11070: Add description and document link into the UI menu query protocol

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11070:
URL: https://github.com/apache/skywalking/pull/11070#discussion_r1258374318


##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/menu.yaml:
##########
@@ -18,90 +18,156 @@
 #     icon: icon name
 #     layer: related layer name, the menu item should be activated when layer has services
 #     menus: sub menus of the current item
+#     description: the description of the menu item
+#     documentLink: The document link for the latest version of this feature
 
 menus:
   - title: General Service
     icon: general_service
+    description:  Observe services and relative direct dependencies through telemetry data collected from SkyWalking Agents.
     menus:
       - title: Services
         layer: GENERAL
+        description: Observe services through telemetry data collected from SkyWalking Agent.
+        documentLink: https://skywalking.apache.org/docs/main/next/en/setup/service-agent/server-agents/

Review Comment:
   @Fine0830 We added `description` and `documentLink` as we discussed. 
   - description, represents the comments showing as a description of the catalog, or the leaf feature.
   - documentLink, provides an extra link, usually for now, only for the leaf feature. On the marketplace page, we should add another link button for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org