[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #233: Apply Baseline plugin to iceberg-hive

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #233: Apply Baseline plugin to iceberg-hive
URL: https://github.com/apache/incubator-iceberg/pull/233#discussion_r297658705
 
 

 ##########
 File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
 ##########
 @@ -127,24 +131,25 @@ public void commit(TableMetadata base, TableMetadata metadata) {
       } else {
         final long currentTimeMillis = System.currentTimeMillis();
         tbl = new Table(tableName,
-                database,
-                System.getProperty("user.name"),
-                (int) currentTimeMillis / 1000,
-                (int) currentTimeMillis / 1000,
-                Integer.MAX_VALUE,
-                storageDescriptor(metadata),
-                Collections.emptyList(),
-                new HashMap<>(),
-                null,
-                null,
-                ICEBERG_TABLE_TYPE_VALUE);
+            database,
+            System.getProperty("user.name"),
+            (int) currentTimeMillis / 1000,
+            (int) currentTimeMillis / 1000,
+            Integer.MAX_VALUE,
+            storageDescriptor(metadata),
+            Collections.emptyList(),
+            new HashMap<>(),
+            null,
+            null,
+            ICEBERG_TABLE_TYPE_VALUE);
       }
 
       tbl.setSd(storageDescriptor(metadata)); // set to pickup any schema changes
       final String metadataLocation = tbl.getParameters().get(METADATA_LOCATION_PROP);
       if (!Objects.equals(currentMetadataLocation(), metadataLocation)) {
-        throw new CommitFailedException(format("metadataLocation = %s is not same as table metadataLocation %s for %s.%s",
-                currentMetadataLocation(), metadataLocation, database, tableName));
+        String errMsg = String.format("metadataLocation = %s is not same as table metadataLocation %s for %s.%s",
 
 Review comment:
   Same, CommitFailedException supports formatting. We do not need to wrap it with `String.fromat`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org