You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2016/12/12 14:37:08 UTC
Review Request 54662: Enabled authorization in SET_LOG_LEVEL API call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54662/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-6670
https://issues.apache.org/jira/browse/MESOS-6670
Repository: mesos
Description
-------
Adds the stub which allows only authorized users to change the log
level of Mesos using the HTTP API v1.
Diffs
-----
src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
Diff: https://reviews.apache.org/r/54662/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 54662: Enabled authorization in SET_LOG_LEVEL API
call.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54662/#review159087
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/http.cpp (line 904)
<https://reviews.apache.org/r/54662/#comment230044>
No need to `defer(slave->self)` here since the lambda doesn't use anything from the agent (level, duration, approver are passed in directly), and the result is a `dispatch()`? Let me double-check with somebody here so I can commit this today.
src/slave/http.cpp (lines 905 - 906)
<https://reviews.apache.org/r/54662/#comment230042>
Looks like weird wrapping to me. I'd prefer to see it wrapped after `](` like other lambdas
- Adam B
On Dec. 12, 2016, 6:37 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54662/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 6:37 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds the stub which allows only authorized users to change the log
> level of Mesos using the HTTP API v1.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
>
> Diff: https://reviews.apache.org/r/54662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54662: Enabled authorization in SET_LOG_LEVEL API
call.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On Dec. 13, 2016, 10:44 a.m., Adam B wrote:
> > src/slave/http.cpp, line 898
> > <https://reviews.apache.org/r/54662/diff/1/?file=1581995#file1581995line898>
> >
> > Is the plan to move everything over to the ObjectApprover API? Why not use the simpler `slave->authorizer.get()->authorized(authRequest)` API for simpler authz checks? Because it's asynchronous?
That has, indeed, been the plan since the introduction of the object approver concept. Though my original plan was to do a sweep clean of all the places where the `Authorizer::authorized()` calls exist.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54662/#review158974
-----------------------------------------------------------
On Dec. 12, 2016, 3:37 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54662/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 3:37 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds the stub which allows only authorized users to change the log
> level of Mesos using the HTTP API v1.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
>
> Diff: https://reviews.apache.org/r/54662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54662: Enabled authorization in SET_LOG_LEVEL API
call.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54662/#review158974
-----------------------------------------------------------
Looks good. Just a question about ObjectApprover vs. authorized()
src/slave/http.cpp (line 898)
<https://reviews.apache.org/r/54662/#comment229873>
Is the plan to move everything over to the ObjectApprover API? Why not use the simpler `slave->authorizer.get()->authorized(authRequest)` API for simpler authz checks? Because it's asynchronous?
- Adam B
On Dec. 12, 2016, 6:37 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54662/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 6:37 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6670
> https://issues.apache.org/jira/browse/MESOS-6670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds the stub which allows only authorized users to change the log
> level of Mesos using the HTTP API v1.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b
>
> Diff: https://reviews.apache.org/r/54662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>