You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2026/07/07 05:17:14 UTC
[PR] Let area:kubernetes-tests label force the Kubernetes tests job [airflow]
jason810496 opened a new pull request, #69519:
URL: https://github.com/apache/airflow/pull/69519
## Why
Today the only label that can force the Kubernetes tests job is `full tests needed`, which also pulls in the entire test matrix. Respecting the existing `area:kubernetes-tests` label lets maintainers re-run just the Kubernetes tests when selective-checks' file-path heuristics don't catch a change's impact.
## What
- `run_kubernetes_tests` returns `true` when the `area:kubernetes-tests` label is set on the PR, independent of `full_tests_needed` (the `tests-kubernetes` job and prod image build already cascade from this output — no workflow changes needed).
- Document the label in the labels table of `04_selective_checks.md`.
- Add a test asserting the label forces `run_kubernetes_tests` without tripping `full_tests_needed`.
---
##### Was generative AI tooling used to co-author this PR?
- [x] Yes, with help of Claude Code (Fable 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let area:kubernetes-tests label force the Kubernetes tests job [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #69519:
URL: https://github.com/apache/airflow/pull/69519#discussion_r3534715057
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -3518,6 +3518,20 @@ def test_individual_providers_excludes_platform_excluded_on_arm():
assert "Providers[ibm.mq]" in amd_output
+def test_run_kubernetes_tests_forced_by_label():
+ """`area:kubernetes-tests` forces the Kubernetes tests job without pulling in
+ the full test matrix, unlike `full tests needed`."""
+ checks = SelectiveChecks(
+ files=("INTHEWILD.md",),
Review Comment:
Why do we need this here? should we keep it empty instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let area:kubernetes-tests label force the Kubernetes tests job [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 merged PR #69519:
URL: https://github.com/apache/airflow/pull/69519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let area:kubernetes-tests label force the Kubernetes tests job [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #69519:
URL: https://github.com/apache/airflow/pull/69519#discussion_r3534766611
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -3518,6 +3518,20 @@ def test_individual_providers_excludes_platform_excluded_on_arm():
assert "Providers[ibm.mq]" in amd_output
+def test_run_kubernetes_tests_forced_by_label():
+ """`area:kubernetes-tests` forces the Kubernetes tests job without pulling in
+ the full test matrix, unlike `full tests needed`."""
+ checks = SelectiveChecks(
+ files=("INTHEWILD.md",),
Review Comment:
What will happen if we make it `files=()`? Even though no file change doesn't really make sense, we can at least add some more description, though. Non-blocking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let area:kubernetes-tests label force the Kubernetes tests job [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #69519:
URL: https://github.com/apache/airflow/pull/69519#discussion_r3534740219
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -3518,6 +3518,20 @@ def test_individual_providers_excludes_platform_excluded_on_arm():
assert "Providers[ibm.mq]" in amd_output
+def test_run_kubernetes_tests_forced_by_label():
+ """`area:kubernetes-tests` forces the Kubernetes tests job without pulling in
+ the full test matrix, unlike `full tests needed`."""
+ checks = SelectiveChecks(
+ files=("INTHEWILD.md",),
Review Comment:
Do you mean the "files=(...)" part? This showcase that we should trigger k8s test if we set the label even the changed files are not related
(selective check use files to distinguish whether to trigger some test suite)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Let area:kubernetes-tests label force the Kubernetes tests job [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69519:
URL: https://github.com/apache/airflow/pull/69519#issuecomment-4912393492
### Backport successfully created: v3-3-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-3-test</td>
<td><a href="https://github.com/apache/airflow/pull/69593"><img src="https://img.shields.io/badge/PR-69593-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org