[GitHub] [shardingsphere] fwhdzh edited a comment on pull request #12159: Issue10968

[GitBox <gi...@apache.org>]

fwhdzh edited a comment on pull request #12159:
URL: https://github.com/apache/shardingsphere/pull/12159#issuecomment-914811496


   I have fixed these issues and check for all the pr to recorrect them.
   
   For now : 
   - If a variable is only used in one method, I use local variables instead of static variables.
   - If a variable of String type is only used once, I use the content of the String directly instead of a variable.
   - If a variable of Int or Long type is only used once, I still use a local variables in afraid of confusion of magic number.
   - If a variable is used in many method, I use it as static variable.
   
   I also merge those recent commits from master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org