You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/01 16:36:40 UTC
[jira] [Commented] (FLINK-3265) RabbitMQ Source not threadsafe:
ConcurrentModificationException
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126399#comment-15126399 ]
ASF GitHub Bot commented on FLINK-3265:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1569
[FLINK-3265][tests] adapt RabbitMQ checkpointing test to runtime behavior
This reverts the previous fix as this was merely a bug in the test. The methods `snapshotState` and `notifyCheckpointComplete` are always called mutually exclusive.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3265
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1569.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1569
----
commit 04d02c732e1113d6817f69474e7cee8849906d27
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-02-01T15:28:07Z
Revert "[FLINK-3265] [rabbitmq] Fix concurrency bug in RabbitMQ"
This reverts commit 6b01a89020f2de3f7710cf72336291b1e8ca8562.
commit ffe24944f4ad3f7f979caa2b085617843a4c7a87
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-02-01T15:30:52Z
[FLINK-3265][tests] adapt checkpointing test to runtime behavior
- snapshotState and notifyCheckpointComplete are always mutually exclusive
This closes #1560.
----
> RabbitMQ Source not threadsafe: ConcurrentModificationException
> ---------------------------------------------------------------
>
> Key: FLINK-3265
> URL: https://issues.apache.org/jira/browse/FLINK-3265
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Reporter: Robert Metzger
> Assignee: Maximilian Michels
> Priority: Blocker
> Labels: test-stability
> Fix For: 1.0.0
>
>
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest
> Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.454 sec <<< FAILURE! - in org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest
> testCheckpointing(org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest) Time elapsed: 0.902 sec <<< ERROR!
> java.util.ConcurrentModificationException: null
> at java.util.HashMap$HashIterator.remove(HashMap.java:1443)
> at java.util.AbstractSet.removeAll(AbstractSet.java:178)
> at org.apache.flink.streaming.api.functions.source.MessageAcknowledgingSourceBase.notifyCheckpointComplete(MessageAcknowledgingSourceBase.java:198)
> at org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest.testCheckpointing(RMQSourceTest.java:144)
> Results :
> Tests in error:
> RMQSourceTest.testCheckpointing:144 » ConcurrentModification
> {code}
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/103452897/log.txt
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)