You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/03/21 20:16:35 UTC
[GitHub] [camel-quarkus] ppalaga opened a new issue, #4685: Add back DataSonnet
ppalaga opened a new issue, #4685:
URL: https://github.com/apache/camel-quarkus/issues/4685
DataSonnet was originally missing in Camel 4, but made it back in the end, so we should try to re-add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on issue #4685: Add back DataSonnet
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on issue #4685:
URL: https://github.com/apache/camel-quarkus/issues/4685#issuecomment-1481440778
I am afraid, two profiles with different dependencies won't work well. You may find a way to release it like that, but then, projects depending on datasonnet would also always have to enable one of the two profiles to get the right transitives. The reason is that both of your jars will be mapped to the same pom.xml artifact, which is not javax/jakarta specific. Having two javax/jakarta modules with different artifactId would be much safer for your consumers and probably also much easier to release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] javaduke commented on issue #4685: Add back DataSonnet
Posted by "javaduke (via GitHub)" <gi...@apache.org>.
javaduke commented on issue #4685:
URL: https://github.com/apache/camel-quarkus/issues/4685#issuecomment-1481235380
On a side note, I'm having a hard time figuring out the release process for datasonnet so that I can support both `javax` and `jakarta4`. I have two profiles in my pom, one has javax dependencies, the other one has jakarta dependencies and adds `jakarta4` classifier. The problem is that I cannot figure out how to release them both at the same time and under the same version. Would be great if anyone more skilled in maven than I am could give me a hand, then I could cut a latest and greatest version to include in new Camel Quarkus release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on issue #4685: Add back DataSonnet
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on issue #4685:
URL: https://github.com/apache/camel-quarkus/issues/4685#issuecomment-1484322364
Hi @javaduke
If there is only `javax.` -> `jakarta.` changes, it could use `maven-shade-plugin` just like
```xml
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.2.2</version>
<executions>
<execution>
<id>jakarta</id>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<shadedClassifierName>jakarta</shadedClassifierName>
<shadedArtifactAttached>true</shadedArtifactAttached>
<createDependencyReducedPom>false</createDependencyReducedPom>
<artifactSet>
<includes>
<include>${project.groupId}:${project.artifactId}</include>
</includes>
</artifactSet>
<relocations>
<relocation>
<pattern>javax.servlet</pattern>
<shadedPattern>jakarta.servlet</shadedPattern>
</relocation>
</relocations>
</configuration>
</execution>
</executions>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on issue #4685: Add back DataSonnet
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on issue #4685:
URL: https://github.com/apache/camel-quarkus/issues/4685#issuecomment-1481179344
I have tests that fail natively.
The main reasons seem to come from this class whose dependency I can't find.
```
Warning: Could not resolve sjsonnet.Expr$Member$Field[] for reflection configuration. Reason: java.lang.ClassNotFoundException: sjsonnet.Expr$Member$Field.
Warning: Could not resolve sjsonnet.Expr[] for reflection configuration. Reason: java.lang.ClassNotFoundException: sjsonnet.Expr.
```
@javaduke Do you have any idea on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on issue #4685: Add back DataSonnet
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on issue #4685:
URL: https://github.com/apache/camel-quarkus/issues/4685#issuecomment-1481403077
> Yeah, there was some refactoring, the package name is now `com.datasonnet.jsonnet`, not `sjsonnet`.
>
> See here: https://github.com/datasonnet/datasonnet-mapper/blob/main/src/main/scala/com/datasonnet/jsonnet/Expr.scala
Thanks @javaduke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] javaduke commented on issue #4685: Add back DataSonnet
Posted by "javaduke (via GitHub)" <gi...@apache.org>.
javaduke commented on issue #4685:
URL: https://github.com/apache/camel-quarkus/issues/4685#issuecomment-1481211447
Yeah, there was some refactoring, the package name is now `com.datasonnet.jsonnet`, not `sjsonnet`.
See here: https://github.com/datasonnet/datasonnet-mapper/blob/main/src/main/scala/com/datasonnet/jsonnet/Expr.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed issue #4685: Add back DataSonnet
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton closed issue #4685: Add back DataSonnet
URL: https://github.com/apache/camel-quarkus/issues/4685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org