[arrow-datafusion] branch main updated: Remove dead code for casting dictionaries (#6286)

[al...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new a420ef8497 Remove dead code for casting dictionaries (#6286)
a420ef8497 is described below

commit a420ef8497a3e163fd07ec805d42015547c9e5fd
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Mon May 8 13:56:40 2023 -0400

    Remove dead code for casting dictionaries (#6286)
---
 datafusion/expr/src/type_coercion/binary.rs | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/datafusion/expr/src/type_coercion/binary.rs b/datafusion/expr/src/type_coercion/binary.rs
index 242d609cbd..fa912b777a 100644
--- a/datafusion/expr/src/type_coercion/binary.rs
+++ b/datafusion/expr/src/type_coercion/binary.rs
@@ -460,16 +460,6 @@ fn mathematics_numerical_coercion(
         return None;
     };
 
-    // same type => all good
-    // TODO: remove this
-    // bug: https://github.com/apache/arrow-datafusion/issues/3387
-    if lhs_type == rhs_type
-        && !(matches!(lhs_type, DataType::Dictionary(_, _))
-            || matches!(rhs_type, DataType::Dictionary(_, _)))
-    {
-        return Some(lhs_type.clone());
-    }
-
     // these are ordered from most informative to least informative so
     // that the coercion removes the least amount of information
     match (lhs_type, rhs_type) {