You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by et...@apache.org on 2025/02/19 06:31:28 UTC
(celeborn) branch main updated: [CELEBORN-1870] Fix typos in in 'Developer' documents
This is an automated email from the ASF dual-hosted git repository.
ethanfeng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new 2097fcdfe [CELEBORN-1870] Fix typos in in 'Developer' documents
2097fcdfe is described below
commit 2097fcdfea0e46f936271f000d72cc552f604c70
Author: KenGeng <sa...@gmail.com>
AuthorDate: Wed Feb 19 14:31:14 2025 +0800
[CELEBORN-1870] Fix typos in in 'Developer' documents
### What changes were proposed in this pull request?
Fix typo in 'Developer' documents.
### Why are the changes needed?
Improve the accurary of the doc.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Only doc changed. No test.
Closes #3108 from bgeng777/CELEBORN-1870.
Authored-by: KenGeng <sa...@gmail.com>
Signed-off-by: mingji <fe...@alibaba-inc.com>
---
docs/developers/integrate.md | 2 +-
docs/developers/shuffleclient.md | 2 +-
docs/developers/workerexclusion.md | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/developers/integrate.md b/docs/developers/integrate.md
index 65f14a20c..5da56e22b 100644
--- a/docs/developers/integrate.md
+++ b/docs/developers/integrate.md
@@ -71,7 +71,7 @@ create `ShuffleClient`.
```java
String host = lm.getHost();
-int = lm.getPort();
+int port = lm.getPort();
```
## Step Three: Create ShuffleClient
diff --git a/docs/developers/shuffleclient.md b/docs/developers/shuffleclient.md
index 02b75f5ff..1057da172 100644
--- a/docs/developers/shuffleclient.md
+++ b/docs/developers/shuffleclient.md
@@ -65,7 +65,7 @@ responds to `LifecycleManager` with the allocated `PartitionLocation`s.
In normal cases, the process of pushing data is as follows:
- `ShuffleClient` compresses data, currently supports `zstd` and `lz4`
-- `ShuffleClient` adds Header for the data: `mapId`, `attemptId`, `batchId` and `size`. The `bastchId` is a unique
+- `ShuffleClient` adds Header for the data: `mapId`, `attemptId`, `batchId` and `size`. The `batchId` is a unique
id for the data batch inside the (`mapId`, `attemptId`), for the purpose of de-duplication
- `ShuffleClient` sends `PushData` to the `Worker` on which the current `PartitionLocation` is allocated, and holds push
state for this pushing
diff --git a/docs/developers/workerexclusion.md b/docs/developers/workerexclusion.md
index fdd24b3f6..095526c30 100644
--- a/docs/developers/workerexclusion.md
+++ b/docs/developers/workerexclusion.md
@@ -67,7 +67,7 @@ Currently, exclusion in `ShuffleClient` is optional, users can configure using t
`celeborn.client.push/fetch.excludeWorkerOnFailure.enabled`
## LifecycleManager Side Exclusion
-The accuracy and delay in `LifecycleManager`'s exclusion list stands between `Master` and `Worker`. `LifecyleManager`
+The accuracy and delay in `LifecycleManager`'s exclusion list stands between `Master` and `ShuffleClient`. `LifecyleManager`
excludes a `Worker` in the following scenarios:
- Receives Revive request and the cause is critical