[GitHub] [doris] kpfly commented on a diff in pull request #10911: fix tuple is null

[GitBox <gi...@apache.org>]

kpfly commented on code in PR #10911:
URL: https://github.com/apache/doris/pull/10911#discussion_r922647547


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/TupleIsNullPredicate.java:
##########
@@ -198,10 +198,16 @@ public static Expr unwrapExpr(Expr expr) {
     public static void substitueListForTupleIsNull(List<Expr> exprs,
             Map<List<TupleId>, TupleId> originToTargetTidMap) {
         for (Expr expr : exprs) {
-            if (!(expr instanceof TupleIsNullPredicate)) {
+            if (!(expr instanceof FunctionCallExpr)) {
                 continue;
             }
-            TupleIsNullPredicate tupleIsNullPredicate = (TupleIsNullPredicate) expr;
+            if (expr.getChildren().size() != 3) {

Review Comment:
   3 is hard code，what's the meaning 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org