You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li xu <le...@gmail.com> on 2011/09/26 23:22:35 UTC
Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
-----------------------------------------------------------
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Summary
-------
The fix will set up API patch when common container is created in these sample pages.
var testConfig = testConfig || {};
testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
var CommonContainer = new osapi.container.Container(testConfig);
also includes other minor cleanup.
Diffs
-----
/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
/trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
Diff: https://reviews.apache.org/r/2052/diff
Testing
-------
passed maven build.
Thanks,
li
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2587
-----------------------------------------------------------
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5817>
remove whitespace
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5818>
+18 seems a little fragile. Why not define /conservcontainer/ as a var and then get the length of the string
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5819>
remove the white space
/trunk/content/samplecontainer/examples/conservcontainer/index.html
<https://reviews.apache.org/r/2052/#comment5820>
remove the white space and make sure it lines up
- Ryan
On 2011-10-12 20:54:19, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2052/
> -----------------------------------------------------------
>
> (Updated 2011-10-12 20:54:19)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> The fix will set up API patch when common container is created in these sample pages.
>
> var testConfig = testConfig || {};
> testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
> var CommonContainer = new osapi.container.Container(testConfig);
>
> also includes other minor cleanup.
>
>
> This addresses bug SHINDIG-1632.
> https://issues.apache.org/jira/browse/SHINDIG-1632
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1182418
>
> Diff: https://reviews.apache.org/r/2052/diff
>
>
> Testing
> -------
>
> passed maven build.
>
>
> Thanks,
>
> li
>
>
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2596
-----------------------------------------------------------
Ship it!
Committed revision 1183460.
- Ryan
On 2011-10-14 18:01:40, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2052/
> -----------------------------------------------------------
>
> (Updated 2011-10-14 18:01:40)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> The fix will set up API patch when common container is created in these sample pages.
>
> var testConfig = testConfig || {};
> testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
> var CommonContainer = new osapi.container.Container(testConfig);
>
> also includes other minor cleanup.
>
>
> This addresses bug SHINDIG-1632.
> https://issues.apache.org/jira/browse/SHINDIG-1632
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1182572
>
> Diff: https://reviews.apache.org/r/2052/diff
>
>
> Testing
> -------
>
> passed maven build.
>
>
> Thanks,
>
> li
>
>
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by li xu <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
-----------------------------------------------------------
(Updated 2011-10-14 18:01:40.220430)
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Changes
-------
Updated patch with comments.
Summary
-------
The fix will set up API patch when common container is created in these sample pages.
var testConfig = testConfig || {};
testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
var CommonContainer = new osapi.container.Container(testConfig);
also includes other minor cleanup.
This addresses bug SHINDIG-1632.
https://issues.apache.org/jira/browse/SHINDIG-1632
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/conservcontainer/index.html 1182572
Diff: https://reviews.apache.org/r/2052/diff
Testing
-------
passed maven build.
Thanks,
li
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by li xu <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
-----------------------------------------------------------
(Updated 2011-10-12 20:54:19.017987)
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Changes
-------
Part of the issue is resolved by Dan's fix -- issue 1627.
Update the patch to only include the minor ui fix for Action/Selection Sample page...
Prefill the gadget url text field with correct context.
Summary
-------
The fix will set up API patch when common container is created in these sample pages.
var testConfig = testConfig || {};
testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
var CommonContainer = new osapi.container.Container(testConfig);
also includes other minor cleanup.
This addresses bug SHINDIG-1632.
https://issues.apache.org/jira/browse/SHINDIG-1632
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/conservcontainer/index.html 1182418
Diff: https://reviews.apache.org/r/2052/diff
Testing
-------
passed maven build.
Thanks,
li
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by li xu <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/
-----------------------------------------------------------
(Updated 2011-09-28 14:42:55.071479)
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Changes
-------
Attach issue 1632 to this request.
Summary
-------
The fix will set up API patch when common container is created in these sample pages.
var testConfig = testConfig || {};
testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
var CommonContainer = new osapi.container.Container(testConfig);
also includes other minor cleanup.
This addresses bug SHINDIG-1632.
https://issues.apache.org/jira/browse/SHINDIG-1632
Diffs
-----
/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
/trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
Diff: https://reviews.apache.org/r/2052/diff
Testing
-------
passed maven build.
Thanks,
li
Re: Review Request: minor fix to allow EE and Action/Selection Sample
to run under any context root out of box
Posted by Li Xu <le...@gmail.com>.
Thanks, Henry. SHINDIG-1627 seems to be the right issue for the feature Dan
or I plan to work on when we find time.
Ryan,
I just would like to fix the issue before the other patch is available so we
can have some buffer to wait for the the other patch ( it may take some time
to do that ).
Also this patch includes other UI updates...
Sure I will attach this to an JIRA issue.
thanks,
li
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-09-27 13:05:14, Dan Dumont wrote:
> > There's another fix to this problem that addresses the issue expressed by Doug Davies in the dev list.
> > instead of forcing people to register an API_PATH for the common container, we should by default NOT register an api path if it is not explicitly provided.
> >
> > Let me know if you want to go after it, otherwise it's on my to do list.
>
> Ryan Baxter wrote:
> +1
>
> li xu wrote:
> Dan, that's good information. Would you please point me to the fix or the discussion thread of it? Sounds great if we don't need to force the API_PATH registration. I'd like to understand it better and possibly help out.
> However in the meantime I think we should handle these two patch seperately. Registering API_PATH with common container is still a legal way to handle different context root use case. This patch also includes other minor clean up and features such as prefill gadget field with correct context root.
> thanks,
> li
>
>
> Dan Dumont wrote:
> The thread in the dev list has the subject: Metadata
> The code that should probably change is in features/container/service.js where we use a default of '/rpc' as the api path.
> We then register it later on, overriding the correctly registered endpoint that gets injected in the container config.
>
> I'm thinking if the api path is not specified, we use the one that was injected as the container config. I'm wary of not registering at all. You could try that also to see if it works correctly.
>
> li xu wrote:
> Thanks, Dan. I will help take a look, can work offline with you on this. Seems to me it will be a nice feature to have.
>
> while we're working on a pending feature, could anyone please help review and close this defect? thanks.
>
Lee I don't think we should add the code that sets up the RPC path correctly if Dan's fix will handle that. While I agree what you are doing here is correct, I do not want to make the code overly complicated just as a temporary fix. I would rather us remove the code which deals with the RPC servlet path and leave the code for the prefilled gadget field and just commit that.
Also can you please attach a JIRA to the review?
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2086
-----------------------------------------------------------
On 2011-09-26 21:22:35, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2052/
> -----------------------------------------------------------
>
> (Updated 2011-09-26 21:22:35)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> The fix will set up API patch when common container is created in these sample pages.
>
> var testConfig = testConfig || {};
> testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
> var CommonContainer = new osapi.container.Container(testConfig);
>
> also includes other minor cleanup.
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
> /trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
>
> Diff: https://reviews.apache.org/r/2052/diff
>
>
> Testing
> -------
>
> passed maven build.
>
>
> Thanks,
>
> li
>
>
Re: Review Request: minor fix to allow EE and Action/Selection Sample
to run under any context root out of box
Posted by Henry Saputra <he...@gmail.com>.
We can use Jira SHINDIG-1627 to track this patch.
- Henry
On Tue, Sep 27, 2011 at 8:42 AM, li xu <le...@gmail.com> wrote:
>
>
>> On 2011-09-27 13:05:14, Dan Dumont wrote:
>> > There's another fix to this problem that addresses the issue expressed by Doug Davies in the dev list.
>> > instead of forcing people to register an API_PATH for the common container, we should by default NOT register an api path if it is not explicitly provided.
>> >
>> > Let me know if you want to go after it, otherwise it's on my to do list.
>>
>> Ryan Baxter wrote:
>> +1
>>
>> li xu wrote:
>> Dan, that's good information. Would you please point me to the fix or the discussion thread of it? Sounds great if we don't need to force the API_PATH registration. I'd like to understand it better and possibly help out.
>> However in the meantime I think we should handle these two patch seperately. Registering API_PATH with common container is still a legal way to handle different context root use case. This patch also includes other minor clean up and features such as prefill gadget field with correct context root.
>> thanks,
>> li
>>
>>
>> Dan Dumont wrote:
>> The thread in the dev list has the subject: Metadata
>> The code that should probably change is in features/container/service.js where we use a default of '/rpc' as the api path.
>> We then register it later on, overriding the correctly registered endpoint that gets injected in the container config.
>>
>> I'm thinking if the api path is not specified, we use the one that was injected as the container config. I'm wary of not registering at all. You could try that also to see if it works correctly.
>
> Thanks, Dan. I will help take a look, can work offline with you on this. Seems to me it will be a nice feature to have.
>
> while we're working on a pending feature, could anyone please help review and close this defect? thanks.
>
>
> - li
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2052/#review2086
> -----------------------------------------------------------
>
>
> On 2011-09-26 21:22:35, li xu wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/2052/
>> -----------------------------------------------------------
>>
>> (Updated 2011-09-26 21:22:35)
>>
>>
>> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>>
>>
>> Summary
>> -------
>>
>> The fix will set up API patch when common container is created in these sample pages.
>>
>> var testConfig = testConfig || {};
>> testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
>> var CommonContainer = new osapi.container.Container(testConfig);
>>
>> also includes other minor cleanup.
>>
>>
>> Diffs
>> -----
>>
>> /trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
>> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
>> /trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
>>
>> Diff: https://reviews.apache.org/r/2052/diff
>>
>>
>> Testing
>> -------
>>
>> passed maven build.
>>
>>
>> Thanks,
>>
>> li
>>
>>
>
>
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by li xu <le...@gmail.com>.
> On 2011-09-27 13:05:14, Dan Dumont wrote:
> > There's another fix to this problem that addresses the issue expressed by Doug Davies in the dev list.
> > instead of forcing people to register an API_PATH for the common container, we should by default NOT register an api path if it is not explicitly provided.
> >
> > Let me know if you want to go after it, otherwise it's on my to do list.
>
> Ryan Baxter wrote:
> +1
>
> li xu wrote:
> Dan, that's good information. Would you please point me to the fix or the discussion thread of it? Sounds great if we don't need to force the API_PATH registration. I'd like to understand it better and possibly help out.
> However in the meantime I think we should handle these two patch seperately. Registering API_PATH with common container is still a legal way to handle different context root use case. This patch also includes other minor clean up and features such as prefill gadget field with correct context root.
> thanks,
> li
>
>
> Dan Dumont wrote:
> The thread in the dev list has the subject: Metadata
> The code that should probably change is in features/container/service.js where we use a default of '/rpc' as the api path.
> We then register it later on, overriding the correctly registered endpoint that gets injected in the container config.
>
> I'm thinking if the api path is not specified, we use the one that was injected as the container config. I'm wary of not registering at all. You could try that also to see if it works correctly.
Thanks, Dan. I will help take a look, can work offline with you on this. Seems to me it will be a nice feature to have.
while we're working on a pending feature, could anyone please help review and close this defect? thanks.
- li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2086
-----------------------------------------------------------
On 2011-09-26 21:22:35, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2052/
> -----------------------------------------------------------
>
> (Updated 2011-09-26 21:22:35)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> The fix will set up API patch when common container is created in these sample pages.
>
> var testConfig = testConfig || {};
> testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
> var CommonContainer = new osapi.container.Container(testConfig);
>
> also includes other minor cleanup.
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
> /trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
>
> Diff: https://reviews.apache.org/r/2052/diff
>
>
> Testing
> -------
>
> passed maven build.
>
>
> Thanks,
>
> li
>
>
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-09-27 13:05:14, Dan Dumont wrote:
> > There's another fix to this problem that addresses the issue expressed by Doug Davies in the dev list.
> > instead of forcing people to register an API_PATH for the common container, we should by default NOT register an api path if it is not explicitly provided.
> >
> > Let me know if you want to go after it, otherwise it's on my to do list.
+1
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2086
-----------------------------------------------------------
On 2011-09-26 21:22:35, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2052/
> -----------------------------------------------------------
>
> (Updated 2011-09-26 21:22:35)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> The fix will set up API patch when common container is created in these sample pages.
>
> var testConfig = testConfig || {};
> testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
> var CommonContainer = new osapi.container.Container(testConfig);
>
> also includes other minor cleanup.
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
> /trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
>
> Diff: https://reviews.apache.org/r/2052/diff
>
>
> Testing
> -------
>
> passed maven build.
>
>
> Thanks,
>
> li
>
>
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by Dan Dumont <dd...@us.ibm.com>.
> On 2011-09-27 13:05:14, Dan Dumont wrote:
> > There's another fix to this problem that addresses the issue expressed by Doug Davies in the dev list.
> > instead of forcing people to register an API_PATH for the common container, we should by default NOT register an api path if it is not explicitly provided.
> >
> > Let me know if you want to go after it, otherwise it's on my to do list.
>
> Ryan Baxter wrote:
> +1
>
> li xu wrote:
> Dan, that's good information. Would you please point me to the fix or the discussion thread of it? Sounds great if we don't need to force the API_PATH registration. I'd like to understand it better and possibly help out.
> However in the meantime I think we should handle these two patch seperately. Registering API_PATH with common container is still a legal way to handle different context root use case. This patch also includes other minor clean up and features such as prefill gadget field with correct context root.
> thanks,
> li
>
The thread in the dev list has the subject: Metadata
The code that should probably change is in features/container/service.js where we use a default of '/rpc' as the api path.
We then register it later on, overriding the correctly registered endpoint that gets injected in the container config.
I'm thinking if the api path is not specified, we use the one that was injected as the container config. I'm wary of not registering at all. You could try that also to see if it works correctly.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2086
-----------------------------------------------------------
On 2011-09-26 21:22:35, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2052/
> -----------------------------------------------------------
>
> (Updated 2011-09-26 21:22:35)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> The fix will set up API patch when common container is created in these sample pages.
>
> var testConfig = testConfig || {};
> testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
> var CommonContainer = new osapi.container.Container(testConfig);
>
> also includes other minor cleanup.
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
> /trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
>
> Diff: https://reviews.apache.org/r/2052/diff
>
>
> Testing
> -------
>
> passed maven build.
>
>
> Thanks,
>
> li
>
>
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by li xu <le...@gmail.com>.
> On 2011-09-27 13:05:14, Dan Dumont wrote:
> > There's another fix to this problem that addresses the issue expressed by Doug Davies in the dev list.
> > instead of forcing people to register an API_PATH for the common container, we should by default NOT register an api path if it is not explicitly provided.
> >
> > Let me know if you want to go after it, otherwise it's on my to do list.
>
> Ryan Baxter wrote:
> +1
Dan, that's good information. Would you please point me to the fix or the discussion thread of it? Sounds great if we don't need to force the API_PATH registration. I'd like to understand it better and possibly help out.
However in the meantime I think we should handle these two patch seperately. Registering API_PATH with common container is still a legal way to handle different context root use case. This patch also includes other minor clean up and features such as prefill gadget field with correct context root.
thanks,
li
- li
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2086
-----------------------------------------------------------
On 2011-09-26 21:22:35, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2052/
> -----------------------------------------------------------
>
> (Updated 2011-09-26 21:22:35)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> The fix will set up API patch when common container is created in these sample pages.
>
> var testConfig = testConfig || {};
> testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
> var CommonContainer = new osapi.container.Container(testConfig);
>
> also includes other minor cleanup.
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
> /trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
>
> Diff: https://reviews.apache.org/r/2052/diff
>
>
> Testing
> -------
>
> passed maven build.
>
>
> Thanks,
>
> li
>
>
Re: Review Request: minor fix to allow EE and Action/Selection Sample to run
under any context root out of box
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2052/#review2086
-----------------------------------------------------------
There's another fix to this problem that addresses the issue expressed by Doug Davies in the dev list.
instead of forcing people to register an API_PATH for the common container, we should by default NOT register an api path if it is not explicitly provided.
Let me know if you want to go after it, otherwise it's on my to do list.
- Dan
On 2011-09-26 21:22:35, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2052/
> -----------------------------------------------------------
>
> (Updated 2011-09-26 21:22:35)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> The fix will set up API patch when common container is created in these sample pages.
>
> var testConfig = testConfig || {};
> testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc';
> var CommonContainer = new osapi.container.Container(testConfig);
>
> also includes other minor cleanup.
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1176015
> /trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015
> /trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 1176015
>
> Diff: https://reviews.apache.org/r/2052/diff
>
>
> Testing
> -------
>
> passed maven build.
>
>
> Thanks,
>
> li
>
>