You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "sadovnychyi (via GitHub)" <gi...@apache.org> on 2023/07/26 12:00:40 UTC

[GitHub] [beam] sadovnychyi commented on a diff in pull request #27646: Fix stateful processing using direct runner with type checks enabled

sadovnychyi commented on code in PR #27646:
URL: https://github.com/apache/beam/pull/27646#discussion_r1274853416


##########
sdks/python/apache_beam/transforms/util_test.py:
##########
@@ -1041,6 +1042,23 @@ def test_output_typehints(self):
               ShardedKeyType[typehints.Tuple[int, int]],  # type: ignore[misc]
               typehints.Iterable[str]])
 
+  def test_with_type_hints(self):
+    options = PipelineOptions()
+    options.view_as(TypeOptions).runtime_type_check = True
+    with TestPipeline(options=options) as pipeline:
+      collection = pipeline \

Review Comment:
   Love it, done.
   
   YAPF seems to be way behind `black` in this regard, I *think* I remember seeing somewhere you folks talking about migrating to black, was it a dead end? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org