You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2009/03/18 23:19:50 UTC
[jira] Created: (HTTPCLIENT-835)
AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected
against external changes
AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes
-----------------------------------------------------------------------------------------------
Key: HTTPCLIENT-835
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-835
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpClient
Reporter: Sebb
AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes.
Although the field is private, subclasses can obtain a reference to it and so may be able to change it.
Consider making the list read-only, or returning a copy instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-835) Thread safety and visibility
Improvements
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCLIENT-835:
-----------------------------------------
Fix Version/s: 4.0 Beta 3
> Thread safety and visibility Improvements
> -----------------------------------------
>
> Key: HTTPCLIENT-835
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-835
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Sebb
> Fix For: 4.0 Beta 3
>
>
> AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes.
> Although the field is private, subclasses can obtain a reference to it and so may be able to change it.
> Consider making the list read-only, or returning a copy instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-835) Thread safety and visibility
Improvements
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683216#action_12683216 ]
Sebb commented on HTTPCLIENT-835:
---------------------------------
org.apache.http.impl.client.RoutedRequest has two final protected fields.
However both of these are also accessible via public get() methods, so the fields could be made private.
The class does not currently have any subclasses.
> Thread safety and visibility Improvements
> -----------------------------------------
>
> Key: HTTPCLIENT-835
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-835
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Sebb
>
> AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes.
> Although the field is private, subclasses can obtain a reference to it and so may be able to change it.
> Consider making the list read-only, or returning a copy instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Resolved: (HTTPCLIENT-835) Thread safety and visibility
Improvements
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved HTTPCLIENT-835.
-----------------------------
Resolution: Fixed
No more issues raised, so resolving.
> Thread safety and visibility Improvements
> -----------------------------------------
>
> Key: HTTPCLIENT-835
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-835
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Sebb
> Fix For: 4.1.0
>
>
> AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes.
> Although the field is private, subclasses can obtain a reference to it and so may be able to change it.
> Consider making the list read-only, or returning a copy instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-835) Thread safety and visibility
Improvements
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCLIENT-835:
-----------------------------------------
Fix Version/s: (was: 4.0 Beta 3)
4.1.0
> Thread safety and visibility Improvements
> -----------------------------------------
>
> Key: HTTPCLIENT-835
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-835
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Sebb
> Fix For: 4.1.0
>
>
> AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes.
> Although the field is private, subclasses can obtain a reference to it and so may be able to change it.
> Consider making the list read-only, or returning a copy instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-835) Thread safety and visibility
Improvements
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated HTTPCLIENT-835:
----------------------------
Summary: Thread safety and visibility Improvements (was: AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes)
> Thread safety and visibility Improvements
> -----------------------------------------
>
> Key: HTTPCLIENT-835
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-835
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Sebb
>
> AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes.
> Although the field is private, subclasses can obtain a reference to it and so may be able to change it.
> Consider making the list read-only, or returning a copy instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-835) Thread safety and visibility
Improvements
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683248#action_12683248 ]
Sebb commented on HTTPCLIENT-835:
---------------------------------
Fixed RoutedRequest:
commit -m "HTTPCLIENT-835 : No point having protected final fields and public getters"
Sending D:/eclipseworkspaces/main/httpcomponents-client/httpclient/src/main/java/org/apache/http/impl/client/RoutedRequest.java
Transmitting file data ...
Committed revision 755793.
Leaving the issue open for now to allow other changes to be added.
> Thread safety and visibility Improvements
> -----------------------------------------
>
> Key: HTTPCLIENT-835
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-835
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Sebb
>
> AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes.
> Although the field is private, subclasses can obtain a reference to it and so may be able to change it.
> Consider making the list read-only, or returning a copy instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-835) Thread safety and visibility
Improvements
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683245#action_12683245 ]
Sebb commented on HTTPCLIENT-835:
---------------------------------
Made AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY a non-modifiable list
This allowed 3 classes to become immutable:
commit -m "Make AbstractAuthenticationHandler immutable by changing the List to unmodifiable"
Sending D:/eclipseworkspaces/main/httpcomponents-client/httpclient/src/main/java/org/apache/http/impl/client/AbstractAuthenticationHandler.java
Sending D:/eclipseworkspaces/main/httpcomponents-client/httpclient/src/main/java/org/apache/http/impl/client/DefaultProxyAuthenticationHandler.java
Sending D:/eclipseworkspaces/main/httpcomponents-client/httpclient/src/main/java/org/apache/http/impl/client/DefaultTargetAuthenticationHandler.java
Transmitting file data ...
Committed revision 755783.
> Thread safety and visibility Improvements
> -----------------------------------------
>
> Key: HTTPCLIENT-835
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-835
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Sebb
>
> AbstractAuthenticationHandler.DEFAULT_SCHEME_PRIORITY is not protected against external changes.
> Although the field is private, subclasses can obtain a reference to it and so may be able to change it.
> Consider making the list read-only, or returning a copy instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org