[GitHub] [cassandra] bereng commented on a change in pull request #966: CASSANDRA-16601 Flaky CassandraIndexTest

[GitBox <gi...@apache.org>]

bereng commented on a change in pull request #966:
URL: https://github.com/apache/cassandra/pull/966#discussion_r615545520



##########
File path: test/unit/org/apache/cassandra/index/internal/CassandraIndexTest.java
##########
@@ -561,6 +562,20 @@ public void indexCorrectlyMarkedAsBuildAndRemoved() throws Throwable
         String selectBuiltIndexesQuery = String.format("SELECT * FROM %s.\"%s\"",
                                                        SchemaConstants.SYSTEM_KEYSPACE_NAME,
                                                        SystemKeyspace.BUILT_INDEXES);
+
+        // Wait for any background index clearing tasks to complete

Review comment:
       I'm sort of -1. Junit test methods _by definition_ should be 100% isolated. Junit itself goes to great lenghts to make sure each test case is isolated as much as possible. CASSANDRA-16595 is actually solving _a bug_ where we broke junit rules. I can add for completeness but I'll reword it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org