You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/01 18:20:06 UTC
[GitHub] [kafka] philipnee opened a new pull request, #12810: MINOR: Remove outdated comment about metadata request
philipnee opened a new pull request, #12810:
URL: https://github.com/apache/kafka/pull/12810
This is an outdated comment about the metadata request from the old implementation. The name of the RPC was changed from GroupMetadata to FindCoordinator, but the comment was not updated.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] philipnee commented on a diff in pull request #12810: MINOR: Remove outdated comment about metadata request
Posted by GitBox <gi...@apache.org>.
philipnee commented on code in PR #12810:
URL: https://github.com/apache/kafka/pull/12810#discussion_r1010923689
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -864,7 +864,6 @@ public void handle(SyncGroupResponse syncResponse,
* @return A request future which indicates the completion of the metadata request
*/
private RequestFuture<Void> sendFindCoordinatorRequest(Node node) {
- // initiate the group metadata request
Review Comment:
Ah, thanks. The node selection is also done by the caller, so I updated that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #12810: MINOR: Remove outdated comment about metadata request
Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12810:
URL: https://github.com/apache/kafka/pull/12810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a diff in pull request #12810: MINOR: Remove outdated comment about metadata request
Posted by GitBox <gi...@apache.org>.
hachikuji commented on code in PR #12810:
URL: https://github.com/apache/kafka/pull/12810#discussion_r1010899428
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -864,7 +864,6 @@ public void handle(SyncGroupResponse syncResponse,
* @return A request future which indicates the completion of the metadata request
*/
private RequestFuture<Void> sendFindCoordinatorRequest(Node node) {
- // initiate the group metadata request
Review Comment:
The javadoc above also mention the GroupMetadata request. Can we update that as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org