You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by zs...@apache.org on 2010/02/09 08:55:50 UTC

svn commit: r907950 [7/15] - in /hadoop/hive/trunk: ./ checkstyle/ cli/src/java/org/apache/hadoop/hive/cli/ common/src/java/org/apache/hadoop/hive/common/ common/src/java/org/apache/hadoop/hive/conf/ contrib/src/java/org/apache/hadoop/hive/contrib/file...

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Tue Feb  9 07:55:30 2010
@@ -18,6 +18,11 @@
 
 package org.apache.hadoop.hive.ql.parse;
 
+import static org.apache.hadoop.hive.serde.Constants.LIST_COLUMNS;
+import static org.apache.hadoop.hive.serde.Constants.LIST_COLUMN_TYPES;
+import static org.apache.hadoop.hive.serde.Constants.SERIALIZATION_FORMAT;
+import static org.apache.hadoop.util.StringUtils.stringifyException;
+
 import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -96,12 +101,11 @@
 import org.apache.hadoop.hive.ql.optimizer.physical.PhysicalOptimizer;
 import org.apache.hadoop.hive.ql.optimizer.ppr.PartitionPruner;
 import org.apache.hadoop.hive.ql.optimizer.unionproc.UnionProcContext;
-import org.apache.hadoop.hive.ql.plan.DDLWork;
-import org.apache.hadoop.hive.ql.plan.PlanUtils;
 import org.apache.hadoop.hive.ql.plan.AggregationDesc;
 import org.apache.hadoop.hive.ql.plan.CreateTableDesc;
 import org.apache.hadoop.hive.ql.plan.CreateTableLikeDesc;
 import org.apache.hadoop.hive.ql.plan.CreateViewDesc;
+import org.apache.hadoop.hive.ql.plan.DDLWork;
 import org.apache.hadoop.hive.ql.plan.ExprNodeColumnDesc;
 import org.apache.hadoop.hive.ql.plan.ExprNodeConstantDesc;
 import org.apache.hadoop.hive.ql.plan.ExprNodeDesc;
@@ -113,6 +117,7 @@
 import org.apache.hadoop.hive.ql.plan.FilterDesc;
 import org.apache.hadoop.hive.ql.plan.ForwardDesc;
 import org.apache.hadoop.hive.ql.plan.GroupByDesc;
+import org.apache.hadoop.hive.ql.plan.JoinCondDesc;
 import org.apache.hadoop.hive.ql.plan.JoinDesc;
 import org.apache.hadoop.hive.ql.plan.LateralViewJoinDesc;
 import org.apache.hadoop.hive.ql.plan.LimitDesc;
@@ -121,6 +126,7 @@
 import org.apache.hadoop.hive.ql.plan.MapredWork;
 import org.apache.hadoop.hive.ql.plan.MoveWork;
 import org.apache.hadoop.hive.ql.plan.PartitionDesc;
+import org.apache.hadoop.hive.ql.plan.PlanUtils;
 import org.apache.hadoop.hive.ql.plan.ReduceSinkDesc;
 import org.apache.hadoop.hive.ql.plan.ScriptDesc;
 import org.apache.hadoop.hive.ql.plan.SelectDesc;
@@ -151,7 +157,7 @@
 import org.apache.hadoop.mapred.TextInputFormat;
 
 /**
- * Implementation of the semantic analyzer
+ * Implementation of the semantic analyzer.
  */
 
 public class SemanticAnalyzer extends BaseSemanticAnalyzer {
@@ -395,9 +401,9 @@
       qb.getParseInfo().setTabSample(
           alias,
           new TableSample(
-              unescapeIdentifier(sampleClause.getChild(0).getText()),
-              unescapeIdentifier(sampleClause.getChild(1).getText()),
-              sampleCols));
+          unescapeIdentifier(sampleClause.getChild(0).getText()),
+          unescapeIdentifier(sampleClause.getChild(1).getText()),
+          sampleCols));
       if (unparseTranslator.isEnabled()) {
         for (ASTNode sampleCol : sampleCols) {
           unparseTranslator.addIdentifierTranslation((ASTNode) sampleCol
@@ -498,7 +504,7 @@
   /**
    * Given the AST with TOK_LATERAL_VIEW as the root, get the alias for the
    * table or subquery in the lateral view and also make a mapping from the
-   * alias to all the lateral view AST's
+   * alias to all the lateral view AST's.
    * 
    * @param qb
    * @param lateralView
@@ -549,7 +555,7 @@
    * @param ctx_1
    * @throws SemanticException
    */
-  @SuppressWarnings( { "fallthrough", "nls" })
+  @SuppressWarnings({"fallthrough", "nls"})
   public void doPhase1(ASTNode ast, QB qb, Phase1Ctx ctx_1)
       throws SemanticException {
 
@@ -805,7 +811,7 @@
     } catch (HiveException e) {
       // Has to use full name to make sure it does not conflict with
       // org.apache.commons.lang.StringUtils
-      LOG.error(org.apache.hadoop.util.StringUtils.stringifyException(e));
+      LOG.error(stringifyException(e));
       throw new SemanticException(e.getMessage(), e);
     }
   }
@@ -817,7 +823,7 @@
     ASTNode viewTree;
     final ASTNodeOrigin viewOrigin = new ASTNodeOrigin("VIEW", tab.getName(),
         tab.getViewExpandedText(), alias, qb.getParseInfo().getSrcForAlias(
-            alias));
+        alias));
     try {
       String viewText = tab.getViewExpandedText();
       // Reparse text, passing null for context to avoid clobbering
@@ -841,7 +847,7 @@
       // an old SQL construct which has been eliminated in a later Hive
       // version, so we need to provide full debugging info to help
       // with fixing the view definition.
-      LOG.error(org.apache.hadoop.util.StringUtils.stringifyException(e));
+      LOG.error(stringifyException(e));
       StringBuilder sb = new StringBuilder();
       sb.append(e.getMessage());
       ErrorMsg.renderOrigin(sb, viewOrigin);
@@ -1082,7 +1088,7 @@
       for (int ci = childrenBegin; ci < joinCond.getChildCount(); ci++) {
         parseJoinCondPopulateAlias(joinTree, (ASTNode) joinCond.getChild(ci),
             leftAlias.get(ci - childrenBegin), rightAlias.get(ci
-                - childrenBegin), null);
+            - childrenBegin), null);
       }
 
       boolean leftAliasNull = true;
@@ -1150,7 +1156,7 @@
     RowResolver inputRR = inputCtx.getRR();
     Operator output = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new FilterDesc(genExprNodeDesc(condn, inputRR), false), new RowSchema(
-            inputRR.getColumnInfos()), input), inputRR);
+        inputRR.getColumnInfos()), input), inputRR);
 
     LOG.debug("Created Filter Plan for " + qb.getId() + " row schema: "
         + inputRR.toString());
@@ -1201,7 +1207,7 @@
       col_list.add(expr);
       output.put(tmp[0], tmp[1],
           new ColumnInfo(getColumnInternalName(pos), colInfo.getType(), colInfo
-              .getTabAlias(), colInfo.getIsPartitionCol()));
+          .getTabAlias(), colInfo.getIsPartitionCol()));
       pos = Integer.valueOf(pos.intValue() + 1);
       matched++;
 
@@ -1229,7 +1235,7 @@
   }
 
   /**
-   * If the user script command needs any modifications - do it here
+   * If the user script command needs any modifications - do it here.
    */
   private String getFixedCmd(String cmd) {
     SessionState ss = SessionState.get();
@@ -1406,7 +1412,7 @@
           String intName = getColumnInternalName(i);
           ColumnInfo colInfo = new ColumnInfo(intName, TypeInfoUtils
               .getTypeInfoFromTypeString(getTypeStringFromAST((ASTNode) child
-                  .getChild(1))), null, false);
+              .getChild(1))), null, false);
           colInfo.setAlias(colAlias);
           outputCols.add(colInfo);
         }
@@ -1489,9 +1495,9 @@
 
     Operator output = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new ScriptDesc(
-            getFixedCmd(stripQuotes(trfm.getChild(execPos).getText())), inInfo,
-            inRecordWriter, outInfo, outRecordReader), new RowSchema(out_rwsch
-            .getColumnInfos()), input), out_rwsch);
+        getFixedCmd(stripQuotes(trfm.getChild(execPos).getText())), inInfo,
+        inRecordWriter, outInfo, outRecordReader), new RowSchema(out_rwsch
+        .getColumnInfos()), input), out_rwsch);
 
     return output;
   }
@@ -1654,7 +1660,8 @@
       posn++;
     }
 
-    boolean isInTransform = (selExprList.getChild(posn).getChild(0).getType() == HiveParser.TOK_TRANSFORM);
+    boolean isInTransform = (selExprList.getChild(posn).getChild(0).getType() ==
+      HiveParser.TOK_TRANSFORM);
     if (isInTransform) {
       trfm = (ASTNode) selExprList.getChild(posn).getChild(0);
     }
@@ -1783,7 +1790,7 @@
       } else if (expr.getType() == HiveParser.DOT
           && expr.getChild(0).getType() == HiveParser.TOK_TABLE_OR_COL
           && inputRR.hasTableAlias(unescapeIdentifier(expr.getChild(0)
-              .getChild(0).getText().toLowerCase())) && !hasAsClause
+          .getChild(0).getText().toLowerCase())) && !hasAsClause
           && !inputRR.getIsExprResolver()
           && isRegex(unescapeIdentifier(expr.getChild(1).getText()))) {
         // In case the expression is TABLE.COL (col can be regex).
@@ -1791,7 +1798,7 @@
         // We don't allow this for ExprResolver - the Group By case
         pos = genColListRegex(unescapeIdentifier(expr.getChild(1).getText()),
             unescapeIdentifier(expr.getChild(0).getChild(0).getText()
-                .toLowerCase()), alias, expr, col_list, inputRR, pos, out_rwsch);
+            .toLowerCase()), alias, expr, col_list, inputRR, pos, out_rwsch);
       } else {
         // Case when this is an expression
         ExprNodeDesc exp = genExprNodeDesc(expr, inputRR);
@@ -1824,7 +1831,7 @@
 
     Operator output = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new SelectDesc(col_list, columnNames, selectStar), new RowSchema(
-            out_rwsch.getColumnInfos()), input), out_rwsch);
+        out_rwsch.getColumnInfos()), input), out_rwsch);
 
     output.setColumnExprMap(colExprMap);
     if (isInTransform) {
@@ -1915,7 +1922,8 @@
     // set r.returnType
     ObjectInspector returnOI = null;
     try {
-      ObjectInspector[] aggObjectInspectors = getStandardObjectInspector(getTypeInfo(aggParameters));
+      ObjectInspector[] aggObjectInspectors =
+          getStandardObjectInspector(getTypeInfo(aggParameters));
       returnOI = r.genericUDAFEvaluator.init(emode, aggObjectInspectors);
       r.returnType = TypeInfoUtils.getTypeInfoFromObjectInspector(returnOI);
     } catch (HiveException e) {
@@ -2046,7 +2054,7 @@
 
     Operator op = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new GroupByDesc(mode, outputColumnNames, groupByKeys, aggregations,
-            false), new RowSchema(groupByOutputRowResolver.getColumnInfos()),
+        false), new RowSchema(groupByOutputRowResolver.getColumnInfos()),
         reduceSinkOperatorInfo), groupByOutputRowResolver);
     op.setColumnExprMap(colExprMap);
     return op;
@@ -2114,7 +2122,8 @@
       // Otherwise, we look for b+c.
       // For distincts, partial aggregation is never performed on the client
       // side, so always look for the parameters: d+e
-      boolean partialAggDone = !(distPartAgg || (value.getToken().getType() == HiveParser.TOK_FUNCTIONDI));
+      boolean partialAggDone = !(distPartAgg
+          || (value.getToken().getType() == HiveParser.TOK_FUNCTIONDI));
       if (!partialAggDone) {
         // 0 is the function name
         for (int i = 1; i < value.getChildCount(); i++) {
@@ -2141,7 +2150,7 @@
         assert (paraExpression != null);
         aggParameters.add(new ExprNodeColumnDesc(paraExprInfo.getType(),
             paraExpression, paraExprInfo.getTabAlias(), paraExprInfo
-                .getIsPartitionCol()));
+            .getIsPartitionCol()));
       }
       boolean isDistinct = (value.getType() == HiveParser.TOK_FUNCTIONDI);
       Mode amode = groupByDescModeToUDAFMode(mode, isDistinct);
@@ -2171,8 +2180,8 @@
 
     Operator op = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new GroupByDesc(mode, outputColumnNames, groupByKeys, aggregations,
-            distPartAgg), new RowSchema(groupByOutputRowResolver
-            .getColumnInfos()), reduceSinkOperatorInfo),
+        distPartAgg), new RowSchema(groupByOutputRowResolver
+        .getColumnInfos()), reduceSinkOperatorInfo),
         groupByOutputRowResolver);
     op.setColumnExprMap(colExprMap);
     return op;
@@ -2285,7 +2294,7 @@
 
     Operator op = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new GroupByDesc(mode, outputColumnNames, groupByKeys, aggregations,
-            false), new RowSchema(groupByOutputRowResolver.getColumnInfos()),
+        false), new RowSchema(groupByOutputRowResolver.getColumnInfos()),
         inputOperatorInfo), groupByOutputRowResolver);
     op.setColumnExprMap(colExprMap);
     return op;
@@ -2406,9 +2415,9 @@
 
     ReduceSinkOperator rsOp = (ReduceSinkOperator) putOpInsertMap(
         OperatorFactory.getAndMakeChild(PlanUtils.getReduceSinkDesc(reduceKeys,
-            reduceValues, outputColumnNames, true, -1, numPartitionFields,
-            numReducers), new RowSchema(reduceSinkOutputRowResolver
-            .getColumnInfos()), inputOperatorInfo), reduceSinkOutputRowResolver);
+        reduceValues, outputColumnNames, true, -1, numPartitionFields,
+        numReducers), new RowSchema(reduceSinkOutputRowResolver
+        .getColumnInfos()), inputOperatorInfo), reduceSinkOutputRowResolver);
     rsOp.setColumnExprMap(colExprMap);
     return rsOp;
   }
@@ -2477,9 +2486,9 @@
 
     ReduceSinkOperator rsOp = (ReduceSinkOperator) putOpInsertMap(
         OperatorFactory.getAndMakeChild(PlanUtils.getReduceSinkDesc(reduceKeys,
-            reduceValues, outputColumnNames, true, -1, numPartitionFields,
-            numReducers), new RowSchema(reduceSinkOutputRowResolver2
-            .getColumnInfos()), groupByOperatorInfo),
+        reduceValues, outputColumnNames, true, -1, numPartitionFields,
+        numReducers), new RowSchema(reduceSinkOutputRowResolver2
+        .getColumnInfos()), groupByOperatorInfo),
         reduceSinkOutputRowResolver2);
 
     rsOp.setColumnExprMap(colExprMap);
@@ -2542,7 +2551,7 @@
       assert (paraExpression != null);
       aggParameters.add(new ExprNodeColumnDesc(paraExprInfo.getType(),
           paraExpression, paraExprInfo.getTabAlias(), paraExprInfo
-              .getIsPartitionCol()));
+          .getIsPartitionCol()));
 
       String aggName = value.getChild(0).getText();
 
@@ -2558,7 +2567,8 @@
               aggName.toLowerCase(),
               udaf.genericUDAFEvaluator,
               udaf.convertedParameters,
-              (mode != GroupByDesc.Mode.FINAL && value.getToken().getType() == HiveParser.TOK_FUNCTIONDI),
+              (mode != GroupByDesc.Mode.FINAL && value.getToken().getType() ==
+                HiveParser.TOK_FUNCTIONDI),
               amode));
       String field = getColumnInternalName(groupByKeys.size()
           + aggregations.size() - 1);
@@ -2569,7 +2579,7 @@
 
     Operator op = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new GroupByDesc(mode, outputColumnNames, groupByKeys, aggregations,
-            false), new RowSchema(groupByOutputRowResolver2.getColumnInfos()),
+        false), new RowSchema(groupByOutputRowResolver2.getColumnInfos()),
         reduceSinkOperatorInfo2), groupByOutputRowResolver2);
     op.setColumnExprMap(colExprMap);
     return op;
@@ -2582,7 +2592,7 @@
    * ReduceSink ( keys = (K1_EXP, K2_EXP, DISTINCT_EXP), values = (A1_EXP,
    * A2_EXP) ) SortGroupBy (keys = (KEY.0,KEY.1), aggregations =
    * (count_distinct(KEY.2), sum(VALUE.0), count(VALUE.1))) Select (final
-   * selects)
+   * selects).
    * 
    * @param dest
    * @param qb
@@ -2600,7 +2610,7 @@
    * 
    *           Reducer: iterate/merge (mode = COMPLETE)
    **/
-  @SuppressWarnings( { "unused", "nls" })
+  @SuppressWarnings({"unused", "nls"})
   private Operator genGroupByPlan1MR(String dest, QB qb, Operator input)
       throws SemanticException {
 
@@ -2665,7 +2675,8 @@
       Operator input) throws SemanticException {
 
     // ////// Generate GroupbyOperator for a map-side partial aggregation
-    Map<String, GenericUDAFEvaluator> genericUDAFEvaluators = new LinkedHashMap<String, GenericUDAFEvaluator>();
+    Map<String, GenericUDAFEvaluator> genericUDAFEvaluators =
+      new LinkedHashMap<String, GenericUDAFEvaluator>();
 
     QBParseInfo parseInfo = qb.getParseInfo();
 
@@ -2697,7 +2708,7 @@
    * (keys = (KEY.0,KEY.1), aggregations = (count_distinct(KEY.2), sum(VALUE.0),
    * count(VALUE.1))) ReduceSink ( keys = (0,1), values=(2,3,4)) SortGroupBy
    * (keys = (KEY.0,KEY.1), aggregations = (sum(VALUE.0), sum(VALUE.1),
-   * sum(VALUE.2))) Select (final selects)
+   * sum(VALUE.2))) Select (final selects).
    * 
    * @param dest
    * @param qb
@@ -2744,10 +2755,11 @@
     // captured by WritableComparableHiveObject.hashCode() function.
     Operator reduceSinkOperatorInfo = genGroupByPlanReduceSinkOperator(qb,
         dest, input, (parseInfo.getDistinctFuncExprForClause(dest) == null ? -1
-            : Integer.MAX_VALUE), -1, false);
+        : Integer.MAX_VALUE), -1, false);
 
     // ////// 2. Generate GroupbyOperator
-    Map<String, GenericUDAFEvaluator> genericUDAFEvaluators = new LinkedHashMap<String, GenericUDAFEvaluator>();
+    Map<String, GenericUDAFEvaluator> genericUDAFEvaluators =
+      new LinkedHashMap<String, GenericUDAFEvaluator>();
     GroupByOperator groupByOperatorInfo = (GroupByOperator) genGroupByPlanGroupByOperator(
         parseInfo, dest, reduceSinkOperatorInfo, GroupByDesc.Mode.PARTIAL1,
         genericUDAFEvaluators);
@@ -2808,7 +2820,8 @@
     QBParseInfo parseInfo = qb.getParseInfo();
 
     // ////// Generate GroupbyOperator for a map-side partial aggregation
-    Map<String, GenericUDAFEvaluator> genericUDAFEvaluators = new LinkedHashMap<String, GenericUDAFEvaluator>();
+    Map<String, GenericUDAFEvaluator> genericUDAFEvaluators =
+      new LinkedHashMap<String, GenericUDAFEvaluator>();
     GroupByOperator groupByOperatorInfo = (GroupByOperator) genGroupByPlanMapGroupByOperator(
         qb, dest, inputOperatorInfo, GroupByDesc.Mode.HASH,
         genericUDAFEvaluators);
@@ -2878,7 +2891,8 @@
     QBParseInfo parseInfo = qb.getParseInfo();
 
     // ////// Generate GroupbyOperator for a map-side partial aggregation
-    Map<String, GenericUDAFEvaluator> genericUDAFEvaluators = new LinkedHashMap<String, GenericUDAFEvaluator>();
+    Map<String, GenericUDAFEvaluator> genericUDAFEvaluators = 
+      new LinkedHashMap<String, GenericUDAFEvaluator>();
     GroupByOperator groupByOperatorInfo = (GroupByOperator) genGroupByPlanMapGroupByOperator(
         qb, dest, inputOperatorInfo, GroupByDesc.Mode.HASH,
         genericUDAFEvaluators);
@@ -2893,8 +2907,8 @@
       // ////// Generate ReduceSink Operator
       Operator reduceSinkOperatorInfo = genGroupByPlanReduceSinkOperator(qb,
           dest, groupByOperatorInfo, (parseInfo
-              .getDistinctFuncExprForClause(dest) == null ? -1
-              : Integer.MAX_VALUE), -1, true);
+          .getDistinctFuncExprForClause(dest) == null ? -1
+          : Integer.MAX_VALUE), -1, true);
 
       // ////// Generate GroupbyOperator for a partial aggregation
       Operator groupByOperatorInfo2 = genGroupByPlanGroupByOperator1(parseInfo,
@@ -2919,7 +2933,7 @@
       // ////// Generate ReduceSink Operator
       Operator reduceSinkOperatorInfo = genGroupByPlanReduceSinkOperator(qb,
           dest, groupByOperatorInfo, getGroupByForClause(parseInfo, dest)
-              .size(), 1, true);
+          .size(), 1, true);
 
       return genGroupByPlanGroupByOperator2MR(parseInfo, dest,
           reduceSinkOperatorInfo, GroupByDesc.Mode.FINAL, genericUDAFEvaluators);
@@ -3138,7 +3152,7 @@
       for (int i = 0; i < fields.size(); i++) {
         vecCol.add(new ColumnInfo(fields.get(i).getFieldName(), TypeInfoUtils
             .getTypeInfoFromObjectInspector(fields.get(i)
-                .getFieldObjectInspector()), "", false));
+            .getFieldObjectInspector()), "", false));
       }
     } catch (Exception e) {
       throw new SemanticException(e.getMessage());
@@ -3148,7 +3162,7 @@
 
     Operator output = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new FileSinkDesc(queryTmpdir, table_desc, conf
-            .getBoolVar(HiveConf.ConfVars.COMPRESSRESULT), currentTableId),
+        .getBoolVar(HiveConf.ConfVars.COMPRESSRESULT), currentTableId),
         fsRS, input), inputRR);
 
     LOG.debug("Created FileSink Plan for clause: " + dest + "dest_path: "
@@ -3209,8 +3223,8 @@
         // JSON-format.
         if (!tableFieldTypeInfo.equals(rowFieldTypeInfo)
             && !(isLazySimpleSerDe
-                && tableFieldTypeInfo.getCategory().equals(Category.PRIMITIVE) && tableFieldTypeInfo
-                .equals(TypeInfoFactory.stringTypeInfo))) {
+            && tableFieldTypeInfo.getCategory().equals(Category.PRIMITIVE) && tableFieldTypeInfo
+            .equals(TypeInfoFactory.stringTypeInfo))) {
           // need to do some conversions here
           converted = true;
           if (tableFieldTypeInfo.getCategory() != Category.PRIMITIVE) {
@@ -3243,7 +3257,7 @@
       }
       Operator output = putOpInsertMap(OperatorFactory.getAndMakeChild(
           new SelectDesc(expressions, colName), new RowSchema(rowResolver
-              .getColumnInfos()), input), rowResolver);
+          .getColumnInfos()), input), rowResolver);
 
       return output;
     } else {
@@ -3313,7 +3327,7 @@
       colNames.add(inputCols.get(i).getInternalName());
       colOIs[i] = TypeInfoUtils
           .getStandardWritableObjectInspectorFromTypeInfo(inputCols.get(i)
-              .getType());
+          .getType());
     }
     StructObjectInspector outputOI = genericUDTF.initialize(colOIs);
 
@@ -3324,7 +3338,7 @@
     if (numUdtfCols != numSuppliedAliases) {
       throw new SemanticException(ErrorMsg.UDTF_ALIAS_MISMATCH
           .getMsg("expected " + numUdtfCols + " aliases " + "but got "
-              + numSuppliedAliases));
+          + numSuppliedAliases));
     }
 
     // Generate the output column info's / row resolver using internal names.
@@ -3463,8 +3477,8 @@
     }
     Operator interim = putOpInsertMap(OperatorFactory.getAndMakeChild(PlanUtils
         .getReduceSinkDesc(sortCols, valueCols, outputColumns, false, -1,
-            partitionCols, order.toString(), numReducers), new RowSchema(
-        inputRR.getColumnInfos()), input), inputRR);
+        partitionCols, order.toString(), numReducers),
+        new RowSchema(inputRR.getColumnInfos()), input), inputRR);
     interim.setColumnExprMap(colExprMap);
 
     // Add the extract operator to get the value fields
@@ -3480,8 +3494,8 @@
 
     Operator output = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new ExtractDesc(new ExprNodeColumnDesc(TypeInfoFactory.stringTypeInfo,
-            Utilities.ReduceField.VALUE.toString(), "", false)), new RowSchema(
-            out_rwsch.getColumnInfos()), interim), out_rwsch);
+        Utilities.ReduceField.VALUE.toString(), "", false)), new RowSchema(
+        out_rwsch.getColumnInfos()), interim), out_rwsch);
 
     LOG.debug("Created ReduceSink Plan for clause: " + dest + " row schema: "
         + out_rwsch.toString());
@@ -3551,11 +3565,10 @@
       rightOps[pos] = input;
     }
 
-    org.apache.hadoop.hive.ql.plan.JoinCondDesc[] joinCondns = new org.apache.hadoop.hive.ql.plan.JoinCondDesc[join
-        .getJoinCond().length];
+    JoinCondDesc[] joinCondns = new JoinCondDesc[join.getJoinCond().length];
     for (int i = 0; i < join.getJoinCond().length; i++) {
       JoinCond condn = join.getJoinCond()[i];
-      joinCondns[i] = new org.apache.hadoop.hive.ql.plan.JoinCondDesc(condn);
+      joinCondns[i] = new JoinCondDesc(condn);
     }
 
     JoinDesc desc = new JoinDesc(exprMap, outputColumnNames, joinCondns);
@@ -3623,9 +3636,9 @@
 
     ReduceSinkOperator rsOp = (ReduceSinkOperator) putOpInsertMap(
         OperatorFactory.getAndMakeChild(PlanUtils.getReduceSinkDesc(reduceKeys,
-            reduceValues, outputColumns, false, joinTree.getNextTag(),
-            reduceKeys.size(), numReds), new RowSchema(outputRS
-            .getColumnInfos()), child), outputRS);
+        reduceValues, outputColumns, false, joinTree.getNextTag(),
+        reduceKeys.size(), numReds), new RowSchema(outputRS
+        .getColumnInfos()), child), outputRS);
     rsOp.setColumnExprMap(colExprMap);
     return rsOp;
   }
@@ -3647,7 +3660,7 @@
     Operator[] srcOps = new Operator[joinTree.getBaseSrc().length];
 
     HashSet<Integer> omitOpts = null; // set of input to the join that should be
-                                      // omitted by the output
+    // omitted by the output
     int pos = 0;
     for (String src : joinTree.getBaseSrc()) {
       if (src != null) {
@@ -3719,19 +3732,19 @@
     // create selection operator
     Operator output = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new SelectDesc(colList, columnNames, false), new RowSchema(inputRR
-            .getColumnInfos()), input), inputRR);
+        .getColumnInfos()), input), inputRR);
 
     output.setColumnExprMap(input.getColumnExprMap());
     return output;
   }
 
   private Operator genMapGroupByForSemijoin(QB qb, ArrayList<ASTNode> fields, // the
-                                                                              // ASTNode
-                                                                              // of
-                                                                              // the
-                                                                              // join
-                                                                              // key
-                                                                              // "tab.col"
+      // ASTNode
+      // of
+      // the
+      // join
+      // key
+      // "tab.col"
       Operator inputOperatorInfo, GroupByDesc.Mode mode)
       throws SemanticException {
 
@@ -3745,8 +3758,8 @@
     qb.getParseInfo();
 
     groupByOutputRowResolver.setIsExprResolver(true); // join keys should only
-                                                      // be columns but not be
-                                                      // expressions
+    // be columns but not be
+    // expressions
 
     for (int i = 0; i < fields.size(); ++i) {
       // get the group by keys to ColumnInfo
@@ -3769,7 +3782,7 @@
     // Generate group-by operator
     Operator op = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new GroupByDesc(mode, outputColumnNames, groupByKeys, aggregations,
-            false), new RowSchema(groupByOutputRowResolver.getColumnInfos()),
+        false), new RowSchema(groupByOutputRowResolver.getColumnInfos()),
         inputOperatorInfo), groupByOutputRowResolver);
 
     op.setColumnExprMap(colExprMap);
@@ -3802,7 +3815,7 @@
         if (commonType == null) {
           throw new SemanticException(
               "Cannot do equality join on different types: " + a.getTypeName()
-                  + " and " + b.getTypeName());
+              + " and " + b.getTypeName());
         }
       }
       // Add implicit type conversion if necessary
@@ -3811,7 +3824,7 @@
           keys.get(i).set(
               k,
               TypeCheckProcFactory.DefaultExprProcessor.getFuncExprNodeDesc(
-                  commonType.getTypeName(), keys.get(i).get(k)));
+              commonType.getTypeName(), keys.get(i).get(k)));
         }
       }
     }
@@ -3906,10 +3919,10 @@
         // leftAliases should contain the first table, rightAliases should
         // contain all other tables and baseSrc should contain all tables
 
-        String table_name = unescapeIdentifier(child.getChild(0).getText());
-        String alias = child.getChildCount() == 1 ? table_name
+        String tableName = unescapeIdentifier(child.getChild(0).getText());
+        String alias = child.getChildCount() == 1 ? tableName
             : unescapeIdentifier(child.getChild(child.getChildCount() - 1)
-                .getText().toLowerCase());
+            .getText().toLowerCase());
 
         if (i == 0) {
           leftAliases.add(alias);
@@ -4010,7 +4023,7 @@
       String table_name = unescapeIdentifier(left.getChild(0).getText());
       String alias = left.getChildCount() == 1 ? table_name
           : unescapeIdentifier(left.getChild(left.getChildCount() - 1)
-              .getText().toLowerCase());
+          .getText().toLowerCase());
       joinTree.setLeftAlias(alias);
       String[] leftAliases = new String[1];
       leftAliases[0] = alias;
@@ -4034,10 +4047,10 @@
 
     if ((right.getToken().getType() == HiveParser.TOK_TABREF)
         || (right.getToken().getType() == HiveParser.TOK_SUBQUERY)) {
-      String table_name = unescapeIdentifier(right.getChild(0).getText());
-      String alias = right.getChildCount() == 1 ? table_name
+      String tableName = unescapeIdentifier(right.getChild(0).getText());
+      String alias = right.getChildCount() == 1 ? tableName
           : unescapeIdentifier(right.getChild(right.getChildCount() - 1)
-              .getText().toLowerCase());
+          .getText().toLowerCase());
       String[] rightAliases = new String[1];
       rightAliases[0] = alias;
       joinTree.setRightAliases(rightAliases);
@@ -4309,7 +4322,7 @@
     }
     Operator output = putOpInsertMap(OperatorFactory.getAndMakeChild(
         new SelectDesc(colList, columnNames, true), new RowSchema(inputRR
-            .getColumnInfos()), input), inputRR);
+        .getColumnInfos()), input), inputRR);
     output.setColumnExprMap(input.getColumnExprMap());
     return output;
   }
@@ -4462,8 +4475,8 @@
 
     ReduceSinkOperator rsOp = (ReduceSinkOperator) putOpInsertMap(
         OperatorFactory.getAndMakeChild(PlanUtils.getReduceSinkDesc(reduceKeys,
-            reduceValues, outputColumnNames, true, -1, reduceKeys.size(), -1),
-            new RowSchema(reduceSinkOutputRowResolver.getColumnInfos()), input),
+        reduceValues, outputColumnNames, true, -1, reduceKeys.size(), -1),
+        new RowSchema(reduceSinkOutputRowResolver.getColumnInfos()), input),
         reduceSinkOutputRowResolver);
 
     rsOp.setColumnExprMap(colExprMap);
@@ -4626,24 +4639,24 @@
       if (rInfo == null) {
         throw new SemanticException(
             "Schema of both sides of union should match. " + rightalias
-                + " does not have the field " + field);
+            + " does not have the field " + field);
       }
       if (lInfo == null) {
         throw new SemanticException(
             "Schema of both sides of union should match. " + leftalias
-                + " does not have the field " + field);
+            + " does not have the field " + field);
       }
       if (!lInfo.getInternalName().equals(rInfo.getInternalName())) {
         throw new SemanticException(
             "Schema of both sides of union should match: " + field + ":"
-                + lInfo.getInternalName() + " " + rInfo.getInternalName());
+            + lInfo.getInternalName() + " " + rInfo.getInternalName());
       }
       if (!lInfo.getType().getTypeName().equals(rInfo.getType().getTypeName())) {
         throw new SemanticException(
             "Schema of both sides of union should match: Column " + field
-                + " is of type " + lInfo.getType().getTypeName()
-                + " on first table and type " + rInfo.getType().getTypeName()
-                + " on second table");
+            + " is of type " + lInfo.getType().getTypeName()
+            + " on first table and type " + rInfo.getType().getTypeName()
+            + " on second table");
       }
     }
 
@@ -4660,7 +4673,8 @@
     if ((leftOp instanceof UnionOperator) || (rightOp instanceof UnionOperator)) {
       if (leftOp instanceof UnionOperator) {
         // make left a child of right
-        List<Operator<? extends Serializable>> child = new ArrayList<Operator<? extends Serializable>>();
+        List<Operator<? extends Serializable>> child =
+          new ArrayList<Operator<? extends Serializable>>();
         child.add(leftOp);
         rightOp.setChildOperators(child);
 
@@ -4673,7 +4687,8 @@
         return putOpInsertMap(leftOp, unionoutRR);
       } else {
         // make right a child of left
-        List<Operator<? extends Serializable>> child = new ArrayList<Operator<? extends Serializable>>();
+        List<Operator<? extends Serializable>> child =
+          new ArrayList<Operator<? extends Serializable>>();
         child.add(rightOp);
         leftOp.setChildOperators(child);
 
@@ -4690,10 +4705,11 @@
     // Create a new union operator
     Operator<? extends Serializable> unionforward = OperatorFactory
         .getAndMakeChild(new UnionDesc(), new RowSchema(unionoutRR
-            .getColumnInfos()));
+        .getColumnInfos()));
 
     // set union operator as child of each of leftOp and rightOp
-    List<Operator<? extends Serializable>> child = new ArrayList<Operator<? extends Serializable>>();
+    List<Operator<? extends Serializable>> child =
+      new ArrayList<Operator<? extends Serializable>>();
     child.add(unionforward);
     rightOp.setChildOperators(child);
 
@@ -4701,7 +4717,8 @@
     child.add(unionforward);
     leftOp.setChildOperators(child);
 
-    List<Operator<? extends Serializable>> parent = new ArrayList<Operator<? extends Serializable>>();
+    List<Operator<? extends Serializable>> parent =
+      new ArrayList<Operator<? extends Serializable>>();
     parent.add(leftOp);
     parent.add(rightOp);
     unionforward.setParentOperators(parent);
@@ -4820,7 +4837,7 @@
           rwsch.put(alias, fields.get(i).getFieldName(), new ColumnInfo(fields
               .get(i).getFieldName(), TypeInfoUtils
               .getTypeInfoFromObjectInspector(fields.get(i)
-                  .getFieldObjectInspector()), alias, false));
+              .getFieldObjectInspector()), alias, false));
         }
       } catch (SerDeException e) {
         throw new RuntimeException(e);
@@ -4871,7 +4888,7 @@
       if (num > den) {
         throw new SemanticException(
             ErrorMsg.BUCKETED_NUMBERATOR_BIGGER_DENOMINATOR.getMsg() + " "
-                + tab.getName());
+            + tab.getName());
       }
 
       // check if a predicate is needed
@@ -4915,7 +4932,7 @@
             colsEqual, alias, rwsch, qb.getMetaData(), null);
         tableOp = OperatorFactory.getAndMakeChild(new FilterDesc(
             samplePredicate, true, new sampleDesc(ts.getNumerator(), ts
-                .getDenominator(), tabBucketCols, true)), top);
+            .getDenominator(), tabBucketCols, true)), top);
       } else {
         // need to add filter
         // create tableOp to be filterDesc and set as child to 'top'
@@ -4953,12 +4970,11 @@
                 .getBucketCols(), true, alias, rwsch, qb.getMetaData(), null);
             tableOp = OperatorFactory
                 .getAndMakeChild(new FilterDesc(samplePred, true,
-                    new sampleDesc(tsSample.getNumerator(), tsSample
-                        .getDenominator(), tab.getBucketCols(), true)), top);
+                new sampleDesc(tsSample.getNumerator(), tsSample
+                .getDenominator(), tab.getBucketCols(), true)), top);
             LOG.info("No need for sample filter");
-          }
-          // The table is not bucketed, add a dummy filter :: rand()
-          else {
+          } else {
+            // The table is not bucketed, add a dummy filter :: rand()
             int freq = conf.getIntVar(HiveConf.ConfVars.HIVETESTMODESAMPLEFREQ);
             TableSample tsSample = new TableSample(1, freq);
             tsSample.setInputPruning(false);
@@ -4966,7 +4982,7 @@
             LOG.info("Need sample filter");
             ExprNodeDesc randFunc = TypeCheckProcFactory.DefaultExprProcessor
                 .getFuncExprNodeDesc("rand", new ExprNodeConstantDesc(Integer
-                    .valueOf(460476415)));
+                .valueOf(460476415)));
             ExprNodeDesc samplePred = genSamplePredicate(tsSample, null, false,
                 alias, rwsch, qb.getMetaData(), randFunc);
             tableOp = OperatorFactory.getAndMakeChild(new FilterDesc(
@@ -5109,8 +5125,8 @@
 
           Operator lateralViewJoin = putOpInsertMap(OperatorFactory
               .getAndMakeChild(new LateralViewJoinDesc(outputInternalColNames),
-                  new RowSchema(lateralViewRR.getColumnInfos()), allPath,
-                  udtfPath), lateralViewRR);
+              new RowSchema(lateralViewRR.getColumnInfos()), allPath,
+              udtfPath), lateralViewRR);
           op = lateralViewJoin;
         }
         e.setValue(op);
@@ -5185,12 +5201,11 @@
             try {
               partsList = PartitionPruner.prune(topToTable.get(ts),
                   opToPartPruner.get(ts), conf, (String) topOps.keySet()
-                      .toArray()[0], prunedPartitions);
+                  .toArray()[0], prunedPartitions);
             } catch (HiveException e) {
               // Has to use full name to make sure it does not conflict with
               // org.apache.commons.lang.StringUtils
-              LOG.error(org.apache.hadoop.util.StringUtils
-                  .stringifyException(e));
+              LOG.error(stringifyException(e));
               throw new SemanticException(e.getMessage(), e);
             }
 
@@ -5222,7 +5237,7 @@
       }
 
       if (noMapRed) {
-        fetchTask = (FetchTask)TaskFactory.get(fetch, conf);
+        fetchTask = (FetchTask) TaskFactory.get(fetch, conf);
         setFetchTask(fetchTask);
 
         // remove root tasks if any
@@ -5239,17 +5254,15 @@
       String cols = loadFileWork.get(0).getColumns();
       String colTypes = loadFileWork.get(0).getColumnTypes();
 
-      fetch = new FetchWork(new Path(loadFileWork.get(0).getSourceDir())
-          .toString(), new TableDesc(LazySimpleSerDe.class,
+      fetch = new FetchWork(new Path(loadFileWork.get(0).getSourceDir()).toString(),
+          new TableDesc(LazySimpleSerDe.class,
           TextInputFormat.class, IgnoreKeyTextOutputFormat.class, Utilities
-              .makeProperties(
-                  org.apache.hadoop.hive.serde.Constants.SERIALIZATION_FORMAT,
-                  "" + Utilities.ctrlaCode,
-                  org.apache.hadoop.hive.serde.Constants.LIST_COLUMNS, cols,
-                  org.apache.hadoop.hive.serde.Constants.LIST_COLUMN_TYPES,
-                  colTypes)), qb.getParseInfo().getOuterQueryLimit());
+          .makeProperties(SERIALIZATION_FORMAT, "" + Utilities.ctrlaCode,
+          LIST_COLUMNS, cols,
+          LIST_COLUMN_TYPES, colTypes)),
+          qb.getParseInfo().getOuterQueryLimit());
 
-      fetchTask = (FetchTask)TaskFactory.get(fetch, conf);
+      fetchTask = (FetchTask) TaskFactory.get(fetch, conf);
       setFetchTask(fetchTask);
     } else {
       new ArrayList<MoveWork>();
@@ -5262,7 +5275,7 @@
       for (LoadFileDesc lfd : loadFileWork) {
         if (qb.isCTAS()) {
           assert (oneLoadFile); // should not have more than 1 load file for
-                                // CTAS
+          // CTAS
           // make the movetask's destination directory the table's destination.
           String location = qb.getTableDesc().getLocation();
           if (location == null) {
@@ -5574,7 +5587,7 @@
     // up with later.
     Operator sinkOp = genPlan(qb);
     resultSchema =
-      convertRowSchemaToViewSchema(opParseCtx.get(sinkOp).getRR());
+        convertRowSchemaToViewSchema(opParseCtx.get(sinkOp).getRR());
 
     if (createVwDesc != null) {
       saveViewDefinition();
@@ -5619,7 +5632,7 @@
     // Make a copy of the statement's result schema, since we may
     // modify it below as part of imposing view column names.
     List<FieldSchema> derivedSchema =
-      new ArrayList<FieldSchema>(resultSchema);
+        new ArrayList<FieldSchema>(resultSchema);
     validateColumnNameUniqueness(derivedSchema);
 
     List<FieldSchema> imposedSchema = createVwDesc.getSchema();
@@ -5736,10 +5749,10 @@
         TypeCheckProcFactory.getNumExprProcessor());
     opRules
         .put(new RuleRegExp("R3", HiveParser.Identifier + "%|"
-            + HiveParser.StringLiteral + "%|" + HiveParser.TOK_CHARSETLITERAL
-            + "%|" + HiveParser.KW_IF + "%|" + HiveParser.KW_CASE + "%|"
-            + HiveParser.KW_WHEN + "%"), TypeCheckProcFactory
-            .getStrExprProcessor());
+        + HiveParser.StringLiteral + "%|" + HiveParser.TOK_CHARSETLITERAL
+        + "%|" + HiveParser.KW_IF + "%|" + HiveParser.KW_CASE + "%|"
+        + HiveParser.KW_WHEN + "%"), TypeCheckProcFactory
+        .getStrExprProcessor());
     opRules.put(new RuleRegExp("R4", HiveParser.KW_TRUE + "%|"
         + HiveParser.KW_FALSE + "%"), TypeCheckProcFactory
         .getBoolExprProcessor());
@@ -6058,7 +6071,7 @@
         outputFormat = TEXTFILE_OUTPUT;
       }
     }
-    
+
     // check for existence of table
     if (ifNotExists) {
       try {

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java Tue Feb  9 07:55:30 2010
@@ -23,7 +23,11 @@
 import org.apache.hadoop.hive.conf.HiveConf;
 import org.apache.hadoop.hive.ql.session.SessionState;
 
-public class SemanticAnalyzerFactory {
+/**
+ * SemanticAnalyzerFactory.
+ *
+ */
+public final class SemanticAnalyzerFactory {
 
   static HashMap<Integer, String> commandType = new HashMap<Integer, String>();
 
@@ -36,20 +40,14 @@
     commandType.put(HiveParser.TOK_DESCFUNCTION, "DESCFUNCTION");
     commandType.put(HiveParser.TOK_MSCK, "MSCK");
     commandType.put(HiveParser.TOK_ALTERTABLE_ADDCOLS, "ALTERTABLE_ADDCOLS");
-    commandType.put(HiveParser.TOK_ALTERTABLE_REPLACECOLS,
-        "ALTERTABLE_REPLACECOLS");
-    commandType
-        .put(HiveParser.TOK_ALTERTABLE_RENAMECOL, "ALTERTABLE_RENAMECOL");
+    commandType.put(HiveParser.TOK_ALTERTABLE_REPLACECOLS, "ALTERTABLE_REPLACECOLS");
+    commandType.put(HiveParser.TOK_ALTERTABLE_RENAMECOL, "ALTERTABLE_RENAMECOL");
     commandType.put(HiveParser.TOK_ALTERTABLE_RENAME, "ALTERTABLE_RENAME");
-    commandType
-        .put(HiveParser.TOK_ALTERTABLE_DROPPARTS, "ALTERTABLE_DROPPARTS");
+    commandType.put(HiveParser.TOK_ALTERTABLE_DROPPARTS, "ALTERTABLE_DROPPARTS");
     commandType.put(HiveParser.TOK_ALTERTABLE_ADDPARTS, "ALTERTABLE_ADDPARTS");
-    commandType.put(HiveParser.TOK_ALTERTABLE_PROPERTIES,
-        "ALTERTABLE_PROPERTIES");
-    commandType.put(HiveParser.TOK_ALTERTABLE_SERIALIZER,
-        "ALTERTABLE_SERIALIZER");
-    commandType.put(HiveParser.TOK_ALTERTABLE_SERDEPROPERTIES,
-        "ALTERTABLE_SERDEPROPERTIES");
+    commandType.put(HiveParser.TOK_ALTERTABLE_PROPERTIES, "ALTERTABLE_PROPERTIES");
+    commandType.put(HiveParser.TOK_ALTERTABLE_SERIALIZER, "ALTERTABLE_SERIALIZER");
+    commandType.put(HiveParser.TOK_ALTERTABLE_SERDEPROPERTIES, "ALTERTABLE_SERDEPROPERTIES");
     commandType.put(HiveParser.TOK_SHOWTABLES, "SHOWTABLES");
     commandType.put(HiveParser.TOK_SHOW_TABLESTATUS, "SHOW_TABLESTATUS");
     commandType.put(HiveParser.TOK_SHOWFUNCTIONS, "SHOWFUNCTIONS");
@@ -105,4 +103,8 @@
       }
     }
   }
+
+  private SemanticAnalyzerFactory() {
+    // prevent instantiation
+  }
 }

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticException.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticException.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticException.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticException.java Tue Feb  9 07:55:30 2010
@@ -21,7 +21,7 @@
 import org.apache.hadoop.hive.ql.metadata.HiveException;
 
 /**
- * Exception from SemanticAnalyzer
+ * Exception from SemanticAnalyzer.
  */
 
 public class SemanticException extends HiveException {

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TableSample.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TableSample.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TableSample.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TableSample.java Tue Feb  9 07:55:30 2010
@@ -32,12 +32,12 @@
 public class TableSample {
 
   /**
-   * The numerator of the TABLESAMPLE clause
+   * The numerator of the TABLESAMPLE clause.
    */
   private int numerator;
 
   /**
-   * The denominator of the TABLESAMPLE clause
+   * The denominator of the TABLESAMPLE clause.
    */
   private int denominator;
 
@@ -52,13 +52,13 @@
   private ArrayList<ASTNode> exprs;
 
   /**
-   * Flag to indicate that input files can be pruned
+   * Flag to indicate that input files can be pruned.
    */
   private boolean inputPruning;
 
   /**
    * Constructs the TableSample given the numerator, denominator and the list of
-   * ON clause expressions
+   * ON clause expressions.
    * 
    * @param num
    *          The numerator
@@ -80,7 +80,7 @@
   }
 
   /**
-   * Gets the numerator
+   * Gets the numerator.
    * 
    * @return int
    */
@@ -89,7 +89,7 @@
   }
 
   /**
-   * Sets the numerator
+   * Sets the numerator.
    * 
    * @param num
    *          The numerator
@@ -99,7 +99,7 @@
   }
 
   /**
-   * Gets the denominator
+   * Gets the denominator.
    * 
    * @return int
    */
@@ -108,7 +108,7 @@
   }
 
   /**
-   * Sets the denominator
+   * Sets the denominator.
    * 
    * @param den
    *          The denominator
@@ -118,7 +118,7 @@
   }
 
   /**
-   * Gets the ON part's expression list
+   * Gets the ON part's expression list.
    * 
    * @return ArrayList<ASTNode>
    */
@@ -127,7 +127,7 @@
   }
 
   /**
-   * Sets the expression list
+   * Sets the expression list.
    * 
    * @param exprs
    *          The expression list
@@ -137,7 +137,7 @@
   }
 
   /**
-   * Gets the flag that indicates whether input pruning is possible
+   * Gets the flag that indicates whether input pruning is possible.
    * 
    * @return boolean
    */
@@ -146,7 +146,7 @@
   }
 
   /**
-   * Sets the flag that indicates whether input pruning is possible or not
+   * Sets the flag that indicates whether input pruning is possible or not.
    * 
    * @param inputPruning
    *          true if input pruning is possible

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java Tue Feb  9 07:55:30 2010
@@ -59,11 +59,15 @@
  * expression Node Descriptor trees. They also introduce the correct conversion
  * functions to do proper implicit conversion.
  */
-public class TypeCheckProcFactory {
+public final class TypeCheckProcFactory {
 
   protected static final Log LOG = LogFactory.getLog(TypeCheckProcFactory.class
       .getName());
 
+  private TypeCheckProcFactory() {
+    // prevent instantiation
+  }
+
   /**
    * Function to do groupby subexpression elimination. This is called by all the
    * processors initially. As an example, consider the query select a+b,
@@ -286,7 +290,7 @@
   }
 
   /**
-   * Processor for table columns
+   * Processor for table columns.
    */
   public static class ColumnExprProcessor implements NodeProcessor {
 
@@ -450,7 +454,7 @@
     }
 
     /**
-     * Get the exprNodeDesc
+     * Get the exprNodeDesc.
      * 
      * @param name
      * @param children
@@ -545,7 +549,7 @@
           // Only allow constant integer index for now
           if (!(children.get(1) instanceof ExprNodeConstantDesc)
               || !(((ExprNodeConstantDesc) children.get(1)).getTypeInfo()
-                  .equals(TypeInfoFactory.intTypeInfo))) {
+              .equals(TypeInfoFactory.intTypeInfo))) {
             throw new SemanticException(ErrorMsg.INVALID_ARRAYINDEX_CONSTANT
                 .getMsg(expr));
           }

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java Tue Feb  9 07:55:30 2010
@@ -118,7 +118,7 @@
   public boolean getIfNotExists() {
     return this.ifNotExists;
   }
-  
+
   /**
    * @param ifNotExists 
    *          if the part should be added only if it doesn't exist

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AggregationDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AggregationDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AggregationDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AggregationDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFEvaluator;
 
+/**
+ * AggregationDesc.
+ *
+ */
 public class AggregationDesc implements java.io.Serializable {
   private static final long serialVersionUID = 1L;
   private String genericUDAFName;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java Tue Feb  9 07:55:30 2010
@@ -22,21 +22,29 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 
 import org.apache.hadoop.hive.metastore.api.FieldSchema;
 import org.apache.hadoop.hive.metastore.api.Order;
 import org.apache.hadoop.hive.ql.exec.Utilities;
 
+/**
+ * AlterTableDesc.
+ *
+ */
 @Explain(displayName = "Alter Table")
 public class AlterTableDesc extends DDLDesc implements Serializable {
   private static final long serialVersionUID = 1L;
 
-  public static enum alterTableTypes {
-    RENAME, ADDCOLS, REPLACECOLS, ADDPROPS, ADDSERDE, ADDSERDEPROPS, ADDFILEFORMAT, ADDCLUSTERSORTCOLUMN, RENAMECOLUMN
+  /**
+   * alterTableTypes.
+   *
+   */
+  public static enum AlterTableTypes {
+    RENAME, ADDCOLS, REPLACECOLS, ADDPROPS, ADDSERDE, ADDSERDEPROPS,
+    ADDFILEFORMAT, ADDCLUSTERSORTCOLUMN, RENAMECOLUMN
   };
 
-  alterTableTypes op;
+  AlterTableTypes op;
   String oldName;
   String newName;
   ArrayList<FieldSchema> newCols;
@@ -57,7 +65,7 @@
 
   public AlterTableDesc() {
   }
-  
+
   /**
    * @param tblName
    *          table name
@@ -78,7 +86,7 @@
     newColComment = newComment;
     this.first = first;
     this.afterCol = afterCol;
-    op = alterTableTypes.RENAMECOLUMN;
+    op = AlterTableTypes.RENAMECOLUMN;
   }
 
   /**
@@ -88,7 +96,7 @@
    *          new name of the table
    */
   public AlterTableDesc(String oldName, String newName) {
-    op = alterTableTypes.RENAME;
+    op = AlterTableTypes.RENAME;
     this.oldName = oldName;
     this.newName = newName;
   }
@@ -100,7 +108,7 @@
    *          new columns to be added
    */
   public AlterTableDesc(String name, List<FieldSchema> newCols,
-      alterTableTypes alterType) {
+      AlterTableTypes alterType) {
     op = alterType;
     oldName = name;
     this.newCols = new ArrayList<FieldSchema>(newCols);
@@ -110,7 +118,7 @@
    * @param alterType
    *          type of alter op
    */
-  public AlterTableDesc(alterTableTypes alterType) {
+  public AlterTableDesc(AlterTableTypes alterType) {
     op = alterType;
   }
 
@@ -126,7 +134,7 @@
   public AlterTableDesc(String name, String inputFormat, String outputFormat,
       String serdeName) {
     super();
-    op = alterTableTypes.ADDFILEFORMAT;
+    op = AlterTableTypes.ADDFILEFORMAT;
     oldName = name;
     this.inputFormat = inputFormat;
     this.outputFormat = outputFormat;
@@ -136,7 +144,7 @@
   public AlterTableDesc(String tableName, int numBuckets,
       List<String> bucketCols, List<Order> sortCols) {
     oldName = tableName;
-    op = alterTableTypes.ADDCLUSTERSORTCOLUMN;
+    op = AlterTableTypes.ADDCLUSTERSORTCOLUMN;
     numberBuckets = numBuckets;
     bucketColumns = new ArrayList<String>(bucketCols);
     sortColumns = new ArrayList<Order>(sortCols);
@@ -146,7 +154,7 @@
   public List<String> getNewColsString() {
     return Utilities.getFieldSchemaString(getNewCols());
   }
-  
+
   @Explain(displayName = "type")
   public String getAlterTableTypeString() {
     switch (op) {
@@ -160,7 +168,7 @@
 
     return "unknown";
   }
-  
+
   /**
    * @return the old name of the table
    */
@@ -196,16 +204,15 @@
   /**
    * @return the op
    */
-  public alterTableTypes getOp() {
+  public AlterTableTypes getOp() {
     return op;
   }
 
-
   /**
    * @param op
    *          the op to set
    */
-  public void setOp(alterTableTypes op) {
+  public void setOp(AlterTableTypes op) {
     this.op = op;
   }
 

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CollectDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * CollectDesc.
+ *
+ */
 @Explain(displayName = "Collect")
 public class CollectDesc implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolver.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolver.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolver.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolver.java Tue Feb  9 07:55:30 2010
@@ -26,11 +26,11 @@
 
 /**
  * Conditional task resolution interface. This is invoked at run time to get the
- * task to invoke. Developers can plug in their own resolvers
+ * task to invoke. Developers can plug in their own resolvers.
  */
 public interface ConditionalResolver {
   /**
-   * All conditional resolvers implement this interface
+   * All conditional resolvers implement this interface.
    * 
    * @param conf
    *          configuration
@@ -38,5 +38,5 @@
    *          opaque context
    * @return position of the task
    */
-  public List<Task<? extends Serializable>> getTasks(HiveConf conf, Object ctx);
+  List<Task<? extends Serializable>> getTasks(HiveConf conf, Object ctx);
 }

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java Tue Feb  9 07:55:30 2010
@@ -40,6 +40,10 @@
   public ConditionalResolverMergeFiles() {
   }
 
+  /**
+   * ConditionalResolverMergeFilesCtx.
+   *
+   */
   public static class ConditionalResolverMergeFilesCtx implements Serializable {
     private static final long serialVersionUID = 1L;
     List<Task<? extends Serializable>> listTasks;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverSkewJoin.java Tue Feb  9 07:55:30 2010
@@ -31,10 +31,17 @@
 import org.apache.hadoop.hive.conf.HiveConf;
 import org.apache.hadoop.hive.ql.exec.Task;
 
-public class ConditionalResolverSkewJoin implements ConditionalResolver,
-    Serializable {
+/**
+ * ConditionalResolverSkewJoin.
+ *
+ */
+public class ConditionalResolverSkewJoin implements ConditionalResolver, Serializable {
   private static final long serialVersionUID = 1L;
 
+  /**
+   * ConditionalResolverSkewJoinCtx.
+   *
+   */
   public static class ConditionalResolverSkewJoinCtx implements Serializable {
     private static final long serialVersionUID = 1L;
     // we store big keys in one table into one dir, and same keys in other

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalWork.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalWork.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalWork.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalWork.java Tue Feb  9 07:55:30 2010
@@ -21,6 +21,10 @@
 import java.io.Serializable;
 import java.util.List;
 
+/**
+ * ConditionalWork.
+ *
+ */
 @Explain(displayName = "Conditional Operator")
 public class ConditionalWork implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * CopyWork.
+ *
+ */
 @Explain(displayName = "Copy")
 public class CopyWork implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * CreateFunctionDesc.
+ *
+ */
 @Explain(displayName = "Create Function")
 public class CreateFunctionDesc implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java Tue Feb  9 07:55:30 2010
@@ -28,6 +28,10 @@
 import org.apache.hadoop.hive.metastore.api.Order;
 import org.apache.hadoop.hive.ql.exec.Utilities;
 
+/**
+ * CreateTableDesc.
+ *
+ */
 @Explain(displayName = "Create Table")
 public class CreateTableDesc extends DDLDesc implements Serializable {
   private static final long serialVersionUID = 1L;
@@ -53,7 +57,7 @@
 
   public CreateTableDesc() {
   }
-  
+
   public CreateTableDesc(String tableName, boolean isExternal,
       List<FieldSchema> cols, List<FieldSchema> partCols,
       List<String> bucketCols, List<Order> sortCols, int numBuckets,
@@ -82,7 +86,6 @@
     this.ifNotExists = ifNotExists;
   }
 
-  
   @Explain(displayName = "columns")
   public List<String> getColsString() {
     return Utilities.getFieldSchemaString(getCols());
@@ -93,8 +96,6 @@
     return Utilities.getFieldSchemaString(getPartCols());
   }
 
-  
-  
   @Explain(displayName = "if not exists")
   public boolean getIfNotExists() {
     return ifNotExists;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * CreateTableLikeDesc.
+ *
+ */
 @Explain(displayName = "Create Table")
 public class CreateTableLikeDesc extends DDLDesc implements Serializable {
   private static final long serialVersionUID = 1L;
@@ -31,7 +35,7 @@
 
   public CreateTableLikeDesc() {
   }
-  
+
   public CreateTableLikeDesc(String tableName, boolean isExternal,
       String location, boolean ifNotExists, String likeTableName) {
     this.tableName = tableName;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java Tue Feb  9 07:55:30 2010
@@ -24,6 +24,10 @@
 import org.apache.hadoop.hive.metastore.api.FieldSchema;
 import org.apache.hadoop.hive.ql.exec.Utilities;
 
+/**
+ * CreateViewDesc.
+ *
+ */
 @Explain(displayName = "Create View")
 public class CreateViewDesc implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * DDLDesc.
+ *
+ */
 public abstract class DDLDesc implements Serializable {
   private static final long serialVersionUID = 1L;
 }

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java Tue Feb  9 07:55:30 2010
@@ -24,6 +24,10 @@
 import org.apache.hadoop.hive.ql.hooks.ReadEntity;
 import org.apache.hadoop.hive.ql.hooks.WriteEntity;
 
+/**
+ * DDLWork.
+ *
+ */
 public class DDLWork implements Serializable {
   private static final long serialVersionUID = 1L;
 
@@ -407,7 +411,7 @@
   public void setDescFunctionDesc(DescFunctionDesc descFunctionDesc) {
     this.descFunctionDesc = descFunctionDesc;
   }
-  
+
   public Set<ReadEntity> getInputs() {
     return inputs;
   }

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DescFunctionDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DescFunctionDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DescFunctionDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DescFunctionDesc.java Tue Feb  9 07:55:30 2010
@@ -22,6 +22,10 @@
 
 import org.apache.hadoop.fs.Path;
 
+/**
+ * DescFunctionDesc.
+ *
+ */
 @Explain(displayName = "Describe Function")
 public class DescFunctionDesc extends DDLDesc implements Serializable {
   private static final long serialVersionUID = 1L;
@@ -38,11 +42,11 @@
   }
 
   /**
-   * table name for the result of show tables
+   * table name for the result of show tables.
    */
   private static final String table = "show";
   /**
-   * thrift ddl for the result of show tables
+   * thrift ddl for the result of show tables.
    */
   private static final String schema = "tab_name#string";
 
@@ -56,7 +60,7 @@
 
   public DescFunctionDesc() {
   }
-  
+
   /**
    * @param resFile
    */

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DescTableDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DescTableDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DescTableDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DescTableDesc.java Tue Feb  9 07:55:30 2010
@@ -23,6 +23,10 @@
 
 import org.apache.hadoop.fs.Path;
 
+/**
+ * DescTableDesc.
+ *
+ */
 @Explain(displayName = "Describe Table")
 public class DescTableDesc extends DDLDesc implements Serializable {
   public void setPartSpec(HashMap<String, String> partSpec) {
@@ -36,17 +40,17 @@
   Path resFile;
   boolean isExt;
   /**
-   * table name for the result of describe table
+   * table name for the result of describe table.
    */
   private static final String table = "describe";
   /**
-   * thrift ddl for the result of describe table
+   * thrift ddl for the result of describe table.
    */
   private static final String schema = "col_name,data_type,comment#string:string:string";
 
   public DescTableDesc() {
   }
-  
+
   /**
    * @param isExt
    * @param partSpec

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * DropFunctionDesc.
+ *
+ */
 @Explain(displayName = "Drop Function")
 public class DropFunctionDesc implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java Tue Feb  9 07:55:30 2010
@@ -20,11 +20,14 @@
 
 import java.io.Serializable;
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 
+/**
+ * DropTableDesc.
+ *
+ */
 @Explain(displayName = "Drop Table")
 public class DropTableDesc extends DDLDesc implements Serializable {
   private static final long serialVersionUID = 1L;
@@ -33,10 +36,9 @@
   ArrayList<LinkedHashMap<String, String>> partSpecs;
   boolean expectView;
 
-  
   public DropTableDesc() {
   }
-  
+
   /**
    * @param tableName
    */
@@ -50,7 +52,7 @@
     this.tableName = tableName;
     this.partSpecs = new ArrayList<LinkedHashMap<String, String>>(partSpecs.size());
     for (int i = 0; i < partSpecs.size(); i++) {
-      this.partSpecs.add(new LinkedHashMap<String, String>(partSpecs.get(i))); 
+      this.partSpecs.add(new LinkedHashMap<String, String>(partSpecs.get(i)));
     }
     expectView = false;
   }

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/Explain.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/Explain.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/Explain.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/Explain.java Tue Feb  9 07:55:30 2010
@@ -21,6 +21,10 @@
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 
+/**
+ * Explain.
+ *
+ */
 @Retention(RetentionPolicy.RUNTIME)
 public @interface Explain {
   String displayName() default "";

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplainWork.java Tue Feb  9 07:55:30 2010
@@ -22,9 +22,12 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.hive.ql.exec.Task;
 
+/**
+ * ExplainWork.
+ *
+ */
 public class ExplainWork implements Serializable {
   private static final long serialVersionUID = 1L;
 

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplosionDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplosionDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplosionDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExplosionDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * ExplosionDesc.
+ *
+ */
 @Explain(displayName = "Explosion")
 public class ExplosionDesc implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeColumnDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeColumnDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeColumnDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeColumnDesc.java Tue Feb  9 07:55:30 2010
@@ -25,6 +25,10 @@
 import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo;
 import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory;
 
+/**
+ * ExprNodeColumnDesc.
+ *
+ */
 public class ExprNodeColumnDesc extends ExprNodeDesc implements Serializable {
   private static final long serialVersionUID = 1L;
 

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDesc.java Tue Feb  9 07:55:30 2010
@@ -24,6 +24,10 @@
 import org.apache.hadoop.hive.ql.lib.Node;
 import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo;
 
+/**
+ * ExprNodeDesc.
+ *
+ */
 public abstract class ExprNodeDesc implements Serializable, Node {
   private static final long serialVersionUID = 1L;
   TypeInfo typeInfo;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeFieldDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeFieldDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeFieldDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeFieldDesc.java Tue Feb  9 07:55:30 2010
@@ -25,6 +25,10 @@
 import org.apache.hadoop.hive.ql.exec.Utilities;
 import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo;
 
+/**
+ * ExprNodeFieldDesc.
+ *
+ */
 public class ExprNodeFieldDesc extends ExprNodeDesc implements Serializable {
   private static final long serialVersionUID = 1L;
   ExprNodeDesc desc;
@@ -32,7 +36,7 @@
 
   // Used to support a.b where a is a list of struct that contains a field
   // called b.
-  // a.b will return an array that contains field b of all elements of array a.
+  // a.b will return an array that contains field b of all elements of array a.
   Boolean isList;
 
   public ExprNodeFieldDesc() {

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java Tue Feb  9 07:55:30 2010
@@ -147,7 +147,7 @@
     for (int i = 0; i < childrenOIs.length; i++) {
       childrenOIs[i] = TypeInfoUtils
           .getStandardWritableObjectInspectorFromTypeInfo(children.get(i)
-              .getTypeInfo());
+          .getTypeInfo());
     }
 
     ObjectInspector oi = genericUDF.initialize(childrenOIs);

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeNullDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeNullDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeNullDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeNullDesc.java Tue Feb  9 07:55:30 2010
@@ -23,6 +23,10 @@
 import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory;
 import org.apache.hadoop.io.NullWritable;
 
+/**
+ * ExprNodeNullDesc.
+ *
+ */
 public class ExprNodeNullDesc extends ExprNodeDesc implements Serializable {
 
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExtractDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExtractDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExtractDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExtractDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * ExtractDesc.
+ *
+ */
 @Explain(displayName = "Extract")
 public class ExtractDesc implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java Tue Feb  9 07:55:30 2010
@@ -24,6 +24,10 @@
 
 import org.apache.hadoop.fs.Path;
 
+/**
+ * FetchWork.
+ *
+ */
 @Explain(displayName = "Fetch Operator")
 public class FetchWork implements Serializable {
   private static final long serialVersionUID = 1L;
@@ -37,7 +41,7 @@
   private int limit;
 
   /**
-   * Serialization Null Format for the serde used to fetch data
+   * Serialization Null Format for the serde used to fetch data.
    */
   private String serializationNullFormat = "NULL";
 

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * FileSinkDesc.
+ *
+ */
 @Explain(displayName = "File Output Operator")
 public class FileSinkDesc implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java Tue Feb  9 07:55:30 2010
@@ -21,11 +21,15 @@
 import java.io.Serializable;
 import java.util.List;
 
+/**
+ * FilterDesc.
+ *
+ */
 @Explain(displayName = "Filter Operator")
 public class FilterDesc implements Serializable {
 
   /**
-   * sampleDesc is used to keep track of the sampling descriptor
+   * sampleDesc is used to keep track of the sampling descriptor.
    */
   public static class sampleDesc {
     // The numerator of the TABLESAMPLE clause

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ForwardDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ForwardDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ForwardDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ForwardDesc.java Tue Feb  9 07:55:30 2010
@@ -20,13 +20,14 @@
 
 import java.io.Serializable;
 
+/**
+ * ForwardDesc.
+ *
+ */
 @Explain(displayName = "Forward")
 public class ForwardDesc implements Serializable {
   private static final long serialVersionUID = 1L;
 
-  @SuppressWarnings("nls")
   public ForwardDesc() {
-    // throw new
-    // RuntimeException("This class does not need to be instantiated");
   }
 }

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * FunctionWork.
+ *
+ */
 public class FunctionWork implements Serializable {
   private static final long serialVersionUID = 1L;
   private CreateFunctionDesc createFunctionDesc;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java Tue Feb  9 07:55:30 2010
@@ -18,6 +18,10 @@
 
 package org.apache.hadoop.hive.ql.plan;
 
+/**
+ * GroupByDesc.
+ *
+ */
 @Explain(displayName = "Group By Operator")
 public class GroupByDesc implements java.io.Serializable {
   /**
@@ -28,10 +32,14 @@
    * PARTIAL1 FINAL: partial aggregation - final phase: merge, terminate HASH:
    * For non-distinct the same as PARTIAL1 but use hash-table-based aggregation
    * MERGEPARTIAL: FINAL for non-distinct aggregations, COMPLETE for distinct
-   * aggregations
+   * aggregations.
    */
   private static final long serialVersionUID = 1L;
 
+  /**
+   * Mode.
+   *
+   */
   public static enum Mode {
     COMPLETE, PARTIAL1, PARTIAL2, PARTIALS, FINAL, HASH, MERGEPARTIAL
   };

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java Tue Feb  9 07:55:30 2010
@@ -52,7 +52,7 @@
   protected java.util.ArrayList<java.lang.String> outputColumnNames;
 
   // key:column output name, value:tag
-  transient private Map<String, Byte> reversedExprs;
+  private transient Map<String, Byte> reversedExprs;
 
   // No outer join involved
   protected boolean noOuterJoin;
@@ -97,8 +97,8 @@
     return reversedExprs;
   }
 
-  public void setReversedExprs(Map<String, Byte> reversed_Exprs) {
-    reversedExprs = reversed_Exprs;
+  public void setReversedExprs(Map<String, Byte> reversedExprs) {
+    this.reversedExprs = reversedExprs;
   }
 
   @Explain(displayName = "condition expressions")
@@ -175,7 +175,7 @@
   }
 
   /**
-   * The order in which tables should be processed when joining
+   * The order in which tables should be processed when joining.
    * 
    * @return Array of tags
    */
@@ -184,7 +184,7 @@
   }
 
   /**
-   * The order in which tables should be processed when joining
+   * The order in which tables should be processed when joining.
    * 
    * @param tagOrder
    *          Array of tags
@@ -199,7 +199,7 @@
   }
 
   /**
-   * set to handle skew join in this join op
+   * set to handle skew join in this join op.
    * 
    * @param handleSkewJoin
    */
@@ -208,14 +208,14 @@
   }
 
   /**
-   * @return mapping from tbl to dir for big keys
+   * @return mapping from tbl to dir for big keys.
    */
   public Map<Byte, String> getBigKeysDirMap() {
     return bigKeysDirMap;
   }
 
   /**
-   * set the mapping from tbl to dir for big keys
+   * set the mapping from tbl to dir for big keys.
    * 
    * @param bigKeysDirMap
    */
@@ -231,7 +231,7 @@
   }
 
   /**
-   * set the mapping from tbl to dir for small keys
+   * set the mapping from tbl to dir for small keys.
    * 
    * @param bigKeysDirMap
    */
@@ -248,7 +248,7 @@
   }
 
   /**
-   * set skew key definition
+   * set skew key definition.
    * 
    * @param skewKeyDefinition
    */

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LateralViewJoinDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LateralViewJoinDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LateralViewJoinDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LateralViewJoinDesc.java Tue Feb  9 07:55:30 2010
@@ -21,6 +21,10 @@
 import java.io.Serializable;
 import java.util.ArrayList;
 
+/**
+ * LateralViewJoinDesc.
+ *
+ */
 @Explain(displayName = "Lateral View Join Operator")
 public class LateralViewJoinDesc implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LimitDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LimitDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LimitDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LimitDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * LimitDesc.
+ *
+ */
 @Explain(displayName = "Limit")
 public class LimitDesc implements Serializable {
   private static final long serialVersionUID = 1L;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * LoadDesc.
+ *
+ */
 public class LoadDesc implements Serializable {
   private static final long serialVersionUID = 1L;
   private String sourceDir;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadFileDesc.java Tue Feb  9 07:55:30 2010
@@ -20,6 +20,10 @@
 
 import java.io.Serializable;
 
+/**
+ * LoadFileDesc.
+ *
+ */
 public class LoadFileDesc extends LoadDesc implements Serializable {
   private static final long serialVersionUID = 1L;
   private String targetDir;

Modified: hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java
URL: http://svn.apache.org/viewvc/hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java?rev=907950&r1=907949&r2=907950&view=diff
==============================================================================
--- hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java (original)
+++ hadoop/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java Tue Feb  9 07:55:30 2010
@@ -21,6 +21,10 @@
 import java.io.Serializable;
 import java.util.HashMap;
 
+/**
+ * LoadTableDesc.
+ *
+ */
 public class LoadTableDesc extends org.apache.hadoop.hive.ql.plan.LoadDesc
     implements Serializable {
   private static final long serialVersionUID = 1L;