[GitHub] [helix] narendly commented on issue #355: Changing IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm.

[GitBox <gi...@apache.org>]

narendly commented on issue #355: Changing IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm.
URL: https://github.com/apache/helix/pull/355#issuecomment-514328978
 
 
   Could we reformat the PR according to the guidelines? Thanks :) -hunter
   
   On Jul 23, 2019, 08:31, at 08:31, pkuwm <no...@github.com> wrote:
   >pkuwm commented on this pull request.
   >
   >
   >
   >> @@ -257,6 +257,10 @@ private boolean
   >computeResourceBestPossibleState(ClusterEvent event, ResourceCon
   > 
   >         // Check if calculation is done successfully
   >         return checkBestPossibleStateCalculation(idealState);
   >+      } catch (HelixException e){
   >
   >Does Helix Style template not handle space in this case? If not, should
   >improve the template.
   >
   >-- 
   >You are receiving this because you are subscribed to this thread.
   >Reply to this email directly or view it on GitHub:
   >https://github.com/apache/helix/pull/355#pullrequestreview-265194396
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services