You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2007/03/22 16:53:32 UTC

[jira] Created: (JCR-811) SetPropertyAssumeTypeTest check for non-protected string array property

SetPropertyAssumeTypeTest check for non-protected string array property
-----------------------------------------------------------------------

                 Key: JCR-811
                 URL: https://issues.apache.org/jira/browse/JCR-811
             Project: Jackrabbit
          Issue Type: Bug
          Components: JCR TCK
            Reporter: Julian Reschke
            Priority: Minor


SetPropertyAssumeTypeTest.testValuesConstraintViolationExceptionBecauseOfInvalidTypeParameter tries to find a property definition for a writable, multivalued string property. It consults NodeTypeUtil.locatePropertyDef() for that purpose.

In my setup, the property definition being returned is for jcr:valueConstraints, defined on nt:propertyDefinition. Nodes of that type in turn can not be created on the test node, thus the test fails already when trying to create the node.

It seems the test suite tries to be too smart here. Can we change this so that the node type and the property name are configuration parameters?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-811) SetPropertyAssumeTypeTest check for non-protected string array property

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke resolved JCR-811.
--------------------------------

    Resolution: Fixed

This resolves the issue for my use cases. However there may be some other scenarios where the strategy of picking a random property type may prove problematic.


> SetPropertyAssumeTypeTest check for non-protected string array property
> -----------------------------------------------------------------------
>
>                 Key: JCR-811
>                 URL: https://issues.apache.org/jira/browse/JCR-811
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR TCK
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>
> SetPropertyAssumeTypeTest.testValuesConstraintViolationExceptionBecauseOfInvalidTypeParameter tries to find a property definition for a writable, multivalued string property. It consults NodeTypeUtil.locatePropertyDef() for that purpose.
> In my setup, the property definition being returned is for jcr:valueConstraints, defined on nt:propertyDefinition. Nodes of that type in turn can not be created on the test node, thus the test fails already when trying to create the node.
> It seems the test suite tries to be too smart here. Can we change this so that the node type and the property name are configuration parameters?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-811) SetPropertyAssumeTypeTest check for non-protected string array property

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke updated JCR-811:
-------------------------------


Fixed with revision 566247.

> SetPropertyAssumeTypeTest check for non-protected string array property
> -----------------------------------------------------------------------
>
>                 Key: JCR-811
>                 URL: https://issues.apache.org/jira/browse/JCR-811
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR TCK
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>
> SetPropertyAssumeTypeTest.testValuesConstraintViolationExceptionBecauseOfInvalidTypeParameter tries to find a property definition for a writable, multivalued string property. It consults NodeTypeUtil.locatePropertyDef() for that purpose.
> In my setup, the property definition being returned is for jcr:valueConstraints, defined on nt:propertyDefinition. Nodes of that type in turn can not be created on the test node, thus the test fails already when trying to create the node.
> It seems the test suite tries to be too smart here. Can we change this so that the node type and the property name are configuration parameters?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-811) SetPropertyAssumeTypeTest check for non-protected string array property

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488593 ] 

Jukka Zitting commented on JCR-811:
-----------------------------------

Agreed. Using configuration parameters sounds good to me.

> SetPropertyAssumeTypeTest check for non-protected string array property
> -----------------------------------------------------------------------
>
>                 Key: JCR-811
>                 URL: https://issues.apache.org/jira/browse/JCR-811
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR TCK
>            Reporter: Julian Reschke
>         Assigned To: Julian Reschke
>            Priority: Minor
>
> SetPropertyAssumeTypeTest.testValuesConstraintViolationExceptionBecauseOfInvalidTypeParameter tries to find a property definition for a writable, multivalued string property. It consults NodeTypeUtil.locatePropertyDef() for that purpose.
> In my setup, the property definition being returned is for jcr:valueConstraints, defined on nt:propertyDefinition. Nodes of that type in turn can not be created on the test node, thus the test fails already when trying to create the node.
> It seems the test suite tries to be too smart here. Can we change this so that the node type and the property name are configuration parameters?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-811) SetPropertyAssumeTypeTest check for non-protected string array property

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-811:
------------------------------

    Affects Version/s: 1.2.1
                       1.2.2
                       1.2.3
                       1.3
                       1.3.1
        Fix Version/s: 1.3.2

Merged to the 1.3 branch in revision 577845.

> SetPropertyAssumeTypeTest check for non-protected string array property
> -----------------------------------------------------------------------
>
>                 Key: JCR-811
>                 URL: https://issues.apache.org/jira/browse/JCR-811
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR TCK
>    Affects Versions: 1.2.1, 1.2.2, 1.2.3, 1.3, 1.3.1
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.3.2
>
>
> SetPropertyAssumeTypeTest.testValuesConstraintViolationExceptionBecauseOfInvalidTypeParameter tries to find a property definition for a writable, multivalued string property. It consults NodeTypeUtil.locatePropertyDef() for that purpose.
> In my setup, the property definition being returned is for jcr:valueConstraints, defined on nt:propertyDefinition. Nodes of that type in turn can not be created on the test node, thus the test fails already when trying to create the node.
> It seems the test suite tries to be too smart here. Can we change this so that the node type and the property name are configuration parameters?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (JCR-811) SetPropertyAssumeTypeTest check for non-protected string array property

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke reassigned JCR-811:
----------------------------------

    Assignee: Julian Reschke

> SetPropertyAssumeTypeTest check for non-protected string array property
> -----------------------------------------------------------------------
>
>                 Key: JCR-811
>                 URL: https://issues.apache.org/jira/browse/JCR-811
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR TCK
>            Reporter: Julian Reschke
>         Assigned To: Julian Reschke
>            Priority: Minor
>
> SetPropertyAssumeTypeTest.testValuesConstraintViolationExceptionBecauseOfInvalidTypeParameter tries to find a property definition for a writable, multivalued string property. It consults NodeTypeUtil.locatePropertyDef() for that purpose.
> In my setup, the property definition being returned is for jcr:valueConstraints, defined on nt:propertyDefinition. Nodes of that type in turn can not be created on the test node, thus the test fails already when trying to create the node.
> It seems the test suite tries to be too smart here. Can we change this so that the node type and the property name are configuration parameters?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-811) SetPropertyAssumeTypeTest check for non-protected string array property

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489106 ] 

Julian Reschke commented on JCR-811:
------------------------------------

Any preferences about using existing name (such as "nodetype" or "propertyname1") vs inventing new ones? Re-using the existing names would affect existing TCK setups...

> SetPropertyAssumeTypeTest check for non-protected string array property
> -----------------------------------------------------------------------
>
>                 Key: JCR-811
>                 URL: https://issues.apache.org/jira/browse/JCR-811
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR TCK
>            Reporter: Julian Reschke
>         Assigned To: Julian Reschke
>            Priority: Minor
>
> SetPropertyAssumeTypeTest.testValuesConstraintViolationExceptionBecauseOfInvalidTypeParameter tries to find a property definition for a writable, multivalued string property. It consults NodeTypeUtil.locatePropertyDef() for that purpose.
> In my setup, the property definition being returned is for jcr:valueConstraints, defined on nt:propertyDefinition. Nodes of that type in turn can not be created on the test node, thus the test fails already when trying to create the node.
> It seems the test suite tries to be too smart here. Can we change this so that the node type and the property name are configuration parameters?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.