[GitHub] [hudi] wangxianghu commented on a change in pull request #2156: [MINOR] Fix wrong javadoc and refactor some naming issues

[GitBox <gi...@apache.org>]

wangxianghu commented on a change in pull request #2156:
URL: https://github.com/apache/hudi/pull/2156#discussion_r502318018



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/AbstractWriteHelper.java
##########
@@ -79,7 +79,7 @@ public I combineOnCondition(
    *
    * @param records     hoodieRecords to deduplicate
    * @param parallelism parallelism or partitions to be used while reducing/deduplicating
-   * @return RDD of HoodieRecord already be deduplicated
+   * @return Collection of HoodieRecord already be deduplicated
    */
   public I deduplicateRecords(
       I records, HoodieTable<T, I, K, O> table, int parallelism) {

Review comment:
       Hi, @yanghua Thanks for raising this pr.
   LGTM overall. and I noticed that there are still two lines contains `RDD` in `hudi-client-common` module. maybe we can improve them together.
   hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:76
   hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:121
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org