[GitHub] [hudi] waitingF commented on a diff in pull request #8378: [HUDI-6031] fix bug: checkpoint lost after changing cow to mor

["waitingF (via GitHub)" <gi...@apache.org>]

waitingF commented on code in PR #8378:
URL: https://github.com/apache/hudi/pull/8378#discussion_r1158079124


##########
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieDeltaStreamerWrapper.java:
##########
@@ -78,7 +78,7 @@ public JavaRDD<WriteStatus> compact() throws Exception {
   public Pair<SchemaProvider, Pair<String, JavaRDD<HoodieRecord>>> fetchSource() throws Exception {
     DeltaSync service = getDeltaSync();
     service.refreshTimeline();
-    return service.readFromSource(service.getCommitTimelineOpt());
+    return service.readFromSource(service.getCommitTimelineOpt(), service.getDeltaCommitTimelineOpt());

Review Comment:
   The definition of the method **readFromSource** changed to:
   
   public Pair<SchemaProvider, Pair<String, JavaRDD<HoodieRecord>>> readFromSource(Option<HoodieTimeline> commitTimelineOpt, Option<HoodieTimeline> deltaCommitTimelineOpt)
   
   added **deltaCommitTimelineOpt** to the param list in order to resume from the correct checkpoint for mor table which just changed from cow table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org