You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/01/12 23:41:24 UTC
Review Request 42217: Modified commit msg hook to include newline
character.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42217/
-----------------------------------------------------------
Review request for mesos, Adam B and Artem Harutyunyan.
Repository: mesos
Description
-------
Trivial change to include the newline character. There might be other fancy ways to fix this. But, my `bash` skills are pretty limited and I took the most naive route.
Diffs
-----
support/hooks/commit-msg 5845398f89e46e97fe8cf6ca51bb54ffe25fef13
Diff: https://reviews.apache.org/r/42217/diff/
Testing
-------
tested that my patch on https://reviews.apache.org/r/41281/ now passes through.
Thanks,
Anand Mazumdar
Re: Review Request 42217: Modified commit msg hook to include newline
character.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42217/#review114094
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Jan. 12, 2016, 2:41 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42217/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 2:41 p.m.)
>
>
> Review request for mesos, Adam B and Artem Harutyunyan.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to include the newline character. There might be other fancy ways to fix this. But, my `bash` skills are pretty limited and I took the most naive route.
>
>
> Diffs
> -----
>
> support/hooks/commit-msg 5845398f89e46e97fe8cf6ca51bb54ffe25fef13
>
> Diff: https://reviews.apache.org/r/42217/diff/
>
>
> Testing
> -------
>
> tested that my patch on https://reviews.apache.org/r/41281/ now passes through.
>
>
> Thanks,
>
> Anand Mazumdar
>
>