[jira] [Comment Edited] (CASSANDRA-9029) Add support for rate limiting log statements

["Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-9029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394984#comment-14394984 ] 

Benedict edited comment on CASSANDRA-9029 at 4/3/15 9:08 PM:
-------------------------------------------------------------

I'm not sure we need all of the myriad accessors (so many different ways of providing the timing interval, the logger, etc). I would personally pare it back to just the NoSpamStatement. I particularly don't see a great deal of benefit to the provision of the current time, since the clock semantics may not match, and we shouldn't be logging in code _that_ performance sensitive. But no super strong feelings, and it looks like it works. +1

(Since I'm no doubt committing, make whatever tweaks you feel necessary post my comments, and I'll commit the result)


was (Author: benedict):
I'm not sure we need all of the myriad accessors (so many different ways of providing the timing interval, the logger, etc). I would personally pare it back to just the NoSpamStatement. I particularly don't see a great deal of benefit to the provision of the current time, since the clock semantics may not match, and we shouldn't be logging in code _that_ performance sensitive. But no super strong feelings, and it looks like it works. +1

> Add support for rate limiting log statements
> --------------------------------------------
>
>                 Key: CASSANDRA-9029
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9029
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)