You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/06/02 09:41:00 UTC

[GitHub] [lucene] LuXugang opened a new pull request, #942: LUCENE-10598: Use count to record docValueCount similar to SortedNumericDocValues did

LuXugang opened a new pull request, #942:
URL: https://github.com/apache/lucene/pull/942

   Add a count used to record docValueCount in Lucene80DocValuesProducer#getSortedSet, similar to what SortedNumericDocValues did.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] jpountz commented on pull request #942: LUCENE-10598: Use count to record docValueCount similar to SortedNumericDocValues did

Posted by GitBox <gi...@apache.org>.
jpountz commented on PR #942:
URL: https://github.com/apache/lucene/pull/942#issuecomment-1145744963

   Maybe also improve CheckIndex to verify that the `count` is still good after iterating over all values? Note that you will need to make the same change to `Lucene70DocValuesProducer` when backporting to `branch_9x`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] LuXugang commented on pull request #942: LUCENE-10598: Use count to record docValueCount similar to SortedNumericDocValues did

Posted by GitBox <gi...@apache.org>.
LuXugang commented on PR #942:
URL: https://github.com/apache/lucene/pull/942#issuecomment-1146538240

   > Note that you will need to make the same change to Lucene70DocValuesProducer when backporting to branch_9x
   
   Thanks for your note.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] LuXugang merged pull request #942: LUCENE-10598: Use count to record docValueCount similar to SortedNumericDocValues did

Posted by GitBox <gi...@apache.org>.
LuXugang merged PR #942:
URL: https://github.com/apache/lucene/pull/942


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org