You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sweisdb (via GitHub)" <gi...@apache.org> on 2023/05/15 16:13:20 UTC

[GitHub] [spark] sweisdb commented on a diff in pull request #40970: [SPARK-43290][SQL] Adds IV and AAD support to aes_encrypt/aes_decrypt

sweisdb commented on code in PR #40970:
URL: https://github.com/apache/spark/pull/40970#discussion_r1194059698


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1051,6 +1051,16 @@
           "expects a binary value with 16, 24 or 32 bytes, but got <actualLength> bytes."
         ]
       },
+      "AES_IV_LENGTH" : {
+        "message" : [
+          "supports 16-byte CBC IVs and 12-byte GCM IVs, but got <actualLength> bytes for <mode>."
+        ]
+      },
+      "AES_SALTED_MAGIC" : {

Review Comment:
   I think this was re-added by mistake when I merged this on top of SPARK-43286. My mistake.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org