You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shale.apache.org by "Doug Chasman (JIRA)" <ji...@apache.org> on 2007/02/04 17:15:16 UTC
[jira] Created: (SHALE-405) Incorrect logic in
MockApplication12.addELResolver(ELResolver resolver)
Incorrect logic in MockApplication12.addELResolver(ELResolver resolver)
-----------------------------------------------------------------------
Key: SHALE-405
URL: https://issues.apache.org/struts/browse/SHALE-405
Project: Shale
Issue Type: Bug
Components: Test
Affects Versions: 1.1.0-SNAPSHOT
Environment: Not environment specific
Reporter: Doug Chasman
Priority: Blocker
Current implementation will never allow addition of el resolvers regardless of the point in the app lifecycle:
/** {@inheritDoc} */
public void addELResolver(ELResolver resolver) {
// Simulate the restriction that you cannot add resolvers after
// the first request has been processed.
if (resolver != null) {
throw new IllegalStateException("Cannot add resolvers now");
}
resolvers.add(resolver);
}
should read:
/** {@inheritDoc} */
public void addELResolver(ELResolver resolver) {
// Simulate the restriction that you cannot add resolvers after
// the first request has been processed.
if (this.resolver != null) {
throw new IllegalStateException("Cannot add resolvers now");
}
resolvers.add(resolver);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHALE-405) Incorrect logic in
MockApplication12.addELResolver(ELResolver resolver)
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/SHALE-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar resolved SHALE-405.
---------------------------------
Resolution: Fixed
This has been fixed in the source repository, thanks for reporting this.
> Incorrect logic in MockApplication12.addELResolver(ELResolver resolver)
> -----------------------------------------------------------------------
>
> Key: SHALE-405
> URL: https://issues.apache.org/struts/browse/SHALE-405
> Project: Shale
> Issue Type: Bug
> Components: Test
> Affects Versions: 1.1.0-SNAPSHOT
> Environment: Not environment specific
> Reporter: Doug Chasman
> Assigned To: Rahul Akolkar
> Priority: Blocker
> Fix For: 1.0.5-SNAPSHOT, 1.1.0-SNAPSHOT
>
>
> Current implementation will never allow addition of el resolvers regardless of the point in the app lifecycle:
> /** {@inheritDoc} */
> public void addELResolver(ELResolver resolver) {
> // Simulate the restriction that you cannot add resolvers after
> // the first request has been processed.
> if (resolver != null) {
> throw new IllegalStateException("Cannot add resolvers now");
> }
> resolvers.add(resolver);
> }
> should read:
> /** {@inheritDoc} */
> public void addELResolver(ELResolver resolver) {
> // Simulate the restriction that you cannot add resolvers after
> // the first request has been processed.
> if (this.resolver != null) {
> throw new IllegalStateException("Cannot add resolvers now");
> }
> resolvers.add(resolver);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHALE-405) Incorrect logic in
MockApplication12.addELResolver(ELResolver resolver)
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/SHALE-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar updated SHALE-405:
--------------------------------
Fix Version/s: 1.1.0-SNAPSHOT
1.0.5-SNAPSHOT
Assignee: Rahul Akolkar
> Incorrect logic in MockApplication12.addELResolver(ELResolver resolver)
> -----------------------------------------------------------------------
>
> Key: SHALE-405
> URL: https://issues.apache.org/struts/browse/SHALE-405
> Project: Shale
> Issue Type: Bug
> Components: Test
> Affects Versions: 1.1.0-SNAPSHOT
> Environment: Not environment specific
> Reporter: Doug Chasman
> Assigned To: Rahul Akolkar
> Priority: Blocker
> Fix For: 1.0.5-SNAPSHOT, 1.1.0-SNAPSHOT
>
>
> Current implementation will never allow addition of el resolvers regardless of the point in the app lifecycle:
> /** {@inheritDoc} */
> public void addELResolver(ELResolver resolver) {
> // Simulate the restriction that you cannot add resolvers after
> // the first request has been processed.
> if (resolver != null) {
> throw new IllegalStateException("Cannot add resolvers now");
> }
> resolvers.add(resolver);
> }
> should read:
> /** {@inheritDoc} */
> public void addELResolver(ELResolver resolver) {
> // Simulate the restriction that you cannot add resolvers after
> // the first request has been processed.
> if (this.resolver != null) {
> throw new IllegalStateException("Cannot add resolvers now");
> }
> resolvers.add(resolver);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.