You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Hao Hao <ha...@cloudera.com> on 2016/04/26 01:59:16 UTC
Review Request 46666: SENTRY-1217: NPE for
list_sentry_privileges_by_authorizable when activeRoleSet is not set
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46666/
-----------------------------------------------------------
Review request for sentry and Anne Yu.
Repository: sentry
Description
-------
SENTRY-1217: NPE for list_sentry_privileges_by_authorizable when activeRoleSet is not set
Change-Id: I55c29f34f8eb70796dc99e5b69cea23579e9c91d
If activeRoleSet, which is optional, is not set when the requestor is in admin group, NPE will be thrown.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java 19c8dd81ac8101f0ad259ea99ca4e1dca97b8b45
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java 9cbd1bd98981c90d76aba52a040bf884a4b6f260
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java 84eeb82163ec73d5dd967a98ac1b977d7d68f497
Diff: https://reviews.apache.org/r/46666/diff/
Testing
-------
Add more test cases to cover when activeRoleSet and groupName are not set for list_sentry_privileges_by_authorizable.
Thanks,
Hao Hao
Re: Review Request 46666: SENTRY-1217: NPE for
list_sentry_privileges_by_authorizable when activeRoleSet is not set
Posted by Lenni Kuff <ls...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46666/#review130525
-----------------------------------------------------------
Ship it!
- Lenni Kuff
On April 25, 2016, 11:59 p.m., Hao Hao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46666/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 11:59 p.m.)
>
>
> Review request for sentry and Anne Yu.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1217: NPE for list_sentry_privileges_by_authorizable when activeRoleSet is not set
>
> Change-Id: I55c29f34f8eb70796dc99e5b69cea23579e9c91d
>
> If activeRoleSet, which is optional, is not set when the requestor is in admin group, NPE will be thrown.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java 19c8dd81ac8101f0ad259ea99ca4e1dca97b8b45
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java 9cbd1bd98981c90d76aba52a040bf884a4b6f260
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java 84eeb82163ec73d5dd967a98ac1b977d7d68f497
>
> Diff: https://reviews.apache.org/r/46666/diff/
>
>
> Testing
> -------
>
> Add more test cases to cover when activeRoleSet and groupName are not set for list_sentry_privileges_by_authorizable.
>
>
> Thanks,
>
> Hao Hao
>
>