[jira] [Commented] (CAMEL-10126) Aggregate - Has name clash for some options

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099561#comment-16099561 ] 

ASF GitHub Bot commented on CAMEL-10126:
----------------------------------------

GitHub user vrlgohel opened a pull request:

    https://github.com/apache/camel/pull/1845

    CAMEL-10126: Refactored completionSize & completionTimeout expressions

    completionTimeout & completionSize attributes and expression usages are confusing in xml dsl, so if we have to change the names, we need to change the names in camel-spring.xsd and camel-blueprint.xsd files.
    
    With the below respective changes,
    
    camel-spring.xsd
    
    <xs:element name="completionTimeoutExpr" type="tns:expressionSubElementDefinition" minOccurs="0"/>
    <xs:element name="completionSizeExpr" type="tns:expressionSubElementDefinition" minOccurs="0"/>
    
    camel-blueprint.xsd
    
        <xs:element minOccurs="0" name="completionTimeoutExpr" type="tns:expressionSubElementDefinition"/>
        <xs:element minOccurs="0" name="completionSizeExpr" type="tns:expressionSubElementDefinition"/>
    
    I tested the committed code with the above xsd changes and i am able to refactor code with 'completionTimeoutExpr' and 'completionSizeExpr' for the use in expressions. I can't commit or have access to camel-spring.xsd and camel-blueprint.xsd, because everytime, i build the camel-spring and camel-blueprint, the xsd changes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vrlgohel/camel-1 master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1845
    
----
commit 2e6fdd1c72e76830d7a85d6c36680b479b866272
Author: Viral Gohel <vr...@gmail.com>
Date:   2017-07-25T05:52:57Z

    [CAMEL-10126] Refactored completionSize & completionTimeout expressions

----


> Aggregate - Has name clash for some options
> -------------------------------------------
>
>                 Key: CAMEL-10126
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10126
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Claus Ibsen
>             Fix For: 3.0.0
>
>         Attachments: Screen Shot 2016-07-06 at 9.50.34 AM.png
>
>
> The aggregate EIP has two option you can set as both attributes and expressions, and this causes a name clash.
> See screenshot



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)