You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/12 13:07:59 UTC
[GitHub] [camel-kafka-connector] apupier opened a new pull request #574: 573 allow to add remove elements from catalog dynamically through api
apupier opened a new pull request #574:
URL: https://github.com/apache/camel-kafka-connector/pull/574
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on a change in pull request #574: 573 allow to add remove elements from catalog dynamically through api
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #574:
URL: https://github.com/apache/camel-kafka-connector/pull/574#discussion_r503316927
##########
File path: camel-kafka-connector-catalog/src/main/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalog.java
##########
@@ -83,7 +83,7 @@ private void initCatalog() {
}
}
- public String getConnectorAsJson(String connectorName) {
+ private String loadConnectorAsJsonFromEmbeddedCatalog(String connectorName) {
Review comment:
Sounds good them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] apupier commented on a change in pull request #574: 573 allow to add remove elements from catalog dynamically through api
Posted by GitBox <gi...@apache.org>.
apupier commented on a change in pull request #574:
URL: https://github.com/apache/camel-kafka-connector/pull/574#discussion_r503314801
##########
File path: camel-kafka-connector-catalog/src/test/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java
##########
@@ -20,30 +20,30 @@
import java.util.Map;
import org.apache.camel.kafkaconnector.model.CamelKafkaConnectorModel;
+import org.apache.camel.kafkaconnector.model.CamelKafkaConnectorOptionModel;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.*;
Review comment:
I was only using the defaults of Eclipse projects but fine to follow another rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on a change in pull request #574: 573 allow to add remove elements from catalog dynamically through api
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #574:
URL: https://github.com/apache/camel-kafka-connector/pull/574#discussion_r503310882
##########
File path: camel-kafka-connector-catalog/src/main/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalog.java
##########
@@ -83,7 +83,7 @@ private void initCatalog() {
}
}
- public String getConnectorAsJson(String connectorName) {
+ private String loadConnectorAsJsonFromEmbeddedCatalog(String connectorName) {
Review comment:
I wouldn't change this name. It doesn't add so much.
##########
File path: camel-kafka-connector-catalog/src/test/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java
##########
@@ -20,30 +20,30 @@
import java.util.Map;
import org.apache.camel.kafkaconnector.model.CamelKafkaConnectorModel;
+import org.apache.camel.kafkaconnector.model.CamelKafkaConnectorOptionModel;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.*;
Review comment:
Please don't import with * operator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on pull request #574: 573 allow to add remove elements from catalog dynamically through api
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #574:
URL: https://github.com/apache/camel-kafka-connector/pull/574#issuecomment-707219679
LGTM. Let me merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] apupier commented on a change in pull request #574: 573 allow to add remove elements from catalog dynamically through api
Posted by GitBox <gi...@apache.org>.
apupier commented on a change in pull request #574:
URL: https://github.com/apache/camel-kafka-connector/pull/574#discussion_r503314146
##########
File path: camel-kafka-connector-catalog/src/main/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalog.java
##########
@@ -83,7 +83,7 @@ private void initCatalog() {
}
}
- public String getConnectorAsJson(String connectorName) {
+ private String loadConnectorAsJsonFromEmbeddedCatalog(String connectorName) {
Review comment:
The added difference is that the method is loading from embedded catalog, it is not able to provide the json from the cached connector that are dynamically added. With the name "getConnectorAsJson", I'm expecting to have also the dynamically added connector to be provided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd merged pull request #574: 573 allow to add remove elements from catalog dynamically through api
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #574:
URL: https://github.com/apache/camel-kafka-connector/pull/574
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org