You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/04/26 10:32:30 UTC
Review Request 46682: Made volume isolator logic injectable for
MockDriverClient.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46682/
-----------------------------------------------------------
Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Repository: mesos
Description
-------
Made volume isolator logic injectable for MockDriverClient.
Diffs
-----
src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 5402973c04ea2045c9ec7b53b58795bf22c9a631
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d
Diff: https://reviews.apache.org/r/46682/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 46682: Made volume isolator logic injectable for
MockDriverClient.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46682/#review130600
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46680, 46681, 46682]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 26, 2016, 8:32 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46682/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 8:32 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made volume isolator logic injectable for MockDriverClient.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 5402973c04ea2045c9ec7b53b58795bf22c9a631
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d
>
> Diff: https://reviews.apache.org/r/46682/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 46682: Made volume isolator logic injectable for
MockDriverClient.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46682/#review130580
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 83 - 84)
<https://reviews.apache.org/r/46682/#comment194415>
Thanks Gilbert for the help! Sorry did not quite catch up how this can help inject the mock driver client here, we can sync up this tomorrow.
- Guangya Liu
On April 26, 2016, 8:32 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46682/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 8:32 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made volume isolator logic injectable for MockDriverClient.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 5402973c04ea2045c9ec7b53b58795bf22c9a631
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d
>
> Diff: https://reviews.apache.org/r/46682/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>