You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/09/14 10:05:24 UTC
[GitHub] [hive] zhangbutao opened a new pull request, #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
zhangbutao opened a new pull request, #3595:
URL: https://github.com/apache/hive/pull/3595
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r993013092
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MySQLConnectorProvider.java:
##########
@@ -27,14 +27,27 @@
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
+import java.util.Properties;
public class MySQLConnectorProvider extends AbstractJDBCConnectorProvider {
private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
private static final String DRIVER_CLASS = "com.mysql.jdbc.Driver";
+ public static final String JDBC_MYSQL_CONFIG_PREFIX = "hive.sql.mysql";
Review Comment:
Good suggestion. Please take another look. thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3595:
URL: https://github.com/apache/hive/pull/3595#issuecomment-1275983683
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3595)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r993092589
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -129,8 +140,34 @@ protected Connection getConnection() {
throw new RuntimeException("unexpected type for connection handle");
}
+ protected boolean isOpen() {
+ if (handle == null) {
Review Comment:
Done, thx :)
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -129,8 +140,34 @@ protected Connection getConnection() {
throw new RuntimeException("unexpected type for connection handle");
}
+ protected boolean isOpen() {
+ if (handle == null) {
+ return false;
+ }
+ try {
+ if (handle instanceof Connection)
+ return ((Connection) handle).isValid(3);
+ } catch (SQLException e) {
+ LOG.warn("Could not validate jdbc connection to "+ jdbcUrl, e);
+ }
+ return false;
+ }
+
+ protected boolean isClosed() {
+ if (handle == null) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on PR #3595:
URL: https://github.com/apache/hive/pull/3595#issuecomment-1275682662
The changes overall look good to me. @nrg4878 Could you please take another look if have secs? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3595:
URL: https://github.com/apache/hive/pull/3595#issuecomment-1247166412
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3595)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [45 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r992420189
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MySQLConnectorProvider.java:
##########
@@ -27,14 +27,27 @@
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
+import java.util.Properties;
public class MySQLConnectorProvider extends AbstractJDBCConnectorProvider {
private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
private static final String DRIVER_CLASS = "com.mysql.jdbc.Driver";
+ public static final String JDBC_MYSQL_CONFIG_PREFIX = "hive.sql.mysql";
Review Comment:
In order to be more generic, the connection properties can defined like this:
`hive.connector.key1=value1`
so when we `getConnectionProperties`, we filter all properties that start with `hive.connector.`, retrieve the key from the `hive.connector.key1`, then put the `key1` and `value1` into the map.
So by this way, we can dynamically set the connection properties of different connectors without making special changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r991818756
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MySQLConnectorProvider.java:
##########
@@ -27,14 +27,27 @@
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
+import java.util.Properties;
public class MySQLConnectorProvider extends AbstractJDBCConnectorProvider {
private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
private static final String DRIVER_CLASS = "com.mysql.jdbc.Driver";
+ public static final String JDBC_MYSQL_CONFIG_PREFIX = "hive.sql.mysql";
Review Comment:
Could we move these to parent `getConnectionProperties()`. For connection properties, all start with `hive.sql.connect.` for example, so users can configure the properties as they want.
Should we also take care of other database vendors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r992288101
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MySQLConnectorProvider.java:
##########
@@ -27,14 +27,27 @@
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
+import java.util.Properties;
public class MySQLConnectorProvider extends AbstractJDBCConnectorProvider {
private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
private static final String DRIVER_CLASS = "com.mysql.jdbc.Driver";
+ public static final String JDBC_MYSQL_CONFIG_PREFIX = "hive.sql.mysql";
Review Comment:
I have moved these three connection properties from `MySQLConnectorProvider` to the parent class `AbstractJDBCConnectorProvider`, so that others could reuse these properties.
Currently, these three connection properties are only used by MySQL connector, because i am not sure other jdbc connectors have these properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r992279846
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -117,7 +117,7 @@ public AbstractJDBCConnectorProvider(String dbName, DataConnector dataConn, Stri
protected Connection getConnection() {
try {
- if (!isOpen)
+ if (!isOpen())
open();
Review Comment:
Done. I make sure close the invalid connection in method `isClosed()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r992277622
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -129,8 +129,21 @@ protected Connection getConnection() {
throw new RuntimeException("unexpected type for connection handle");
}
+ protected boolean isOpen() {
+ if (handle == null) {
+ return false;
+ }
+ try {
+ if (handle instanceof Connection)
+ return ((Connection) handle).isValid(3);
+ } catch (SQLException e) {
+ LOG.warn("Could not validate jdbc connection to "+ jdbcUrl, e);
+ }
+ return false;
+ }
+
@Override public void close() {
- if (isOpen) {
+ if (isOpen()) {
Review Comment:
Make sense. Renamed it to `isClosed()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r991815175
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -117,7 +117,7 @@ public AbstractJDBCConnectorProvider(String dbName, DataConnector dataConn, Stri
protected Connection getConnection() {
try {
- if (!isOpen)
+ if (!isOpen())
open();
Review Comment:
Please close the invalid connection first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r992398531
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -129,8 +129,21 @@ protected Connection getConnection() {
throw new RuntimeException("unexpected type for connection handle");
}
+ protected boolean isOpen() {
+ if (handle == null) {
+ return false;
+ }
+ try {
+ if (handle instanceof Connection)
+ return ((Connection) handle).isValid(3);
+ } catch (SQLException e) {
+ LOG.warn("Could not validate jdbc connection to "+ jdbcUrl, e);
+ }
+ return false;
+ }
+
@Override public void close() {
- if (isOpen) {
+ if (isOpen()) {
Review Comment:
Sorry, what I mean is that we can use `Connection#isClosed` to close the connection, the `isOpen()` method can remain the same(check by `Connection.isValid`), we'd better not to close the connection in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3595:
URL: https://github.com/apache/hive/pull/3595#issuecomment-1274695898
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3595)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r991814837
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -129,8 +129,21 @@ protected Connection getConnection() {
throw new RuntimeException("unexpected type for connection handle");
}
+ protected boolean isOpen() {
+ if (handle == null) {
+ return false;
+ }
+ try {
+ if (handle instanceof Connection)
+ return ((Connection) handle).isValid(3);
+ } catch (SQLException e) {
+ LOG.warn("Could not validate jdbc connection to "+ jdbcUrl, e);
+ }
+ return false;
+ }
+
@Override public void close() {
- if (isOpen) {
+ if (isOpen()) {
Review Comment:
though the connection may be invalid, but it may still remain opening, should we use `isClosed()` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r992288101
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MySQLConnectorProvider.java:
##########
@@ -27,14 +27,27 @@
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
+import java.util.Properties;
public class MySQLConnectorProvider extends AbstractJDBCConnectorProvider {
private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
private static final String DRIVER_CLASS = "com.mysql.jdbc.Driver";
+ public static final String JDBC_MYSQL_CONFIG_PREFIX = "hive.sql.mysql";
Review Comment:
I have moved these three connection properties from `MySQLConnectorProvider` to the parent class `AbstractJDBCConnectorProvider`, so that others could reuse this properties.
Currentle, these three connection properties are only used by MySQL connector, because i am not sure other jdbc connectors have these properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r993012155
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -129,8 +129,21 @@ protected Connection getConnection() {
throw new RuntimeException("unexpected type for connection handle");
}
+ protected boolean isOpen() {
+ if (handle == null) {
+ return false;
+ }
+ try {
+ if (handle instanceof Connection)
+ return ((Connection) handle).isValid(3);
+ } catch (SQLException e) {
+ LOG.warn("Could not validate jdbc connection to "+ jdbcUrl, e);
+ }
+ return false;
+ }
+
@Override public void close() {
- if (isOpen) {
+ if (isOpen()) {
Review Comment:
Sorry for misunderstanding what you meant. I wrap a new method `isClosed()` to check the connection` closed` status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r993012743
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -117,7 +117,7 @@ public AbstractJDBCConnectorProvider(String dbName, DataConnector dataConn, Stri
protected Connection getConnection() {
try {
- if (!isOpen)
+ if (!isOpen())
open();
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r993062879
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -129,8 +140,34 @@ protected Connection getConnection() {
throw new RuntimeException("unexpected type for connection handle");
}
+ protected boolean isOpen() {
+ if (handle == null) {
Review Comment:
nit: we can remove this check here, this can be done through `handle instanceof Connection`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3595:
URL: https://github.com/apache/hive/pull/3595#issuecomment-1275646345
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3595)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 merged pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
nrg4878 merged PR #3595:
URL: https://github.com/apache/hive/pull/3595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on PR #3595:
URL: https://github.com/apache/hive/pull/3595#issuecomment-1276974124
> please resolve all the comments that have been addressed.
@nrg4878 Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on PR #3595:
URL: https://github.com/apache/hive/pull/3595#issuecomment-1276968310
@zhangbutao please resolve all the comments that have been addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zhangbutao commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
zhangbutao commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r992288101
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MySQLConnectorProvider.java:
##########
@@ -27,14 +27,27 @@
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
+import java.util.Properties;
public class MySQLConnectorProvider extends AbstractJDBCConnectorProvider {
private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
private static final String DRIVER_CLASS = "com.mysql.jdbc.Driver";
+ public static final String JDBC_MYSQL_CONFIG_PREFIX = "hive.sql.mysql";
Review Comment:
I have moved these three connection properties from `MySQLConnectorProvider` to the parent class `AbstractJDBCConnectorProvider`, so that others could reuse this properties.
Currently, these three connection properties are only used by MySQL connector, because i am not sure other jdbc connectors have these properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3595:
URL: https://github.com/apache/hive/pull/3595#issuecomment-1246640211
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3595)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [45 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r992404649
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -117,7 +117,7 @@ public AbstractJDBCConnectorProvider(String dbName, DataConnector dataConn, Stri
protected Connection getConnection() {
try {
- if (!isOpen)
+ if (!isOpen())
open();
Review Comment:
cloud we move it in the `open()` method?
`open() {
close()
// open new connection
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r993063136
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -129,8 +140,34 @@ protected Connection getConnection() {
throw new RuntimeException("unexpected type for connection handle");
}
+ protected boolean isOpen() {
+ if (handle == null) {
+ return false;
+ }
+ try {
+ if (handle instanceof Connection)
+ return ((Connection) handle).isValid(3);
+ } catch (SQLException e) {
+ LOG.warn("Could not validate jdbc connection to "+ jdbcUrl, e);
+ }
+ return false;
+ }
+
+ protected boolean isClosed() {
+ if (handle == null) {
Review Comment:
same as above..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3595: HIVE-26045: Detect timed out connections for providers and auto-reconnect
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3595:
URL: https://github.com/apache/hive/pull/3595#issuecomment-1276736023
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3595)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3595&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3595&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3595&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org