[jira] [Resolved] (DELTASPIKE-1183) NPE in proxy handler with concurrent requests

["John D. Ament (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DELTASPIKE-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John D. Ament resolved DELTASPIKE-1183.
---------------------------------------
    Resolution: Fixed

> NPE in proxy handler with concurrent requests
> ---------------------------------------------
>
>                 Key: DELTASPIKE-1183
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1183
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: PartialBean, Proxy-Module
>            Reporter: John D. Ament
>            Assignee: John D. Ament
>             Fix For: 1.7.1
>
>
> The following test will fail, with proxies in play:
> {code}
> import static java.lang.annotation.RetentionPolicy.RUNTIME;
> import static java.util.concurrent.TimeUnit.SECONDS;
> import java.lang.annotation.Retention;
> import java.lang.reflect.InvocationHandler;
> import java.lang.reflect.Method;
> import java.util.ArrayList;
> import java.util.List;
> import java.util.concurrent.ExecutorService;
> import java.util.concurrent.Future;
> import java.util.concurrent.RejectedExecutionHandler;
> import java.util.concurrent.SynchronousQueue;
> import java.util.concurrent.ThreadPoolExecutor;
> import javax.annotation.Resource;
> import javax.enterprise.concurrent.ManagedThreadFactory;
> import javax.inject.Inject;
> import org.apache.deltaspike.core.api.provider.BeanManagerProvider;
> import org.apache.deltaspike.partialbean.api.PartialBeanBinding;
> import org.apache.deltaspike.partialbean.impl.PartialBeanBindingExtension;
> import org.apache.deltaspike.proxy.impl.invocation.DelegateManualInvocationHandler;
> import org.apache.deltaspike.proxy.impl.invocation.InterceptorLookup;
> import org.apache.openejb.junit.ApplicationComposerRule;
> import org.apache.openejb.testing.CdiExtensions;
> import org.apache.openejb.testing.Module;
> import org.junit.Rule;
> import org.junit.Test;
> import org.junit.rules.TestRule;
> public @CdiExtensions({BeanManagerProvider.class, PartialBeanBindingExtension.class}) class ConcurrencyBugTest {
>     public final @Rule TestRule composer = new ApplicationComposerRule(this);
>     public @PartialBeanBinding @Retention(RUNTIME) @interface MyPartialBeanBinding {
>     }
>     public @MyPartialBeanBinding interface PartialBean {
>         String getValue();
>     }
>     public static @MyPartialBeanBinding class MyPartialBeanHandler implements InvocationHandler {
>         public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
>             return method.getName();
>         }
>     }
>    
>     private class BlockPolicy implements RejectedExecutionHandler {
>         public @Override void rejectedExecution(Runnable runnable, ThreadPoolExecutor executor) {
>             try {
>                 executor.getQueue().put(runnable);
>             } catch (InterruptedException interruptedException) {
>                 Thread.currentThread().interrupt();
>             }
>         }
>     }
>     public @Module Class<?>[] classes() {
>         return new Class<?>[] { DelegateManualInvocationHandler.class, InterceptorLookup.class, PartialBean.class, MyPartialBeanHandler.class, MyPartialBeanHandler.class };
>     }
>     private @Resource ManagedThreadFactory threadFactory;
>     private @Inject PartialBean bean;
>     public @Test void test() throws Exception {
>         ExecutorService executor = new ThreadPoolExecutor(5, 10, 60, SECONDS, new SynchronousQueue<>(), this.threadFactory, new BlockPolicy());
>         List<Future<String>> results = new ArrayList<>(100);
>         for (int i = 0; i < 100; i++) {
>             results.add(executor.submit(this.bean::getValue));
>         }
>         executor.shutdown();
>         executor.awaitTermination(60, SECONDS);
>         for (int i = 0; i < 100; i++) {
>             results.get(i).get();
>         }
>     }
> }
> java.util.concurrent.ExecutionException: java.lang.NullPointerException
>     at java.util.concurrent.FutureTask.report(Unknown Source)
>     at java.util.concurrent.FutureTask.get(Unknown Source)
>     at be.fgov.sfpd.attestation.ConcurrencyBugTest.test(ConcurrencyBugTest.java:79)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>     at java.lang.reflect.Method.invoke(Unknown Source)
>     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>     at org.apache.openejb.junit.DeployApplication$1.call(DeployApplication.java:44)
>     at org.apache.openejb.junit.DeployApplication$1.call(DeployApplication.java:40)
>     at org.apache.openejb.testing.ApplicationComposers.evaluate(ApplicationComposers.java:1067)
>     at org.apache.openejb.junit.DeployApplication.evaluate(DeployApplication.java:40)
>     at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>     at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>     at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>     at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>     at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
>     at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
>     at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
>     at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678)
>     at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
>     at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)