You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/10 09:59:54 UTC
[GitHub] [dolphinscheduler] wushanru opened a new pull request, #12297: [Docs] Change the process in all files to workflow
wushanru opened a new pull request, #12297:
URL: https://github.com/apache/dolphinscheduler/pull/12297
[Docs] Change the process in all files to workflow
A PR has been submitted before, closed by mistake, resubmit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #12297: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #12297:
URL: https://github.com/apache/dolphinscheduler/pull/12297#discussion_r991744911
##########
docs/docs/en/DSIP.md:
##########
@@ -27,7 +27,7 @@ Current DSIPs including all DSIP still work-in-progress, you could see in [curre
Past DSIPs including all DSIP already done or retired for some reason, you could see in [past DSIPs][past-DSIPs]
-## DSIP Process
+## DSIP Workflow
Review Comment:
Wrong change
```suggestion
## DSIP Process
```
##########
docs/docs/en/architecture/design.md:
##########
@@ -55,7 +55,7 @@
- **WorkerManagerThread** is mainly responsible for the submission of the task queue, continuously receives tasks from the task queue, and submits them to the thread pool for processing;
- - **TaskExecuteThread** is mainly responsible for the process of task execution, and the actual processing of tasks according to different task types;
+ - **TaskExecuteThread** is mainly responsible for the workflow of task execution, and the actual processing of tasks according to different task types;
Review Comment:
personally think this should not change too
##########
docs/docs/en/architecture/cache.md:
##########
@@ -2,9 +2,9 @@
## Purpose
-Due to the large database read operations during the master-server scheduling process. Such as read tables like `tenant`, `user`, `processDefinition`, etc. Operations stress read pressure to the DB, and slow down the entire core scheduling process.
+Due to the large database read operations during the master-server scheduling workflow. Such as read tables like `tenant`, `user`, `processDefinition`, etc. Operations stress read pressure to the DB, and slow down the entire core scheduling workflow.
Review Comment:
I think this content also should not change. Am I right @caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed pull request #12297: [Docs] Change the process in all files to workflow
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12297: [Docs] Change the process in all files to workflow
URL: https://github.com/apache/dolphinscheduler/pull/12297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12297: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #12297:
URL: https://github.com/apache/dolphinscheduler/pull/12297#discussion_r1011768971
##########
docs/docs/en/architecture/cache.md:
##########
@@ -2,9 +2,9 @@
## Purpose
-Due to the large database read operations during the master-server scheduling process. Such as read tables like `tenant`, `user`, `processDefinition`, etc. Operations stress read pressure to the DB, and slow down the entire core scheduling process.
+Due to the large database read operations during the master-server scheduling workflow. Such as read tables like `tenant`, `user`, `processDefinition`, etc. Operations stress read pressure to the DB, and slow down the entire core scheduling workflow.
Review Comment:
Yes, shouldn't change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #12297: [Docs] Change the process in all files to workflow
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12297:
URL: https://github.com/apache/dolphinscheduler/pull/12297#issuecomment-1467158152
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12297: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #12297:
URL: https://github.com/apache/dolphinscheduler/pull/12297#discussion_r991785803
##########
docs/docs/en/architecture/design.md:
##########
@@ -55,7 +55,7 @@
- **WorkerManagerThread** is mainly responsible for the submission of the task queue, continuously receives tasks from the task queue, and submits them to the thread pool for processing;
- - **TaskExecuteThread** is mainly responsible for the process of task execution, and the actual processing of tasks according to different task types;
+ - **TaskExecuteThread** is mainly responsible for the workflow of task execution, and the actual processing of tasks according to different task types;
Review Comment:
No, shouldn't change it. Keep it as `process`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on a diff in pull request #12297: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on code in PR #12297:
URL: https://github.com/apache/dolphinscheduler/pull/12297#discussion_r991788185
##########
docs/docs/en/architecture/design.md:
##########
@@ -55,7 +55,7 @@
- **WorkerManagerThread** is mainly responsible for the submission of the task queue, continuously receives tasks from the task queue, and submits them to the thread pool for processing;
- - **TaskExecuteThread** is mainly responsible for the process of task execution, and the actual processing of tasks according to different task types;
+ - **TaskExecuteThread** is mainly responsible for the workflow of task execution, and the actual processing of tasks according to different task types;
Review Comment:
> No, shouldn't change it. Keep it as `process`.
OK, I understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on a diff in pull request #12297: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on code in PR #12297:
URL: https://github.com/apache/dolphinscheduler/pull/12297#discussion_r991756417
##########
docs/docs/en/architecture/cache.md:
##########
@@ -2,9 +2,9 @@
## Purpose
-Due to the large database read operations during the master-server scheduling process. Such as read tables like `tenant`, `user`, `processDefinition`, etc. Operations stress read pressure to the DB, and slow down the entire core scheduling process.
+Due to the large database read operations during the master-server scheduling workflow. Such as read tables like `tenant`, `user`, `processDefinition`, etc. Operations stress read pressure to the DB, and slow down the entire core scheduling workflow.
Review Comment:
@caishunfeng Please confirm whether it needs to be modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wushanru commented on a diff in pull request #12297: [Docs] Change the process in all files to workflow
Posted by GitBox <gi...@apache.org>.
wushanru commented on code in PR #12297:
URL: https://github.com/apache/dolphinscheduler/pull/12297#discussion_r991756614
##########
docs/docs/en/architecture/design.md:
##########
@@ -55,7 +55,7 @@
- **WorkerManagerThread** is mainly responsible for the submission of the task queue, continuously receives tasks from the task queue, and submits them to the thread pool for processing;
- - **TaskExecuteThread** is mainly responsible for the process of task execution, and the actual processing of tasks according to different task types;
+ - **TaskExecuteThread** is mainly responsible for the workflow of task execution, and the actual processing of tasks according to different task types;
Review Comment:
@zhongjiajie Please confirm whether it needs to be modified, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #12297: [Docs] Change the process in all files to workflow
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12297:
URL: https://github.com/apache/dolphinscheduler/pull/12297#issuecomment-1452828594
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org