You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2025/11/03 06:52:00 UTC

[jira] [Created] (PHOENIX-7723) Replace relative table version timestamps in upgrade code

Istvan Toth created PHOENIX-7723:
------------------------------------

             Summary: Replace relative table version timestamps in upgrade code
                 Key: PHOENIX-7723
                 URL: https://issues.apache.org/jira/browse/PHOENIX-7723
             Project: Phoenix
          Issue Type: Improvement
            Reporter: Istvan Toth


We have a lot of statements like 
{code:java}
addColumnsIfNotExists(metaConnection, PhoenixDatabaseMetaData.SYSTEM_CATALOG,
        MIN_SYSTEM_TABLE_TIMESTAMP_5_4_0 - 8,
        PhoenixDatabaseMetaData.SCHEMA_VERSION + " " + PVarchar.INSTANCE.getSqlTypeName());{code}
in [ConnectionQueryServicesImpl.java|https://github.com/apache/phoenix/pull/2303/files#diff-ccfa52b4c1c783877fade96f82548d5feec1a2993c0c4d2c423c6fc8f199e60d] 

This is both fragile and hard to deipher.

Replace the subtractions with the actual version constants.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)