[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1224: [CELEBORN-291] optimize shuffleclientimpl creating client and pushdata for mappartition

["FMX (via GitHub)" <gi...@apache.org>]

FMX commented on code in PR #1224:
URL: https://github.com/apache/incubator-celeborn/pull/1224#discussion_r1109368964


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClient.java:
##########
@@ -338,4 +352,26 @@ protected void handleFailure(String errorMsg, Throwable cause) {
       callback.onFailure(new IOException(errorMsg, cause));
     }
   }
+
+  private class RpcChannelListenerWithCompleteCallback extends RpcChannelListener {
+    final BooleanSupplier closeCallBack;

Review Comment:
   No result is expected, the supplier can be replaced.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org