You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/01 11:14:57 UTC
[GitHub] [spark] akshatb1 opened a new pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
akshatb1 opened a new pull request #28429:
URL: https://github.com/apache/spark/pull/28429
…to launch driver
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
Fixing an issue where Spark Master UI Fails to load if the application is waiting for workers to launch driver.
**Root Cause:**
This is happening due to the fact that the submitted application is waiting for a worker to be free to run the driver. Due to this resource is set to null in the formatResourcesAddresses method and this is running into null pointer exception.
**Fix:**
Added a null check before forming a resource address and display "None" if the driver isn't launched yet.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Spark Master UI should load as expected when applications are waiting for workers to run driver.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
The worker column in Spark Master UI will show "None" if the driver hasn't been launched yet.
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Tested on a local setup. Launched 2 applications and ensured that Spark Master UI loads fine.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akshatb1 commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
akshatb1 commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-624079240
> looks good, thanks @akshatb1
Thanks very much @tgravescs !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623508527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-624073035
merged to master and branch-3.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-622350042
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akshatb1 commented on a change in pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
akshatb1 commented on a change in pull request #28429:
URL: https://github.com/apache/spark/pull/28429#discussion_r419499799
##########
File path: core/src/main/scala/org/apache/spark/deploy/StandaloneResourceUtils.scala
##########
@@ -142,9 +142,13 @@ private[spark] object StandaloneResourceUtils extends Logging {
// used for UI
def formatResourcesAddresses(resources: Map[String, ResourceInformation]): String = {
- resources.map { case (rName, rInfo) =>
- s"$rName: ${rInfo.addresses.mkString("[", ", ", "]")}"
- }.mkString(", ")
+ if (resources != null) {
Review comment:
Thanks @tgravescs. I will fix it in the DriverInfo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623507909
**[Test build #122271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122271/testReport)** for PR 28429 at commit [`ccbca2e`](https://github.com/apache/spark/commit/ccbca2e93fac2247acad694d48d74bff120c8f8a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623731195
**[Test build #122286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122286/testReport)** for PR 28429 at commit [`ad82bdd`](https://github.com/apache/spark/commit/ad82bdd74fbfb603d3397c4b660c5ca8ba7d820d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akshatb1 commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
akshatb1 commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-622831403
> The change looks simple and reasonable to me. Not sure who are actively reviewing the issues on standalone mode though.
> cc. @tgravescs @Ngone51 as they've authored & merged the code.
Thanks @HeartSaVioR for checking this PR.
CC: @tgravescs @Ngone51 Could you kindly take a look at this. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623538475
**[Test build #122273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122273/testReport)** for PR 28429 at commit [`ad82bdd`](https://github.com/apache/spark/commit/ad82bdd74fbfb603d3397c4b660c5ca8ba7d820d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623506453
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623739907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623538475
**[Test build #122273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122273/testReport)** for PR 28429 at commit [`ad82bdd`](https://github.com/apache/spark/commit/ad82bdd74fbfb603d3397c4b660c5ca8ba7d820d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-622350042
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akshatb1 commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
akshatb1 commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623516056
> Thanks for pinging me @HeartSaVioR .
>
> Thanks for fixing! and I will LGTM if you @akshatb1 can fix in the way as @tgravescs suggested.
Thanks @Ngone51 . I will update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623539262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623634567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623732032
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122286/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623637811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-622349658
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akshatb1 commented on a change in pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
akshatb1 commented on a change in pull request #28429:
URL: https://github.com/apache/spark/pull/28429#discussion_r419499799
##########
File path: core/src/main/scala/org/apache/spark/deploy/StandaloneResourceUtils.scala
##########
@@ -142,9 +142,13 @@ private[spark] object StandaloneResourceUtils extends Logging {
// used for UI
def formatResourcesAddresses(resources: Map[String, ResourceInformation]): String = {
- resources.map { case (rName, rInfo) =>
- s"$rName: ${rInfo.addresses.mkString("[", ", ", "]")}"
- }.mkString(", ")
+ if (resources != null) {
Review comment:
Thanks @tgravescs. I will fix it in the DriverInfo. With that change, do we still want to keep this change in StandaloneResourceUtils.scala? I had presumed that the null value was as intended for the drivers which are not launched, hence made above fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623738834
**[Test build #122285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122285/testReport)** for PR 28429 at commit [`ad82bdd`](https://github.com/apache/spark/commit/ad82bdd74fbfb603d3397c4b660c5ca8ba7d820d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623739907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akshatb1 edited a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
akshatb1 edited a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623536520
> Thanks for pinging me @HeartSaVioR .
>
> Thanks for fixing! and I will LGTM if you @akshatb1 can fix in the way as @tgravescs suggested.
@Ngone51 Updated the PR. Please take a look. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-622349658
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akshatb1 edited a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
akshatb1 edited a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-622831403
> The change looks simple and reasonable to me. Not sure who are actively reviewing the issues on standalone mode though.
> cc. @tgravescs @Ngone51 as they've authored & merged the code.
Thanks @HeartSaVioR for checking this PR.
CC: @tgravescs @Ngone51 Could you kindly take a look at this? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623642556
**[Test build #122286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122286/testReport)** for PR 28429 at commit [`ad82bdd`](https://github.com/apache/spark/commit/ad82bdd74fbfb603d3397c4b660c5ca8ba7d820d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akshatb1 commented on a change in pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
akshatb1 commented on a change in pull request #28429:
URL: https://github.com/apache/spark/pull/28429#discussion_r419526099
##########
File path: core/src/main/scala/org/apache/spark/deploy/StandaloneResourceUtils.scala
##########
@@ -142,9 +142,13 @@ private[spark] object StandaloneResourceUtils extends Logging {
// used for UI
def formatResourcesAddresses(resources: Map[String, ResourceInformation]): String = {
- resources.map { case (rName, rInfo) =>
- s"$rName: ${rInfo.addresses.mkString("[", ", ", "]")}"
- }.mkString(", ")
+ if (resources != null) {
Review comment:
@tgravescs Update the PR. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623539262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623632948
**[Test build #122271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122271/testReport)** for PR 28429 at commit [`ccbca2e`](https://github.com/apache/spark/commit/ccbca2e93fac2247acad694d48d74bff120c8f8a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623508527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623732029
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623639106
**[Test build #122285 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122285/testReport)** for PR 28429 at commit [`ad82bdd`](https://github.com/apache/spark/commit/ad82bdd74fbfb603d3397c4b660c5ca8ba7d820d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623636845
**[Test build #122273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122273/testReport)** for PR 28429 at commit [`ad82bdd`](https://github.com/apache/spark/commit/ad82bdd74fbfb603d3397c4b660c5ca8ba7d820d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] akshatb1 commented on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
akshatb1 commented on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623536520
> Thanks for pinging me @HeartSaVioR .
>
> Thanks for fixing! and I will LGTM if you @akshatb1 can fix in the way as @tgravescs suggested.
@Ngone51 Update the PR. Please take a look. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623642556
**[Test build #122286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122286/testReport)** for PR 28429 at commit [`ad82bdd`](https://github.com/apache/spark/commit/ad82bdd74fbfb603d3397c4b660c5ca8ba7d820d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #28429:
URL: https://github.com/apache/spark/pull/28429#discussion_r419495926
##########
File path: core/src/main/scala/org/apache/spark/deploy/StandaloneResourceUtils.scala
##########
@@ -142,9 +142,13 @@ private[spark] object StandaloneResourceUtils extends Logging {
// used for UI
def formatResourcesAddresses(resources: Map[String, ResourceInformation]): String = {
- resources.map { case (rName, rInfo) =>
- s"$rName: ${rInfo.addresses.mkString("[", ", ", "]")}"
- }.mkString(", ")
+ if (resources != null) {
Review comment:
We should fix this so that resources can't be null. it should be an empty map which would return empty string.
Can you please fix DriverInfo:
private var _resources: Map[String, ResourceInformation] = _
That should be initialized to Map.empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623637811
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623732029
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28429:
URL: https://github.com/apache/spark/pull/28429#issuecomment-623634567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org