You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Ruphine Kengne <ru...@gmail.com> on 2018/04/07 13:57:28 UTC
Integrating Group Service into the Demo-server
Hello everyone,
I have successfully added the Group microservice into the demo-server under
Fineract CN and I have sent a pull request. Here is the link:
https://github.com/apache/fineract-cn-demo-server/pull/9
Regards,
Ruphine Kengne
Re: Integrating Group Service into the Demo-server
Posted by Ruphine Kengne <ru...@gmail.com>.
Thanks Courage.
On 9 April 2018 at 14:19, Courage Angeh <co...@gmail.com> wrote:
> Ruphine u didnt need to close the old PR. Just making a change on that
> branch would have updated the old PR.
>
> On Mon, Apr 9, 2018, 12:33 PM Ruphine Kengne <ru...@gmail.com>
> wrote:
>
> > Hey everyone,
> >
> > I have closed the old PR and created a new one where the.project file is
> > not checked-in.
> >
> > Here is the link to the new PR:
> > https://github.com/apache/fineract-cn-demo-server/pull/10
> >
> > Regards,
> > Ruphine Kengne
> >
> > On 8 April 2018 at 16:47, Isaac Kamga <is...@mifos.org> wrote:
> >
> > > Hello Kengne,
> > >
> > > Your pull request looks good from a glance.
> > >
> > > However, you need to update it by dropping the .project file which I
> > don't
> > > think demo-server needs.
> > >
> > > At Your Service,
> > > Isaac Kamga.
> > >
> > > On Sat, Apr 7, 2018 at 2:57 PM, Ruphine Kengne <
> ruphinekengne@gmail.com>
> > > wrote:
> > >
> > > > Hello everyone,
> > > >
> > > >
> > > > I have successfully added the Group microservice into the demo-server
> > > under
> > > > Fineract CN and I have sent a pull request. Here is the link:
> > > >
> > > > https://github.com/apache/fineract-cn-demo-server/pull/9
> > > >
> > > >
> > > > Regards,
> > > >
> > > > Ruphine Kengne
> > > >
> > >
> >
>
Re: Integrating Group Service into the Demo-server
Posted by Courage Angeh <co...@gmail.com>.
Ruphine u didnt need to close the old PR. Just making a change on that
branch would have updated the old PR.
On Mon, Apr 9, 2018, 12:33 PM Ruphine Kengne <ru...@gmail.com>
wrote:
> Hey everyone,
>
> I have closed the old PR and created a new one where the.project file is
> not checked-in.
>
> Here is the link to the new PR:
> https://github.com/apache/fineract-cn-demo-server/pull/10
>
> Regards,
> Ruphine Kengne
>
> On 8 April 2018 at 16:47, Isaac Kamga <is...@mifos.org> wrote:
>
> > Hello Kengne,
> >
> > Your pull request looks good from a glance.
> >
> > However, you need to update it by dropping the .project file which I
> don't
> > think demo-server needs.
> >
> > At Your Service,
> > Isaac Kamga.
> >
> > On Sat, Apr 7, 2018 at 2:57 PM, Ruphine Kengne <ru...@gmail.com>
> > wrote:
> >
> > > Hello everyone,
> > >
> > >
> > > I have successfully added the Group microservice into the demo-server
> > under
> > > Fineract CN and I have sent a pull request. Here is the link:
> > >
> > > https://github.com/apache/fineract-cn-demo-server/pull/9
> > >
> > >
> > > Regards,
> > >
> > > Ruphine Kengne
> > >
> >
>
Re: Integrating Group Service into the Demo-server
Posted by Ruphine Kengne <ru...@gmail.com>.
Hey everyone,
I have closed the old PR and created a new one where the.project file is
not checked-in.
Here is the link to the new PR:
https://github.com/apache/fineract-cn-demo-server/pull/10
Regards,
Ruphine Kengne
On 8 April 2018 at 16:47, Isaac Kamga <is...@mifos.org> wrote:
> Hello Kengne,
>
> Your pull request looks good from a glance.
>
> However, you need to update it by dropping the .project file which I don't
> think demo-server needs.
>
> At Your Service,
> Isaac Kamga.
>
> On Sat, Apr 7, 2018 at 2:57 PM, Ruphine Kengne <ru...@gmail.com>
> wrote:
>
> > Hello everyone,
> >
> >
> > I have successfully added the Group microservice into the demo-server
> under
> > Fineract CN and I have sent a pull request. Here is the link:
> >
> > https://github.com/apache/fineract-cn-demo-server/pull/9
> >
> >
> > Regards,
> >
> > Ruphine Kengne
> >
>
Re: Integrating Group Service into the Demo-server
Posted by Isaac Kamga <is...@mifos.org>.
Hello Kengne,
Your pull request looks good from a glance.
However, you need to update it by dropping the .project file which I don't
think demo-server needs.
At Your Service,
Isaac Kamga.
On Sat, Apr 7, 2018 at 2:57 PM, Ruphine Kengne <ru...@gmail.com>
wrote:
> Hello everyone,
>
>
> I have successfully added the Group microservice into the demo-server under
> Fineract CN and I have sent a pull request. Here is the link:
>
> https://github.com/apache/fineract-cn-demo-server/pull/9
>
>
> Regards,
>
> Ruphine Kengne
>