You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/05 17:22:38 UTC

[jira] [Commented] (CB-8552) add toolbar option to android

    [ https://issues.apache.org/jira/browse/CB-8552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349015#comment-14349015 ] 

ASF GitHub Bot commented on CB-8552:
------------------------------------

GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/87

    CB-8552 Add toolbar option for android

    This change adds the toolbar option to android. The location property determines whether or not the URL is visible while the toolbar property shows or hides the entire toolbar.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser android-toolbar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #87
    
----
commit 6672ee4e9cb804da32c3014d7ab455ae4fe85228
Author: Connor Pearson <cj...@gmail.com>
Date:   2015-02-26T14:06:06Z

    CB-8552: Add toolbar property to android

commit 36833685330c0ce66cc26ffcd54b91341f99c9bc
Author: Connor Pearson <cj...@gmail.com>
Date:   2015-02-26T14:08:23Z

    update docs for toolbar option

----


> add toolbar option to android
> -----------------------------
>
>                 Key: CB-8552
>                 URL: https://issues.apache.org/jira/browse/CB-8552
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, Plugin InAppBrowser
>            Reporter: Connor Pearson
>
> iOS has both the location and toolbar option on the inappbrowser. This allows the user to hide the URL, but still show the browser controls. This fix adds the toolbar option to android. The location property determines whether or not the URL is visible while the toolbar property shows or hides the entire toolbar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org