You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/02 13:10:59 UTC
[GitHub] [ozone] mookkiah opened a new pull request #1748: sonarqube issue fix - "static" members should be accessed statically
mookkiah opened a new pull request #1748:
URL: https://github.com/apache/ozone/pull/1748
Signed-off-by: Mahendran Mookkiah <ma...@gmail.com>
## What changes were proposed in this pull request?
SonarQube issue - https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-cWKcVY8lQ4Zr22&open=AW5md-cWKcVY8lQ4Zr22
## What is the link to the Apache JIRA
No JIRA ticket - code improvement contribution
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
Ran the below command which resulted into success
`mvn -T4 clean install`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mookkiah commented on pull request #1748: sonarqube issue fix - "static" members should be accessed statically
Posted by GitBox <gi...@apache.org>.
mookkiah commented on pull request #1748:
URL: https://github.com/apache/ozone/pull/1748#issuecomment-753631947
Build failed because of timeout which is nothing to do with this PR
Error: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test (default-test) on project hadoop-ozone-integration-test: There was a timeout or other error in the fork -> [Help 1]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #1748: HDDS-4748. sonarqube issue fix - "static" members should be accessed statically
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1748:
URL: https://github.com/apache/ozone/pull/1748#issuecomment-767576568
Merging it. Thanks the patch @mookkiah and the review @xiaoyuyao @ayushtkn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #1748: HDDS-4748. sonarqube issue fix - "static" members should be accessed statically
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1748:
URL: https://github.com/apache/ozone/pull/1748#issuecomment-767576034
> Are we checking in without jira id as well? Well creating a jira wouldn't hurt though...
I am fine with merge trivial patches with patches, seems to be an unnecessary overhead for me for small contributions.
But to remain on the safe side I created one Jira (in my Ozone development CLI tool I have a subcommand to create issues for PRS: https://github.com/elek/ogh `ogh jira open 1748`. Not perfect (yet), but I am planning to improve...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #1748: sonarqube issue fix - "static" members should be accessed statically
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #1748:
URL: https://github.com/apache/ozone/pull/1748#issuecomment-763361924
Are we checking in without jira id as well? Well creating a jira wouldn't hurt though...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek merged pull request #1748: HDDS-4748. sonarqube issue fix - "static" members should be accessed statically
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1748:
URL: https://github.com/apache/ozone/pull/1748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org