You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/04/29 19:09:35 UTC
[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3851: [ISSUE #3835]Add final and @Nonnull[EventMeshThreadFactory]
harshithasudhakar opened a new pull request, #3851:
URL: https://github.com/apache/eventmesh/pull/3851
Fixes #3835
### Modifications
Added `final` at line 31, and `@Nonnull` annotation at line 65.
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3851: [ISSUE #3835]Add final and @Nonnull[EventMeshThreadFactory]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3851:
URL: https://github.com/apache/eventmesh/pull/3851#issuecomment-1535835567
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3851?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3851](https://app.codecov.io/gh/apache/eventmesh/pull/3851?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a047068) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/91aab4d4ec18b7644c45e745fc85aafd053d8fd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91aab4d) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head a047068 differs from pull request most recent head 28e554b. Consider uploading reports for the commit 28e554b to get more accurate results
```diff
@@ Coverage Diff @@
## master #3851 +/- ##
=========================================
Coverage 13.77% 13.77%
Complexity 1290 1290
=========================================
Files 571 571
Lines 29129 29129
Branches 2837 2837
=========================================
Hits 4012 4012
Misses 24745 24745
Partials 372 372
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/eventmesh/common/EventMeshThreadFactory.java](https://app.codecov.io/gh/apache/eventmesh/pull/3851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9FdmVudE1lc2hUaHJlYWRGYWN0b3J5LmphdmE=) | `69.56% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3851: [ISSUE #3835]Add final and @Nonnull[EventMeshThreadFactory]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3851:
URL: https://github.com/apache/eventmesh/pull/3851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org