[GitHub] [zeppelin] Reamer commented on a change in pull request #4310: [ZEPPELIN-5670] Frontend CI fails

[GitBox <gi...@apache.org>]

Reamer commented on a change in pull request #4310:
URL: https://github.com/apache/zeppelin/pull/4310#discussion_r826784211



##########
File path: .github/workflows/frontend.yml
##########
@@ -105,17 +105,21 @@ jobs:
           activate-environment: python_3_with_R
           environment-file: testing/env_python_3_with_R.yml
           python-version: 3.7
+          mamba-version: "*"
+          channels: conda-forge,defaults
+          channel-priority: true
           auto-activate-base: false
+          use-mamba: true
       - name: Make IRkernel available to Jupyter
         run: |
           R -e "IRkernel::installspec()"
       - name: install environment
         run: |
           ./mvnw clean install -DskipTests -DskipRat -pl ${INTERPRETERS} -Pspark-2.4 -Phadoop2 -Phelium-dev -Pexamples -Pintegration -Pspark-scala-2.11 -B
           ./mvnw clean package -pl zeppelin-plugins -amd -B
-          ./testing/downloadSpark.sh "2.4.7" "2.7"
       - name: run tests
-        run: xvfb-run --auto-servernum --server-args="-screen 0 1600x1024x16" ./mvnw verify -DskipRat -Pspark-2.4 -Phadoop2 -Phelium-dev -Pexamples -Pintegration -Pspark-scala-2.11 -B -pl zeppelin-integration -DfailIfNoTests=false
+        run: |
+          ./testing/downloadSpark.sh "2.4.7" "2.7" && echo "SPARK_HOME: ${SPARK_HOME}" && xvfb-run --auto-servernum --server-args="-screen 0 1600x1024x16" ./mvnw verify -DskipRat -Pspark-2.4 -Phadoop2 -Phelium-dev -Pexamples -Pintegration -Pspark-scala-2.11 -B -pl zeppelin-integration -DfailIfNoTests=false

Review comment:
       I think it makes sense to define `SPARK_HOME` explicitly here. Preferably with a comment.

##########
File path: zeppelin-integration/pom.xml
##########
@@ -158,6 +158,8 @@
               <target unless="skipTests">
                 <exec executable="./zeppelin-daemon.sh" dir="${zeppelin.daemon.package.base}"
                   spawn="false">
+                  <!-- specify the SPARK_HOME which is downloaded in testing/downloadSpark.sh -->
+                  <env key="SPARK_HOME" value="/home/runner/work/zeppelin/zeppelin/spark-2.4.7-bin-hadoop2.7"/>

Review comment:
       The path prevents execution on other systems.
   Maybe a switch to the maven-failsafe makes sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org