[GitHub] [tvm] cyx-6 commented on a diff in pull request #12786: [TVMScript] IRBuilder methods for `For`

[GitBox <gi...@apache.org>]

cyx-6 commented on code in PR #12786:
URL: https://github.com/apache/tvm/pull/12786#discussion_r972316972


##########
include/tvm/script/ir_builder/tir/frame.h:
##########
@@ -187,6 +187,51 @@ class BlockFrame : public TIRFrame {
   TVM_DEFINE_MUTABLE_NOTNULLABLE_OBJECT_REF_METHODS(BlockFrame, TIRFrame, BlockFrameNode);
 };
 
+/*!
+ * \brief A frame that represents the for loop.
+ *
+ * \sa BlockInitFrame

Review Comment:
   updated



##########
include/tvm/script/ir_builder/tir/frame.h:
##########
@@ -187,6 +187,51 @@ class BlockFrame : public TIRFrame {
   TVM_DEFINE_MUTABLE_NOTNULLABLE_OBJECT_REF_METHODS(BlockFrame, TIRFrame, BlockFrameNode);
 };
 
+/*!
+ * \brief A frame that represents the for loop.
+ *
+ * \sa BlockInitFrame
+ */
+class ForFrameNode : public TIRFrameNode {
+ public:
+  /*! \brief The for loop generating function type. */
+  using FMakeForLoop =
+      runtime::TypedPackedFunc<tvm::tir::Stmt(Array<tvm::tir::Var>, Array<Range>, tvm::tir::Stmt)>;

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org