You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/05/05 18:01:38 UTC
[GitHub] flink pull request #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenienc...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3832
[FLINK-6466] [build] Build Hadoop 2.8.0 convenience binaries
Add Hadoop 2.8 to the create_release_files.sh script and TravisCI test matrix.
Hadoop updated the `httpclient` and `httpcore` dependency versions in ticket 12767 so Flink shading must not specify the old versions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 6466_build_hadoop_280_convenience_binaries
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3832.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3832
----
commit fe94bcf453b5e15f769385e31408c0962a0fab1c
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-05-05T12:39:53Z
[FLINK-6466] [build] Build Hadoop 2.8.0 convenience binaries
Add Hadoop 2.8 to the create_release_files.sh script and TravisCI test
matrix.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenience binar...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3832
I personally think we should not include this into the 1.3 release.
Hadoop 2.8 most likely has new or changed dependencies, with different transitive deps and so on. This can cause issues with our dependency exclusions or shading.
But I'm happy to merge this to `master` for 1.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenience binar...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3832
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenienc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenience binar...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3832
@StephanEwen changes made, and I rebased back a few commits for stable tests and also made yarn-tests non-optional.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenience binar...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3832
I think the convenience binaries are fine. From my side, we can drop convenience builds for Hadoop 2.3 builds in Flink 1.3
Concerning the dependency management entry for `http*`- I think I added that to bump the versions that are pulled by older Hadoop versions (because there were issues). Can you try to bump the version to the latest, rather than removing it from the dependency management section?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenience binar...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3832
@rmetzger +1, agree that these changes are best made at the beginning of the release cycle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenience binar...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3832
@rmetzger @StephanEwen thoughts on releasing 2.8 binaries for Flink 1.3? Are there old versions we can drop for 1.4?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenience binar...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3832
+1 for 1.4 - just spent some good time cleaning up dependencies (also from Hadoop) and this will almost certainly require to do another such pass...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---