You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/01/17 22:52:31 UTC
Review Request 42442: Made Docker::create return an Owned object
instead of a raw pointer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42442/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296
Repository: mesos
Description
-------
Made Docker::create return an Owned object instead of a raw pointer.
Diffs
-----
src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
src/docker/docker.cpp 037cd40f8cf20f75c90bfbfdff252ee5629e4fed
src/docker/executor.cpp 7512d07de6c8324340e6b5f3e5162ef00efc47fc
src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
src/tests/containerizer/docker_containerizer_tests.cpp a1a44daae68e5a4c6961e13ee9e16207c5d54768
src/tests/containerizer/docker_tests.cpp a65d55239a374fff922ade170c6b555e83e47d5b
src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
Diff: https://reviews.apache.org/r/42442/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 42442: Made Docker::create return an Owned object
instead of a raw pointer.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42442/#review115069
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Jan. 17, 2016, 9:52 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42442/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2016, 9:52 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made Docker::create return an Owned object instead of a raw pointer.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp dde2b29deda7e40929e0169935a5bafdd43136b1
> src/docker/docker.cpp 037cd40f8cf20f75c90bfbfdff252ee5629e4fed
> src/docker/executor.cpp 7512d07de6c8324340e6b5f3e5162ef00efc47fc
> src/slave/containerizer/docker.cpp da19975c1f1e59fab0a96ebd9aa815bba2a35ece
> src/tests/containerizer/docker_containerizer_tests.cpp a1a44daae68e5a4c6961e13ee9e16207c5d54768
> src/tests/containerizer/docker_tests.cpp a65d55239a374fff922ade170c6b555e83e47d5b
> src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
>
> Diff: https://reviews.apache.org/r/42442/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>