You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by sh...@apache.org on 2018/05/08 12:17:45 UTC
[trafficserver] branch master updated: Fix clang-analyzer
identified memory leak in test code
This is an automated email from the ASF dual-hosted git repository.
shinrich pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new 84086e6 Fix clang-analyzer identified memory leak in test code
84086e6 is described below
commit 84086e6a8b5cc26a7e44f2593787d2584414a35e
Author: Susan Hinrichs <sh...@oath.com>
AuthorDate: Mon May 7 13:58:25 2018 +0000
Fix clang-analyzer identified memory leak in test code
---
proxy/logging/LogFilter.cc | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/proxy/logging/LogFilter.cc b/proxy/logging/LogFilter.cc
index 821c484..f8d6bad 100644
--- a/proxy/logging/LogFilter.cc
+++ b/proxy/logging/LogFilter.cc
@@ -1092,12 +1092,23 @@ REGRESSION_TEST(Log_FilterParse)(RegressionTest *t, int /* atype */, int *pstatu
} while (0)
*pstatus = REGRESSION_TEST_PASSED;
-
- box.check(LogFilter::parse("t1", LogFilter::ACCEPT, "tok1 tok2") == nullptr, "At least 3 tokens are required");
- box.check(LogFilter::parse("t2", LogFilter::ACCEPT, "%<sym operator value") == nullptr, "Unclosed symbol token");
- box.check(LogFilter::parse("t3", LogFilter::ACCEPT, "%<{Age ssh> operator value") == nullptr, "Unclosed container field");
- box.check(LogFilter::parse("t4", LogFilter::ACCEPT, "%<james> operator value") == nullptr, "Invalid log field");
- box.check(LogFilter::parse("t5", LogFilter::ACCEPT, "%<chi> invalid value") == nullptr, "Invalid operator name");
+ LogFilter *retfilter;
+
+ retfilter = LogFilter::parse("t1", LogFilter::ACCEPT, "tok1 tok2");
+ box.check(retfilter == nullptr, "At least 3 tokens are required");
+ delete retfilter;
+ retfilter = LogFilter::parse("t2", LogFilter::ACCEPT, "%<sym operator value");
+ box.check(retfilter == nullptr, "Unclosed symbol token");
+ delete retfilter;
+ retfilter = LogFilter::parse("t3", LogFilter::ACCEPT, "%<{Age ssh> operator value");
+ box.check(retfilter == nullptr, "Unclosed container field");
+ delete retfilter;
+ retfilter = LogFilter::parse("t4", LogFilter::ACCEPT, "%<james> operator value");
+ box.check(retfilter == nullptr, "Invalid log field");
+ delete retfilter;
+ retfilter = LogFilter::parse("t5", LogFilter::ACCEPT, "%<chi> invalid value");
+ box.check(retfilter == nullptr, "Invalid operator name");
+ delete retfilter;
CHECK_FORMAT_PARSE("pssc MATCH 200");
CHECK_FORMAT_PARSE("shn CASE_INSENSITIVE_CONTAIN unwanted.com");
--
To stop receiving notification emails like this one, please contact
shinrich@apache.org.