You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "JeetKunDoug (via GitHub)" <gi...@apache.org> on 2023/08/11 14:00:27 UTC
[GitHub] [cassandra] JeetKunDoug opened a new pull request, #2579: CASSANDRA-18725: IsolatedJmx should only remove the endpoints it created when stopping (4.1)
JeetKunDoug opened a new pull request, #2579:
URL: https://github.com/apache/cassandra/pull/2579
CASSANDRA-18725: IsolatedJmx should only remove the endpoints it created when stopping
IsolatedJmx previously cleared the entire TCPEndpoint map field, which could remove the endpoints from other,
running instances. Now, we make sure to only clear the endpoints created by that instance, which allows for
other instances to keep running and for this instance to restart without issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jonmeredith commented on a diff in pull request #2579: CASSANDRA-18725: IsolatedJmx should only remove the endpoints it created when stopping (4.1)
Posted by "jonmeredith (via GitHub)" <gi...@apache.org>.
jonmeredith commented on code in PR #2579:
URL: https://github.com/apache/cassandra/pull/2579#discussion_r1295120395
##########
test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java:
##########
@@ -18,38 +18,40 @@
package org.apache.cassandra.distributed.impl;
-import java.lang.reflect.Field;
+import java.io.IOException;
import java.net.InetAddress;
-import java.net.MalformedURLException;
import java.util.HashMap;
-import java.util.Iterator;
+import java.util.LinkedList;
import java.util.Map;
+import java.util.concurrent.TimeUnit;
import javax.management.remote.JMXConnector;
-import javax.management.remote.JMXConnectorFactory;
import javax.management.remote.JMXConnectorServer;
import javax.management.remote.JMXServiceURL;
import javax.management.remote.rmi.RMIConnectorServer;
import javax.management.remote.rmi.RMIJRMPServerImpl;
import org.slf4j.Logger;
+import com.google.monitoring.runtime.instrumentation.common.util.concurrent.Uninterruptibles;
Review Comment:
Wrong import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] JeetKunDoug commented on a diff in pull request #2579: CASSANDRA-18725: IsolatedJmx should only remove the endpoints it created when stopping (4.1)
Posted by "JeetKunDoug (via GitHub)" <gi...@apache.org>.
JeetKunDoug commented on code in PR #2579:
URL: https://github.com/apache/cassandra/pull/2579#discussion_r1300510974
##########
test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java:
##########
@@ -18,38 +18,40 @@
package org.apache.cassandra.distributed.impl;
-import java.lang.reflect.Field;
+import java.io.IOException;
import java.net.InetAddress;
-import java.net.MalformedURLException;
import java.util.HashMap;
-import java.util.Iterator;
+import java.util.LinkedList;
import java.util.Map;
+import java.util.concurrent.TimeUnit;
import javax.management.remote.JMXConnector;
-import javax.management.remote.JMXConnectorFactory;
import javax.management.remote.JMXConnectorServer;
import javax.management.remote.JMXServiceURL;
import javax.management.remote.rmi.RMIConnectorServer;
import javax.management.remote.rmi.RMIJRMPServerImpl;
import org.slf4j.Logger;
+import com.google.monitoring.runtime.instrumentation.common.util.concurrent.Uninterruptibles;
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #2579: CASSANDRA-18725: IsolatedJmx should only remove the endpoints it created when stopping (4.1)
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #2579: CASSANDRA-18725: IsolatedJmx should only remove the endpoints it created when stopping (4.1)
URL: https://github.com/apache/cassandra/pull/2579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org