[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29573: [SPARK-32731][SQL][TEST] Add tests for arrays/maps of nested structs to ReadSchemaSuite to test structs reuse

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #29573:
URL: https://github.com/apache/spark/pull/29573#discussion_r592099376



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/ReadSchemaTest.scala
##########
@@ -72,6 +72,58 @@ trait ReadSchemaTest extends QueryTest with SharedSparkSession {
   val options: Map[String, String] = Map.empty[String, String]
 }
 
+trait ArrayWithNestedStructTest extends ReadSchemaTest {

Review comment:
       The goal of `ReadSchemaTest` is the following (https://github.com/apache/spark/pull/29573/files#diff-ff46c4f16bf7cb1f09e74b70b0ba3bc6be62203824a2fe16c4c473e34fd18d7fR24).
   ```
   Read schema suites have the following hierarchy and aims to guarantee users a backward-compatible read-schema change coverage
   ```
   To simply put, it was about a kind of acceptable schema evolution. However, the new test suites `ArrayWithNestedStructTest` and `MapWithNestedStructTest` seems to have no schema evolution.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org