[GitHub] [hive] lcspinter commented on a diff in pull request #3521: HIVE-26471: New metric for Compaction pooling

[GitBox <gi...@apache.org>]

lcspinter commented on code in PR #3521:
URL: https://github.com/apache/hive/pull/3521#discussion_r972989266


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/CompactionMetricData.java:
##########
@@ -148,6 +152,10 @@ Map<String, Long> getStateCount() {
     return new HashMap<>(stateCount);
   }
 
+  public Map<String, Integer> getPoolCount() {
+    return new HashMap<>(poolCount);

Review Comment:
   If the statecount and poolcount are meant to be immutable, why don't we return an immutable hashmap? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org