You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Pavel Voronkin (JIRA)" <ji...@apache.org> on 2019/01/15 16:42:00 UTC
[jira] [Comment Edited] (IGNITE-10877)
GridAffinityAssignment.initPrimaryBackupMaps memory pressure
[ https://issues.apache.org/jira/browse/IGNITE-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743205#comment-16743205 ]
Pavel Voronkin edited comment on IGNITE-10877 at 1/15/19 4:41 PM:
------------------------------------------------------------------
Benchmark Mode Cnt Score Error Units
SmallHashSetsVsReadOnlyViewBenchmark.hashSetContainsRandom thrpt 20 25690717,349 ± 200741,979 ops/s
SmallHashSetsVsReadOnlyViewBenchmark.hashSetIteratorRandom thrpt 20 12836581,770 ± 248020,906 ops/s
SmallHashSetsVsReadOnlyViewBenchmark.readOnlyViewContainsRandom thrpt 20 22278517,368 ± 339376,502 ops/s
SmallHashSetsVsReadOnlyViewBenchmark.readOnlyViewIteratorRandom thrpt 20 19959598,363 ± 709696,316 ops/s
we see 2x improvement in iterator and slight reduce in contains() in addition to reduced allocations.
was (Author: voropava):
Benchmark Mode Cnt Score Error Units
SmallHashSetsVsReadOnlyViewBenchmark.hashSetContainsRandom thrpt 20 26221395,193 ± 240929,392 ops/s
SmallHashSetsVsReadOnlyViewBenchmark.hashSetIteratorRandom thrpt 20 12626598,194 ± 1742223,886 ops/s
SmallHashSetsVsReadOnlyViewBenchmark.readOnlyViewContainsRandom thrpt 20 23301229,681 ± 534549,170 ops/s
SmallHashSetsVsReadOnlyViewBenchmark.readOnlyViewIteratorRandom thrpt 20 21134614,093 ± 666488,488 ops/s
we see 2x improvement in iterator and slight reduce in contains() in addition to reduced allocations.
> GridAffinityAssignment.initPrimaryBackupMaps memory pressure
> ------------------------------------------------------------
>
> Key: IGNITE-10877
> URL: https://issues.apache.org/jira/browse/IGNITE-10877
> Project: Ignite
> Issue Type: Improvement
> Reporter: Pavel Voronkin
> Assignee: Pavel Voronkin
> Priority: Major
> Attachments: grid.srv.node.1.0-29.12.2018-12.50.15.jfr
>
>
> 1) While running tests with JFR we observe huge memory allocation pressure produced by:
> *Stack Trace TLABs Total TLAB Size(bytes) Pressure(%)*
> java.util.HashMap.newNode(int, Object, Object, HashMap$Node) 481 298 044 784 100
> java.util.HashMap.putVal(int, Object, Object, boolean, boolean) 481 298 044 784 100
> java.util.HashMap.put(Object, Object) 481 298 044 784 100
> java.util.HashSet.add(Object) 480 297 221 040 99,724
> org.apache.ignite.internal.processors.affinity.GridAffinityAssignment.initPrimaryBackupMaps() 1 823 744 0,276
> org.apache.ignite.internal.processors.affinity.GridAffinityAssignment.<init>(AffinityTopologyVersion, List, List) 1 823 744 0,276
> *Allocation stats*
> Class Average Object Size(bytes) Total Object Size(bytes) TLABs Average TLAB Size(bytes) Total TLAB Size(bytes) Pressure(%)
> java.util.HashMap$Node 32 15 392 481 619 635,726 298 044 784 32,876
> java.lang.Object[] 1 470,115 461 616 314 655 019,236 205 676 040 22,687
> java.util.HashMap$Node[] 41 268,617 6 149 024 149 690 046,067 102 816 864 11,341
> java.lang.Integer 16 1 456 91 662 911,385 60 324 936 6,654
> java.util.ArrayList 24 1 608 67 703 389,97 47 127 128 5,198
> 2) Also another hot place found
> Stack Trace TLABs Total TLAB Size(bytes) Pressure(%)
> java.util.ArrayList.grow(int) 7 5 766 448 9,554
> java.util.ArrayList.ensureExplicitCapacity(int) 7 5 766 448 9,554
> java.util.ArrayList.ensureCapacityInternal(int) 7 5 766 448 9,554
> java.util.ArrayList.add(Object) 7 5 766 448 9,554
> org.apache.ignite.internal.processors.cache.distributed.dht.topology.GridDhtPartitionTopologyImpl.nodes(int, AffinityTopologyVersion, GridDhtPartitionState, GridDhtPartitionState[]) 7 5 766 448 9,554
> The reason of that is defail
> I think we need to improve memory efficiency by switching from from Sets to BitSets
>
> JFR attached, see Allocations in 12:50:28 - 12:50:29
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)