You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by kmurra <gi...@git.apache.org> on 2017/10/04 21:55:33 UTC

[GitHub] flink issue #4746: [FLINK-7657] [Table] Adding logic to convert RexLiteral t...

Github user kmurra commented on the issue:

    https://github.com/apache/flink/pull/4746
  
    Regarding the time zones, I think I understand your argument here.  Is there anything in particular that you would want me to change overall that you haven't already outlined to account for that? I do want to document why we're doing any conversions of time zones since it took me some amount of time to understand why it was being done (it looked incorrect to myself and several other developers on first glance).
    
    Also, I noticed that the Calcite fromCalendarFields simply take the fields directly from the Calendar, so making time-zone adjustments are unnecessary after I made the changes to toRexNode.  I'll fix that as well for my next commit.


---