You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/05/26 15:18:32 UTC
Review Request 47897: RANGER-996 - The PolicyRefresher doesn't cache
policies if the directory doesn't already exist
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/
-----------------------------------------------------------
Review request for ranger.
Repository: ranger
Description
-------
The PolicyRefresher doesn't cache policies if the directory doesn't already exist
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3
Diff: https://reviews.apache.org/r/47897/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 47897: RANGER-996 - The PolicyRefresher doesn't
cache policies if the directory doesn't already exist
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/#review135002
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On May 26, 2016, 3:30 p.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47897/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 3:30 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-996
> https://issues.apache.org/jira/browse/RANGER-996
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The PolicyRefresher doesn't cache policies if the directory doesn't already exist
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3
>
> Diff: https://reviews.apache.org/r/47897/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 47897: RANGER-996 - The PolicyRefresher doesn't
cache policies if the directory doesn't already exist
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On May 27, 2016, 5:37 a.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java, line 78
> > <https://reviews.apache.org/r/47897/diff/1/?file=1395466#file1395466line78>
> >
> > mkdirs() can throw SecurityException, which will cause PolicyRefresh constructor to fail. http://docs.oracle.com/javase/6/docs/api/java/io/File.html#mkdirs%28%29
> >
> > Better to move this logic of creating parent diretories to saveToCache(), just before line #319 (or #313?). This will check for parent directory existence on every save attempt - hence enabling recovery (by fixing the permission issue externally) without requiring restart of the component.
Good idea Madhan. Please take a look at the updated diff and let me know what you think.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/#review135154
-----------------------------------------------------------
On May 26, 2016, 3:30 p.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47897/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 3:30 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-996
> https://issues.apache.org/jira/browse/RANGER-996
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The PolicyRefresher doesn't cache policies if the directory doesn't already exist
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3
>
> Diff: https://reviews.apache.org/r/47897/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 47897: RANGER-996 - The PolicyRefresher doesn't
cache policies if the directory doesn't already exist
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/#review135154
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java (line 78)
<https://reviews.apache.org/r/47897/#comment200177>
mkdirs() can throw SecurityException, which will cause PolicyRefresh constructor to fail. http://docs.oracle.com/javase/6/docs/api/java/io/File.html#mkdirs%28%29
Better to move this logic of creating parent diretories to saveToCache(), just before line #319 (or #313?). This will check for parent directory existence on every save attempt - hence enabling recovery (by fixing the permission issue externally) without requiring restart of the component.
- Madhan Neethiraj
On May 26, 2016, 3:30 p.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47897/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 3:30 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-996
> https://issues.apache.org/jira/browse/RANGER-996
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The PolicyRefresher doesn't cache policies if the directory doesn't already exist
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3
>
> Diff: https://reviews.apache.org/r/47897/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 47897: RANGER-996 - The PolicyRefresher doesn't
cache policies if the directory doesn't already exist
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/#review135230
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 27, 2016, 12:40 p.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47897/
> -----------------------------------------------------------
>
> (Updated May 27, 2016, 12:40 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-996
> https://issues.apache.org/jira/browse/RANGER-996
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The PolicyRefresher doesn't cache policies if the directory doesn't already exist
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3
>
> Diff: https://reviews.apache.org/r/47897/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 47897: RANGER-996 - The PolicyRefresher doesn't
cache policies if the directory doesn't already exist
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/
-----------------------------------------------------------
(Updated May 27, 2016, 12:40 p.m.)
Review request for ranger.
Bugs: RANGER-996
https://issues.apache.org/jira/browse/RANGER-996
Repository: ranger
Description
-------
The PolicyRefresher doesn't cache policies if the directory doesn't already exist
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3
Diff: https://reviews.apache.org/r/47897/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 47897: RANGER-996 - The PolicyRefresher doesn't
cache policies if the directory doesn't already exist
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/#review135207
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java (line 311)
<https://reviews.apache.org/r/47897/#comment200243>
If exceptions from mkdirs() are not caught here, it will cause PolicyRefresher() thread to exit. Please add a catch block here to log a warning and ignore the exception.
- Madhan Neethiraj
On May 27, 2016, 10:05 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47897/
> -----------------------------------------------------------
>
> (Updated May 27, 2016, 10:05 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-996
> https://issues.apache.org/jira/browse/RANGER-996
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The PolicyRefresher doesn't cache policies if the directory doesn't already exist
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3
>
> Diff: https://reviews.apache.org/r/47897/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 47897: RANGER-996 - The PolicyRefresher doesn't
cache policies if the directory doesn't already exist
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/
-----------------------------------------------------------
(Updated May 27, 2016, 10:05 a.m.)
Review request for ranger.
Bugs: RANGER-996
https://issues.apache.org/jira/browse/RANGER-996
Repository: ranger
Description
-------
The PolicyRefresher doesn't cache policies if the directory doesn't already exist
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3
Diff: https://reviews.apache.org/r/47897/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 47897: RANGER-996 - The PolicyRefresher doesn't
cache policies if the directory doesn't already exist
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47897/
-----------------------------------------------------------
(Updated May 26, 2016, 3:30 p.m.)
Review request for ranger.
Bugs: RANGER-996
https://issues.apache.org/jira/browse/RANGER-996
Repository: ranger
Description
-------
The PolicyRefresher doesn't cache policies if the directory doesn't already exist
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java 91a23b3
Diff: https://reviews.apache.org/r/47897/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh